A question to Denes Kubicek (Repeating Calendar)

Question

Hi Denes!
I've an issue with the calendar function you've posted on the blog...I was using it preety much and it was working fine until I've modified it with some if clauses...
It looks like this now...
create or replace FUNCTION return_table_fn
RETURN session_table_type
AS
v_data session_table_type := session_table_type ();
v_cnt NUMBER DEFAULT 0;
v_date DATE;
v_days NUMBER;
v_count1 NUMBER := 1;
v_count2 NUMBER := 1;
BEGIN
FOR c IN (select
EMPLOYEE_ID,
CUSTOMER_ID,
SERVICE_ID,
START_DATE,
END_DATE,
DAY_START_HOUR,
DAY_END_HOUR,
CYCLIC,
WITH_SATURDAY,
WITH_SUNDAY,
CALL_PRIORITY,
WITH_HOLIDAY
from WORKSHOP.PMS_SCHEDULE)
LOOP
v_days := c.END_DATE + 1 - c.START_DATE;
FOR i IN v_count1 .. v_days + (v_count1 - 1)
LOOP
v_date := (c.START_DATE - 1) + v_count2;
IF TO_CHAR((v_date),'fmD') < 6 THEN
v_data.EXTEND;
v_data (v_data.COUNT) := session_rectype (v_date, c.EMPLOYEE_ID,c.CUSTOMER_ID,c.SERVICE_ID,c.DAY_START_HOUR,c.DAY_END_HOUR,c.CYCLIC,c.WITH_SATURDAY,c.WITH_SUNDAY,c.WITH_HOLIDAY,c.CALL_PRIORITY);
ELSIF c.WITH_SATURDAY = 'Y' and TO_CHAR((v_date),'fmD') = 6 THEN
v_data.EXTEND;
v_data (v_data.COUNT) := session_rectype (v_date, c.EMPLOYEE_ID,c.CUSTOMER_ID,c.SERVICE_ID,c.DAY_START_HOUR,c.DAY_END_HOUR,c.CYCLIC,c.WITH_SATURDAY,c.WITH_SUNDAY,c.WITH_HOLIDAY,c.CALL_PRIORITY);
ELSIF c.WITH_SUNDAY = 'Y' and TO_CHAR((v_date),'fmD') = 7 THEN
v_data.EXTEND;
v_data (v_data.COUNT) := session_rectype (v_date, c.EMPLOYEE_ID,c.CUSTOMER_ID,c.SERVICE_ID,c.DAY_START_HOUR,c.DAY_END_HOUR,c.CYCLIC,c.WITH_SATURDAY,c.WITH_SUNDAY,c.WITH_HOLIDAY,c.CALL_PRIORITY);
END IF;
v_count1 := v_count1 + 1;
v_count2 := v_count2 + 1;
END LOOP;
v_count2 := 1;
END LOOP;
RETURN v_data;
END;
My point for the code was not to show sunday or saturdays...but it doesnt show fridays...its very weird..if i delete the if clauses then calendar works preety fine again...
Do you maybe by any chance know why ??
With regards,
PsmakR

Answer 1

Thank you Denes for y our quick reply...unfortunately it doesnt work for me...
I work on SQL Develoepr and when I type there ALTER SESSION... my calendar still dont show fridays...If I add ALTER SESSION.. in to the function my calendar is not showing anythiing at all ..there is an error - Cannot perform DML and so on..
To your information in POLISH nls saturday and sunday is 6th and 7th day of week...
Maybe I'll paste you also my calendar query:
SELECT
session_date,
TO_CHAR((SESSION_DATE),'fmD') day,
employee_id,
(SELECT SURNAME || ', ' || FIRST_NAME from PMS_EMPLOYEES) EMPLOYEE,
customer_id,
(SELECT CUSTOMER_NAME FROM PMS_CUSTOMERS) CUSTOMER,
service_id,
(SELECT SERVICE_NAME FROM PMS_SERVICES) SERVICE,
(SELECT (EXTRACT(HOUR FROM DAY_END_HOUR) - EXTRACT(HOUR FROM DAY_START_HOUR)) from PMS_SCHEDULE) HOURS,
cyclic,
with_saturday,
with_sunday,
call_priority PRIORITY,
with_holiday
FROM TABLE (SELECT return_table_fn () AS session_table_type
FROM DUAL)
Maybe you have some other ideas ??
With regards,
PsmakR