Abap Logic for performance tuning not working when using Internal tables

Question

Hi,
I wrote this piece of code that is working correctly that is select SUM of cost from DSO where Plant is the same for Sales Items.
LOOP AT RESULT_PACKAGE INTO rp.
SELECT SUM( /N/S_STRDCOST ) FROM /N/ADSP_DPIT00 INTO
rp-/N/S_STRDCOST
WHERE /N42/S_SALESITEM = rp-/N42/S_ITEMID AND /N42/S_PLPLANT EQ
rp-/N42/S_SOURCE.
MODIFY RESULT_PACKAGE FROM rp.
Clear rp.
ENDLOOP.
Now I try to rewrite it for performance tunning using internal table  but I am getting 0 values. can't figure out whats the problem and been struggling fixing it.
TYPES : begin of ty_DSO_TABLE,
         /N42/S_STRDCOST TYPE /N/ADSP_DSPC00-/N/S_STRDCOST,
         /N42/S_ITEMID TYPE /N/ADSP_DSPC00-/N/S_ITEMID,
       end of ty_DSO_TABLE.
DATA: it_DSO_TABLE type hashed table of ty_DSO_TABLE with unique key
/N/S_ITEMID,
     wa_DSO_TABLE type ty_DSO_TABLE.
Field-symbols:  <rp> TYPE tys_TG_1.
LOOP AT RESULT_PACKAGE assigning <rp>.
  clear wa_DSO_TABLE.
Read table IT_DSO_TABLE into wa_DSO_TABLE with table key /N/S_ITEMID
  = <rp>-/N/S_ITEMID.
  if sy-subrc ne 0.
      select SUM( /N/S_STRDCOST )  into CORRESPONDING
      FIELDS OF wa_DSO_TABLE from
      /N/ADSP_DPIT00 WHERE /N/S_SALESITEM =  <rp>-/N/S_ITEMID AND
      /N/S_PLPLANT EQ <rp>-/N/S_SOURCE.
     if sy-subrc eq 0.
          <rp>-/N/S_STRDCOST = wa_DSO_TABLE-/N/S_STRDCOST.
     endif.
endif.
ENDLOOP.
Any idea whats wrong with the code
thanks

Answer 1

Hi Vaidya,
According to the code which you have written, there is no value in table IT_DSO_TABLE when you are trying to read the values.And after the read statement you have given a condition for sy-subrc. Hence the select statement is actually not even getting executed. *Also you have not assigned the final value back to the ResultPackage.*_
So Kindly correct your code as follows:
Data: wa_dso type ty_DSO_TABLE.
LOOP AT RESULT_PACKAGE assigning <rp>.
clear wa_DSO_TABLE.
select SUM( /N/S_STRDCOST ) into CORRESPONDING
FIELDS OF wa_DSO_TABLE from
/N/ADSP_DPIT00 WHERE /N/S_SALESITEM = <rp>-/N/S_ITEMID AND
/N/S_PLPLANT EQ <rp>-/N/S_SOURCE.
if sy-subrc eq 0.
<rp>-/N/S_STRDCOST = wa_DSO_TABLE-/N/S_STRDCOST.
MODIFY RESULT_PACKAGE FROM <rp>.
endif.
ENDLOOP.
Hope this helps you.
Regards,
Satyam