Bulk Select and FOR ALL update not working

Question

Hi
I am trying to run this but it does not work. I get this error
PLS-00430: FORALL iteration variable I is not allowed in this context
declare
cursor c is
select employee_number, national_identifier,
last_name, first_name
from per_all_people_f;
type en_tab is table of per_all_people_f.employee_number%type;
type ni_tab is table of per_all_people_f.national_identifier%type;
type ln_tab is table of per_all_people_f.last_name%type;
type fn_tab is table of per_all_people_f.first_name%type;
en en_tab;
ni ni_tab;
ln ln_tab;
fn fn_tab;
begin
open c;
loop
fetch c bulk collect into en, ni, ln,fn;
forall i in 1..en.count
update xxdl_hr_people_interface
set first_name = fn(i),last_name = ln(i),national_identifier = ni(i)
where employee_number = en(i);
exit when c%notfound;
end loop;
close c;
end;
But if I dont try to update first_name ,last_name, national_identifer at the same time and modify the block to be like this, it runs
declare
cursor c is
select employee_number, national_identifier,
last_name, first_name
from per_all_people_f;
type en_tab is table of per_all_people_f.employee_number%type;
type ni_tab is table of per_all_people_f.national_identifier%type;
type ln_tab is table of per_all_people_f.last_name%type;
type fn_tab is table of per_all_people_f.first_name%type;
en en_tab;
ni ni_tab;
ln ln_tab;
fn fn_tab;
begin
open c;
loop
fetch c bulk collect into en, ni, ln,fn;
forall i in 1..en.count
update xxdl_hr_people_interface
set first_name = fn(i)
where employee_number = en(i);
exit when c%notfound;
end loop;
close c;
end;
Any pointers on why this does not work?
Thank you
Kumar

Answer 1

If per_all_people_f has a PK or unique index on employee_number, then you can do:
UPDATE (SELECT pi.first_name, pi.last_name, pi.national_identifier,
               pf.first_name pffirst, pf.last_name pflast,
               pf.national_identifier pfnat
        FROM xxdl_hr_people_interface pi, per_all_people_f pf
        WHERE pf.employee_number = pi.employee_number)
SET first_name = pffirst,
    last_name = pflast,
    national_identifeir = pfnatIf not, you can do:
UPDATE xxdl_hr_people_interface pi
SET (first_name, last_name, national_identifier) =
            (SELECT first_name, last_name, national_identifier
             FROM per_all_people_f pf
             WHERE pf.employee_number = pi.employee_number)
WHERE EXISTS (SELECT 1
              FROM per_all_people_f pf
              WHERE pf.employee_number = pi.employee_number)Note that if there might be more than one row in per_all_people_f for an employee_id, then you need to modify the select sub-query to add a predicate to make sure it only returns one row for each employee_number.
John