Contatination string with number

Question

Hi,
i have to concatinate string with number
like
create or replace
PROCEDURE sp1(
p1 NUMBER DEFAULT NULL
as
v_numId number(7,0)
begin
if v_numId is not null then
--1)v_nstrQuery:='select * from abc where id=' || v_numId;
--or
-2)-v_nstrQuery:='select * from abc where id=' || cast( v_numId as varchar2);
end
else
v_nstrQuery:='select * from abc ' ;
end if;
begin
EXECUTE IMMEDIATE v_nstrQuery INTO v_strMeasurementBasis1;
end;
end;
1) which one i should use from 1 and 2
2) i also noticed that , it show blue curly line under varchar2 of line second saying. "syntex error expected : identifer number_datatype number"
2) i noticed that begin and end; srounding execute immediate
is not required , please suggenst should i use it or not.
yours sincerly.

Answer 1

See iin bold below
create or replace
PROCEDURE sp1(
p1 NUMBER DEFAULT NULL
as
v_numId number(7,0)
begin
if v_numId is not null then
--1)v_nstrQuery:='select * from abc where id=' || v_numId;
--or
-2)-v_nstrQuery:='select * from abc where id=' || cast( v_numId as varchar2);
end
else
v_nstrQuery:='select * from abc ' ;
end if;
begin
EXECUTE IMMEDIATE v_nstrQuery INTO v_strMeasurementBasis1;
end;
end;
1) which one i should use from 1 and 2 first oneis fne, no need to cast to varchar2
2) i also noticed that , it show blue curly line under varchar2 of line second saying. "syntex error expected : identifer number_datatype number"
2) i noticed that begin and end; srounding execute immediate if you need to write / handle any exception begin and end should be there
is not required , please suggenst should i use it or not.
Edited by: Kiran on Dec 21, 2012 1:45 AM