Could I refactor the Database query functions?

Question

Hi,
I have a lot of functions which doing the database queries. They all return map. "select to_chat(key), to_chart(value) from table"
code like following. Since so many database access parts are same.
only "query", and "preparestatement. setString(1, "aa") , preparestatement. setString(2, "aa") ..........." are different . I wonder if I could refactor them.
If I could, I use dataSource in websphere. Is there any syncronizaion issue in it.
Thank you so much.
public Map getPriceChangeData(
          Timestamp openTime,
          Timestamp closeTime)
          throws Exception {
TreeMap openCloseData = new TreeMap();
Connection conn = null;
PreparedStatement pstmt = null;
ResultSet rs = null;
final String query ="select to_char(?), to_char(?) from table1";
try {
conn = DSDataLayer.connect();
pstmt = conn.prepareStatement(query);
pstmt.setInt(1, 3);
psmt.setInt(2. 6);
( the psmt.set... could be any number
rs = pstmt.executeQuery();
while (rs.next()) {
openClosetData.put(
     rs.getString(1),
     rs.getString(2));
return openClosetData;
} catch (SQLException se) {
String err =GETOPENCLOSE_ERR+ "on query"
+ query
+ " "
     + se.toString();
               throw new Exception(err);
          } catch (Exception e) {
               String err = GETOPENCLOSE_ERR
                         + e.toString();
               throw new Exception(err);
          } finally {
               try {
                    if (rs != null)
                         rs.close();
                    if (pstmt != null)
                         pstmt.close();
                    if (conn != null)
                         conn.close();
               } catch (SQLException sqle) {
                    //log error and continue
               } finally {
                    rs = null;
                    pstmt = null;
                    conn = null;
     }

Answer 1

ResultSet rs = st.executeQuery("SELECT Customer_No FROM ServiceLogRecdb1");
while(rs.next())
{System.out.println(rs.getString("ServiceNo")+"\t"+rs.getString ("CustomerNo")+"\t"+rs.getString("IBMPMRNo"));
Customer_No.setText(rs.getString("CustomerNo"));
iServiceNo.setText(rs.getString("ServiceNo"));
iCompanyName.setText(rs.getString("CompanyName"));
iAddress.setText(rs.getString("Address"));
iWorkOrderNo.setText(rs.getString("WorkOrderNo"));
iTotalHours.setText(rs.getString("TotalHours"));
iRequestDate.setText(rs.getString("RequestDate"));
iContactNo.setText(rs.getString("ContactNo"));
iRequestedBy.setText(rs.getString("RequestedBy"));
iTimeIn.setText(rs.getString("TimeIn"));
iTimeOut.setText(rs.getString("TimeOut"));
iHoursDeducted.setText(rs.getString("HoursDeducted"));
iIBMPMRNo.setText(rs.getString("IBMPMRNo"));
iServiceDescriptionRequest.setText(rs.getString("ServiceDescriptionRequest"));
iActionTaken.setText(rs.getString("ActionTaken"));
iEngineer.setText(rs.getString("Engineer")); }Wrong implementation....
if SELECT Customer_No FROM ServiceLogRecdb1 is your query it is certain that the ResultSet Holds values of only Customer_No not all other fields.
I advice u to recheck wid your DB query again.....
REGARDS,
RaHuL