Create function ....problem

Question

hi
what wrong i am doing while creating the below function
please guide me
1 CREATE OR REPLACE Function UNR_TIME
2 ( name_in IN NUMBER )
3 RETURN varchar2
4 IS
5 cnumber varchar2(4000);
6 BEGIN
7 IF LENGTH(TO_CHAR(NAME_IN))<8 THEN
8 CNUMBER := LPAD(TO_CHAR(NAME_IN),8,'0');
9 END IF;
10 CNUMBER := SUBSTR(TO_CHAR(CNUMBER),1,2)||':'||
11 SUBSTR(TO_CHAR(CNUMBER),3,2)||':'||
12 SUBSTR(TO_CHAR(CNUMBER),5,2)||':'||
13 SUBSTR(TO_CHAR(CNUMBER),7,2);
14 RETURN cnumber;
15* END;
SQL> /
Function created.
SQL> SELECT UNR_TIME(12345678) FROM DUAL;
UNR_TIME(12345678)
SQL>

Answer 1

Ok. Looks like i need to handle the null here. So, here is this corrected solution for you ->
satyaki>
satyaki>CREATE OR REPLACE Function UNR_TIME(
  2                                        name_in IN NUMBER
  3                                     )
  4  RETURN varchar2
  5  IS
  6   CNUMBER varchar2(100);
  7  BEGIN
  8   IF LENGTH(NAME_IN)<8 THEN
  9      CNUMBER := LPAD(TO_CHAR(NAME_IN),8,'0');
10   ELSE
11     CNUMBER := nvl(to_char(name_in),'00000000');
12   END IF;
13  
14   CNUMBER := SUBSTR(CNUMBER,1,2)||':'||
15              SUBSTR(CNUMBER,3,2)||':'||
16              SUBSTR(CNUMBER,5,2)||':'||
17              SUBSTR(CNUMBER,7,2);
18  
19   RETURN CNUMBER;
20  END;
21  /
Function created.
Elapsed: 00:00:00.71
satyaki>
satyaki>
satyaki>SELECT UNR_TIME(null) from dual;
UNR_TIME(NULL)
00:00:00:00
Elapsed: 00:00:00.06
satyaki>
satyaki>SELECT UNR_TIME(12345678) from dual;
UNR_TIME(12345678)
12:34:56:78
Elapsed: 00:00:00.07
satyaki>
satyaki>SELECT UNR_TIME(1234567) from dual;
UNR_TIME(1234567)
01:23:45:67
Elapsed: 00:00:00.06
satyaki>
satyaki>SELECT UNR_TIME(123456) from dual;
UNR_TIME(123456)
00:12:34:56
Elapsed: 00:00:00.04
satyaki>
satyaki>SELECT UNR_TIME(12345) from dual;
UNR_TIME(12345)
00:01:23:45
Elapsed: 00:00:00.04
satyaki>
satyaki>SELECT UNR_TIME(1234) from dual;
UNR_TIME(1234)
00:00:12:34
Elapsed: 00:00:00.08
satyaki>
satyaki>SELECT UNR_TIME(123) from dual;
UNR_TIME(123)
00:00:01:23
Elapsed: 00:00:00.09
satyaki>
satyaki>SELECT UNR_TIME(12) from dual;
UNR_TIME(12)
00:00:00:12
Elapsed: 00:00:00.06
satyaki>
satyaki>SELECT UNR_TIME(1) from dual;
UNR_TIME(1)
00:00:00:01
Elapsed: 00:00:00.09
satyaki>Regards.
Satyaki De.