Criticize my first ever PKGBUILD (fluxbb)

Question

So I went to put a forum on a website I was working on and what better forum engine to use than the very same one bbs uses...  and then I realize there's no PKGBUILD in ABS or AUR for fluxbb, so I decided to make a simple one.  Please keep in mind this is my first so be gentle.
Also, let me know if you think it should be more interactive: for example /srv/http is not everyone's base webserver directory and people may want to change the name of "/upload" to something more fitting like "/forums".
# Contributor: DefunctProcess <[email protected]>
pkgname=fluxbb
pkgver=1.2.22
pkgrel=1
pkgdesc="The forum engine that archlinux.org uses."
arch=('i686' 'x86_64')
url="fluxbb.org"
license=('GPL')
groups=()
depends=()
makedepends=()
optdepends=()
provides=()
conflicts=()
replaces=()
backup=()
options=()
install=
source=(http://fluxbb.org/download/releases/$pkgver/$pkgname-$pkgver.tar.gz)
noextract=()
md5sums=('6fac6a426be6c263abe545e3656e5493')
build() {
cd "$srcdir/$pkgname-$pkgver"
#Modifying permissions of subdirectories in upload
chmod 777 upload/cache || echo "Error: you must manually chmod 777 /upload/cache"
chmod 777 upload/img/avatars || echo "Error: you must manually chmod 777 /upload/img/avatars"
#Creating install path
mkdir -p \
"$pkgdir/srv/http/upload" \ || return 1
#Copying...
cp -R $srcdir/$pkgname-$pkgver/upload $pkgdir/srv/http/
Last edited by blazercist (2010-04-08 04:42:27)

Answer 1

IMHO....
# Contributor: DefunctProcess <[email protected]>
You are the Maintainer, not a past contributor
source=(http://fluxbb.org/download/releases/$pkgver/$pkgname-$pkgver.tar.gz)
Double quote the URL.... If nothing else, it improves readability when using an editor with syntax highlighting.
chmod 777 upload/cache || echo "Error: you must manually chmod 777 /upload/cache"
chmod 777 upload/img/avatars || echo "Error: you must manually chmod 777 /upload/img/avatars"
1) Change the echo to 'return 1' like you've done in other places. Let the chmod error message give feedback to the user.
2) chmod 777 is BAD. chown and/or chgrp and chmod g+w the directories to '33' (http) instead.
mkdir -p \
"$pkgdir/srv/http/upload" \ || return 1
Don't bother wrapping lines like this.
Just my HO, otherwise quite good for a first PKGBUILD