Cursor problem

Question

Hi all,
i am attempting to load a file into a batch table thru sql*loader..records have been loaded successfully..based on this batch table data i need to insert full data into weekly_content table.In this table there is one extra column that is not be in batch table and file.
we need to populate data logic based on the prodcategory column in batch table
batch table data is like this
id contenttype prodcategory title     default_item item_created_dt_part1 item_created_dt_part2
1 prod beauty     cosmetics cospuf 2007-11-08 10:22:20 013      
2 prod beauty cordless washable 2007-11-08 11:30:15     320
3 prod beauty sonicare replacement 2007-11-08 12:52:52 370
4 prod cooking nesco roaster 2007-11-09 11:15:34 953
5 prod cooking wolfgang pulp 2007-11-09 13:05:46 850
6 prod cooking collection Tim 2007-11-09 15:09:23 134
and so on
based on this data, i have written a cursor to populate the data
declare
cursor c1 is select contenttype,prodcategory,titile,default_item,item_created_dt_part1,item_created_dt_part2,id---system generated seqence
from batch_table order by lower(contenttype),lower(prodcategory),item_created_dt_part1,item_created_dt_part2,id
contentvar batchtable.contenttype%type;
prodvar batchtable.prodcategory%type;
titlevar batchtable.title%type;
defaultvar batchtable.default_time%type;
itemdtpart1 batchtable.item_created_dt_part1%type;
itemdtpart2 batchtable.item_created_dt_part2%type;
idvar batchtable.id%type;
a number(4);
b varchar2(15);
begin
for rec in c1
loop
select lpad(s1.nextval,2,'0') into a from dual;
b:=rec.ename||a;
insert into weekly_content(id,contenttype,prodcategory,prodname,title,default_item,item_created_dt_part1,item_created_dt_part2)values
(rec.id,rec.contenttype,rec.prodcategory,b,rec.titile,rec.default_item,rec.item_created_dt_part1,rec.item_created_dt_part2);
end loop;
end;
I want the output is like this in weekly_content table
id contenttype prodcategory prodname title     default_item      item_created_dt_part1 item_created_dt_part2
1 prod beauty     beauty01     cosmetics cospuf 2007-11-08 10:22:20 013      
2 prod beauty beauty02     cordless washable 2007-11-08 11:30:15     320
3 prod beauty beauty03     sonicare replacement 2007-11-08 12:52:52 370
4 prod cooking cooking01     nesco roaster 2007-11-09 11:15:34 953
5 prod cooking cooking02     wolfgang pulp 2007-11-09 13:05:46 850
6 prod cooking cooking03     collection Tim 2007-11-09 15:09:23 134
and so on
Objective is to create prod category values from 1 to 3 in the order they are created.the priority of assigning 1 thru 3 will be decided by item_created_dt_part1,item_created_dt_part2,id.
and while loading into the weekly_content table append a 2 digit number value to prodcategory from batch_table in the order i insert into the weekly_content table and insert into prodname column.
item_created_dt_part2--nano seconds
Could you please check the logic and recorrect it and send me.can any one please do favour in this regards..
Thanks in advance

Answer 1

What about this requires either a cursor or a loop?
Every tool in the world is not a hammer.
What you have here is:
INSERT INTO ...
SELECT ... FROM ...
Nothing more.