Custom DefaultTreeCellRender not rending node labels correctly.

Question

In our JTree we need to display the state of our custom nodes, the state can be cycled by the user clicking on the node. Our problem is that since upgrading from Java 1.4 if a node is clicked before it is expanded the child nodes will not be rendered correclty, some nodes may not have the label showing, some may not have the label or icon showing.
Under Java 1.4 the following code works correctly.
Under Java 1.5 and 1.6 If you click on a node before expanding it (which changes the node's icon) then expand the node the child nodes are not completely rendered, some may be missing a icon or label or both.
package com.test;
import java.awt.BorderLayout;
import java.awt.Component;
import java.awt.FlowLayout;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import javax.swing.Box;
import javax.swing.Icon;
import javax.swing.JButton;
import javax.swing.JCheckBox;
import javax.swing.JPanel;
import javax.swing.JTree;
import javax.swing.UIManager;
import javax.swing.tree.DefaultMutableTreeNode;
import javax.swing.tree.DefaultTreeCellRenderer;
import javax.swing.tree.DefaultTreeModel;
import javax.swing.tree.TreePath;
* Example to demonstate differences between Java 1.4 and Java 1.5/1.6
* node rendering.
* <p>
* Under Java 1.4 nodes are always rendered correctly.
* <p>
* Under Java 1.5 and 1.6 If you click on a node before expanding it (which
* results in the icon changing) then expand the node not all child nodes
* will be fully rendered.
public class TreeNodeRenderExample extends javax.swing.JFrame {
    private static final long serialVersionUID = 7963956320358601702L;
    private JTree tree1;
     * Entry point.
     * @param args Arguments are ignored.
    public static void main(String[] args) {
        TreeNodeRenderExample inst = new TreeNodeRenderExample();
        inst.setVisible(true);
     * Constructor.
     * <br>
     * Create a instance of TreeNodeRenderExample.
    public TreeNodeRenderExample() {
        super();
        initGUI();
        populateTree();
        postInitGUI();
     * Create the Frame and JTree.
    private void initGUI() {
        try {
                this.setTitle("Checkbox node Render Example");
                tree1 = new JTree();
                getContentPane().add(tree1, BorderLayout.CENTER);
            setSize(400, 300);
        } catch (Exception e) {
            e.printStackTrace();
     * Add the custom cell renderer and a mouse listener.
    private void postInitGUI() {
        tree1.setCellRenderer(new NodeRenderer());
        tree1.addMouseListener(new TreeMouseClickSelectionListener(tree1));
     * Populate the tree.
    private void populateTree() {
        TreeNode root = new TreeNode("Render Example");
        TreeNode colourNode = new TreeNode("Colours");
        TreeNode modelNode = new TreeNode("Models");
        colourNode.add(new TreeNode("Black"));
        colourNode.add(new TreeNode("White"));
        colourNode.add(new TreeNode("Blue"));
        modelNode.add(new TreeNode("Ford"));
        modelNode.add(new TreeNode("Fiat"));
        modelNode.add(new TreeNode("Nissan"));
        root.add(modelNode);
        root.add(colourNode);
        tree1.setModel(new DefaultTreeModel(root));
     * Custom tree node to allow the icon to be changed when the node
     * is clicked.
     * <p>
     * This is a simple example, our custom nodes hold much more state
     * information and get node children on the fly.
    class TreeNode extends DefaultMutableTreeNode {
        private static final long serialVersionUID = 7527381850185157388L;
         * Constructor.
         * <br>
         * Create a instance of TreeNode.
         * @param name Tree node display name.
        public TreeNode(String name) {
            this.name = name;
            this.state = "u";
         * Just cycle through some states so that the icon can
         * can be changed depending on how may 'clicks' on the node.
        public void updateSelectionStatus() {
            if (state.equals("u")) {
                state = "s";
            } else if (state.equals("s")) {
                state = "d";
            } else if (state.equals("d")) {
                state = "u";
         * Get the icon to be used for the check box, shows the current
         * state of a node to the user.
         * @return A icon.
        public Icon getIcon() {
            Icon icon = null;
            if (state.equals("u")) {
                icon = UIManager.getIcon("FileView.directoryIcon");
            } else if (state.equals("s")) {
                icon = UIManager.getIcon("FileView.fileIcon");
            } else if (state.equals("d")) {
                icon = UIManager.getIcon("FileView.computerIcon");
            return icon;
         * String representation of a node.
         * @see javax.swing.tree.DefaultMutableTreeNode#toString()
        public String toString() {
            return name;
        private String name;
        private String state;
     * Custom node render, adds a checkbox in front of the node, could be
     * any object that we can change the icon for, this will show the
     * user the current state of the selected node.
    class NodeRenderer extends DefaultTreeCellRenderer {
        private static final long serialVersionUID = -7358496302112018405L;
        protected JCheckBox checkBox = new JCheckBox();
        //protected JButton checkBox = new JButton();
        private Component strut = Box.createHorizontalStrut(5);
        private JPanel panel = new JPanel(new FlowLayout(FlowLayout.CENTER,0,0));
         * Constructor.
        public NodeRenderer() {
            setOpaque(false);
            this.checkBox.setOpaque(false);
            this.panel.setBackground(UIManager.getColor("Tree.textBackground"));
            this.panel.setOpaque(false);
            this.panel.add(this.checkBox);
            this.panel.add(this.strut);
            this.panel.add(this);
         * Render the label, then change the icon if necessary.
         * @see javax.swing.tree.DefaultTreeCellRenderer#getTreeCellRendererComponent(javax.swing.JTree, java.lang.Object, boolean, boolean, boolean, int, boolean)
        public Component getTreeCellRendererComponent(JTree tree, Object value,
            boolean sel, boolean expanded, boolean leaf, int row, boolean hasFocus)
            super.getTreeCellRendererComponent(tree, value,
                sel, expanded, leaf, row, hasFocus);
            updateDisplayedStatus((TreeNode)value);
            return this.panel;
         * Set the node's icon.
         * @param node Rendered node.
        private void updateDisplayedStatus(TreeNode node) {
            this.checkBox.setIcon(node.getIcon());
     * Listener to allow cycling of node states by clicking on the node.
    class TreeMouseClickSelectionListener extends MouseAdapter {
        private JTree tree;
        private int hotspot = new JCheckBox().getPreferredSize().width;
         * Constructor.
         * <br>
         * Create a instance of TreeMouseClickSelectionListener.
         * @param tree Tree listener is attached to.
        public TreeMouseClickSelectionListener(JTree tree) {
            this.tree = tree;
         * Cycle the state of a clicked node.
         * @see java.awt.event.MouseAdapter#mouseClicked(java.awt.event.MouseEvent)
        public void mouseClicked(MouseEvent me) {
            int x = me.getX();
            int y = me.getY();
            int row = tree.getRowForLocation(x, y);
            TreePath path = tree.getPathForRow(row);
            if (path != null)
                if(x <= tree.getPathBounds(path).x + hotspot)
                    TreeNode node = (TreeNode) path
                        .getLastPathComponent();
                    if (node != null)
                        node.updateSelectionStatus();
                        tree.repaint();
}

Answer 1

I can't recreate your problem. I'm running 1.5.0_09. When I open the program and JUST expand the nodes I see all "file" icons and all the labels work correctly. If i Select a node before expanding it, I get the same result.
What Am I supposed to witness happening?
-Js