DBCP Connections not recycling or closing.

Question

I have implement DBCP using Jakarta-Commons. My connection resource seems to work fine and I am explicitly closing all connections I create. JSTL SQL tags are also using the JNDI resource. However my connection are not being closed or reused. When I allow JSE to crawl the site it quickly taps out the connection pool and Tomcat returns this error:
"javax.servlet.ServletException: Unable to get connection, DataSource invalid: "org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool exhausted, cause: Timeout waiting for idle object"
Oracle 8i and 9i
commons-dbcp-1.1.jar
commons-pool-1.1.jar
Can anyone help with this?
Thanks
JP Steffen

Answer 1

Ok here is what I am doing.....
Server.xml
<Resource name="jdbc/siteoracle" auth="Container" scope="Shareable" type="javax.sql.DataSource"/>
<ResourceParams name="jdbc/siteoracle">
<parameter>
<name>factory</name>
<value>org.apache.commons.dbcp.BasicDataSourceFactory</value>
</parameter>
<parameter>
<name>username</name>
<value>myuser</value>
</parameter>
<parameter>
<name>password</name>
<value>mypword</value>
</parameter>
<parameter>
<name>url</name>
<value>jdbc:oracle:oci:@MYODB</value>
</parameter>
<parameter>
<name>driverClassName</name>
<value>oracle.jdbc.driver.OracleDriver</value>
</parameter>
<parameter>
<name>maxWait</name>
<value>10000</value>
</parameter>
<parameter>
<name>maxActive</name>
<value>100</value>
</parameter>
<parameter>
<name>removeAbandoned</name>
<value>true</value>
</parameter>
<parameter>
<name>maxIdle</name>
<value>20</value>
</parameter>
</ResourceParams>
web.xml
<!-- Reference to JNDI Datasource -->
<resource-ref>
     <description>Oracle Datasource</description>
     <res-ref-name>jdbc/siteoracle</res-ref-name>
     <res-type>javax.sql.DataSource</res-type>
<res-auth>Container</res-auth>
</resource-ref>
<!-- JSTL Datasource -->
<context-param>
     <param-name>javax.servlet.jsp.jstl.sql.dataSource</param-name>
     <param-value>jdbc/siteoracle</param-value>
</context-param>
Example Code:
(JSP Code)
<!--- Get the Main Info Content --->
<sql:query var="MyInfo" sql="SELECT myinfo.title FROM myuser.infolocal WHERE myinfoid = ?" >
     <sql:param value="${DefaultmyinfoID}" />
</sql:query>
(Servlet Code)
package Text;
import java.io.*;
import java.sql.*;
import javax.servlet.*;
import javax.servlet.http.*;
import javax.sql.*;
import javax.naming.Context;
import javax.naming.InitialContext;
import javax.naming.NamingException;
// import Database.*;
public class LineText extends HttpServlet {
Connection conn;
DataSource pool;
public void doGet(
HttpServletRequest request,
HttpServletResponse response)
throws IOException, ServletException {
PrintWriter out = response.getWriter();
Clob linetext = null;
Connection conn=null;
Statement statement = null;
ResultSet rs = null;
String sql =
"select column_data " +
"from myuser.data_table " +
"where dataid = " +
request.getParameter("DataID") +
" and languageid = '" +
request.getParameter("LangID") + "'";
try {
Context env = new InitialContext();
pool = (DataSource)env.lookup("java:comp/env/jdbc/siteoracle");
} catch (NamingException e) {
System.out.println("Error: No InitialContext " + e.getMessage());
try {
// conn=DataBaseConnection.getConnection();
conn = pool.getConnection();
statement = conn.createStatement();
rs = statement.executeQuery(sql);
if (rs.next()) {
linetext = rs.getClob(1);
else {
return;
response.setContentType("text/html");
Reader in = linetext.getCharacterStream();
int length = (int)linetext.length();
char[] buffer = new char[1024];
while ((length = in.read(buffer)) != -1) {
out.write(buffer, 0, length);
in.close();
in = null;
out.flush();
catch (SQLException e) {
System.out.println(
"linetext.doGet() SQLException: " +
e.getMessage() + "executing ");
System.out.println(sql);
finally {
if (rs != null)
try { rs.close(); } catch (SQLException ignore) { }
if (statement != null)
try { statement.close(); } catch (SQLException ignore) { }
if (conn != null)
try { conn.close(); } catch (SQLException ignore) { }