Effective procedure to get data

Question

Hi
In the below procedure
i am using a temporary table for collecting data from 4 tables.
i am using cursor recordset to return results by
group by room_cat,resort_id, VDESC, RATE_CODE, vDAY1, vDAY2, vDAY3, vDAY4,
vDAY5, vDAY6, vDAY7, vWEEKEND1, vWEEKEND2, vWEEKEND3, vWEEKEND4, vWEEKEND5,
vWEEKEND6, vWEEKEND7
i feel this is not correct method and i want to rewrite the procedure in a efficient way.
help please.
create or replace procedure rateq2
ARRDT DATE,
DEPDT DATE,
MY_RATE_CODE IN varchar2,
RESORT_ID IN varchar2,
R_recordset out types.cursor_type
as
ARR_TEMPDT DATE;
DEP_TEMPDT DATE;
ALL_RATECODES varchar2(100);
V_RESORTID varchar2(100);
cursor cur1 is
select RH.resort as RH_RESORT,
RH.rate_code as RH_RATE_CODE,
RD.rate_detail_id as RD_RATE_DETAIL_ID,
RD.rate1 as RD_RATE1,
RD.rate2 as RD_RATE2,
RD.rate3 as RD_RATE3,
RD.rate4 as RD_RATE4,
RD.rate5 as RD_RATE5,
RD.children_charge as RD_CHILD,
RRC.room_category as RM_CAT,
initcap(RRMCAT.long_description) as RM_DESC,
RH.DAY1 as rh_day1,
RH.DAY2 as rh_day2,
RH.DAY3 as rh_day3,
RH.DAY4 as rh_day4,
RH.DAY5 as rh_day5,
RH.DAY6 as rh_day6,
RH.DAY7 as rh_day7,
RH.WEEKEND1 as rh_weekend1,
RH.WEEKEND2 as rh_weekend2,
RH.WEEKEND3 as rh_weekend3,
RH.WEEKEND4 as rh_weekend4,
RH.WEEKEND5 as rh_weekend5,
RH.WEEKEND6 as rh_weekend6,
RH.WEEKEND7 as rh_weekend7
from pms_rate_header RH,
pms_rate_detail RD,
     pms_rate_room_cat RRC,
     resort_room_category RRMCAT,
(select ARR_TEMPDT b_date, DEP_TEMPDT e_date from dual) p
where
RH.inactive_date is NULL
and RH.RESORT=V_RESORTID
and RH.RATE_CODE =ALL_RATECODES
and rh.begin_date <= p.e_date and rh.end_date >= p.b_date
and RD.rate_header_id=RH.rate_header_id
and RD.inactive_date is NULL
and rd.begin_date <= p.e_date and rd.end_date >= p.b_date
and RRC.rate_detail_id=RD.rate_detail_id
and RRC.resort=RH.resort
and RRMCAT.resort=RH.resort
and RRMCAT.room_category=RRC.room_category
and RRC.inactive_date is NULL
and RRMCAT.inactive_date IS NULL
ORDER BY RM_CAT ;
vrec cur1%rowtype;
begin
delete from TEMP_Rate;
ARR_TEMPDT:=ARRDT;
DEP_TEMPDT:=DEPDT;
ALL_RATECODES:=MY_RATE_CODE;
V_RESORTID := RESORT_ID;
open cur1;
loop
fetch cur1 into vrec;
exit when cur1%notfound;
Insert into TEMP_RATE (RESORT_ID, ROOM_CAT, VDESC, AVGRATE1, AVGRATE2, AVGRATE3,
AVGRATE4, AVGRATE5, AVGCHILD, RATEDETID, RATE_CODE, vDAY1, vDAY2, vDAY3, vDAY4,
vDAY5, vDAY6, vDAY7, vWEEKEND1, vWEEKEND2, vWEEKEND3, vWEEKEND4, vWEEKEND5,
vWEEKEND6, vWEEKEND7)
values (vrec.rh_resort, vrec.rm_cat ,vrec.rm_desc, vrec.rd_rate1, vrec.rd_rate2, vrec.rd_rate3,
vrec.rd_rate4, vrec.rd_rate5, vrec.rd_child, vrec.rd_rate_detail_id,vrec.rh_rate_code,vrec.rh_day1,vrec.rh_day2,vrec.rh_day3,vrec.rh_day4,
vrec.rh_day5,vrec.rh_day6,vrec.rh_day7,vrec.rh_weekend1,vrec.rh_weekend2,vrec.rh_weekend3,vrec.rh_weekend4,vrec.rh_weekend5,
vrec.rh_weekend6,vrec.rh_weekend7);
end loop;
OPEN R_recordset FOR
select RESORT_ID, ROOM_CAT, VDESC, AVG(AVGRATE1) , AVG(AVGRATE2), RATE_CODE, vDAY1, vDAY2, vDAY3, vDAY4,
vDAY5, vDAY6, vDAY7, vWEEKEND1, vWEEKEND2, vWEEKEND3, vWEEKEND4, vWEEKEND5,
vWEEKEND6, vWEEKEND7
from temp_rate
group by room_cat,resort_id, VDESC, RATE_CODE, vDAY1, vDAY2, vDAY3, vDAY4,
vDAY5, vDAY6, vDAY7, vWEEKEND1, vWEEKEND2, vWEEKEND3, vWEEKEND4, vWEEKEND5,
vWEEKEND6, vWEEKEND7;
close cur1;
end rateq2;
lee1212

Answer 1

Hi,
No need to use the temp table.
No need for the explicit cursor.
This will be a much faster may to do it:
create or replace procedure rateq2 (
   p_arrdt in date
   , p_depdt in date
   , p_rate_code in varchar2
   , p_resort_id in varchar2
   , p_recordset out types.cursor_type
as
begin
   open p_recordset for
      select rh.resort as rh_resort
      , rrc.room_category as rm_cat
      , initcap(rrmcat.long_description) as rm_desc
      , avg(rd.rate1) as rd_rate1
      , avg(rd.rate2) as rd_rate2
      , rh.rate_code as rh_rate_code
      , rh.day1 as rh_day1
      , rh.day2 as rh_day2
      , rh.day3 as rh_day3
      , rh.day4 as rh_day4
      , rh.day5 as rh_day5
      , rh.day6 as rh_day6
      , rh.day7 as rh_day7
      , rh.weekend1 as rh_weekend1
      , rh.weekend2 as rh_weekend2
      , rh.weekend3 as rh_weekend3
      , rh.weekend4 as rh_weekend4
      , rh.weekend5 as rh_weekend5
      , rh.weekend6 as rh_weekend6
      , rh.weekend7 as rh_weekend7
      from pms_rate_header rh
      , pms_rate_detail rd
      , pms_rate_room_cat rrc
      , resort_room_category rrmcat
      where rd.rate_header_id = rh.rate_header_id
      and rrc.rate_detail_id = rd.rate_detail_id
      and rrc.resort = rh.resort
      and rrmcat.resort = rh.resort
      and rrmcat.room_category = rrc.room_category
      and rh.inactive_date is null
      and rd.inactive_date is null
      and rrc.inactive_date is null
      and rrmcat.inactive_date is null
      and rh.begin_date <= p_depdt
      and rh.end_date >= p_arrdt
      and rd.begin_date <= p_depdt
      and rd.end_date >= p_arrdt
      and rh.resort = p_resort_id
      and rh.rate_code = p_rate_code
      group by rrc.room_category
      , rh.resort
      , initcap(rrmcat.long_description)
      , rh.rate_code
      , rh.day1
      , rh.day2
      , rh.day3
      , rh.day4
      , rh.day5
      , rh.day6
      , rh.day7
      , rh.weekend1
      , rh.weekend2
      , rh.weekend3
      , rh.weekend4
      , rh.weekend5
      , rh.weekend6
      , rh.weekend7
end rateq2;cheers,
Anthony
Message was edited by:
Anthony Wilson
Posted the wrong version...