False static analyzer warning 6335

Question

Hi All,
I have following code...
BOOLEAN MyCreateProcess(...)
PROCESS_INFORMATION ProcessInfo = { 0 };
 auto Cleanup = [&pwszCommandLineLocal, &ProcessInfo]()
  if (NULL != ProcessInfo.hThread)
   CloseHandle(ProcessInfo.hThread);
  if (NULL != ProcessInfo.hProcess)
   CloseHandle(ProcessInfo.hProcess);
  if (NULL != pwszCommandLineLocal)
   free(pwszCommandLineLocal);
 SMART_CLEAN(Cleanup);
 boResult = CreateProcessW(
  pcwszExecutablePath,
  pwszCommandLineLocal,
  NULL,
  NULL,
  FALSE,
  dwCreationFlags,
  NULL,
  NULL,
  &StartupInfo,
  &ProcessInfo
 if (FALSE == boResult)
  return FALSE;
 if (TRUE == bWaitForCompletion)
  WaitForSingleObject(ProcessInfo.hProcess, INFINITE);
  if (NULL != pdwExitCode)
   boResult = GetExitCodeProcess(ProcessInfo.hProcess, pdwExitCode);
   if (FALSE == boResult)
    return FALSE;
 return TRUE;
where SMART_CLEAN(Cleanup) creates a object which calls Cleanup lambda when it goes out of scope. Thus process and thread handle gets closed. But still Static Code Analysis in Visual studio is reporting 6335 only for thread handle.
I think it's false warning. Am I missing something else?
Thanks & Regards,
Amit Kulkarni.

Answer 1

Hi Amit,
>>where SMART_CLEAN(Cleanup) creates a object which calls Cleanup lambda when it goes out of scope. Thus process and thread handle gets closed. But still Static Code Analysis in Visual studio is reporting 6335 only for thread handle.
Which VS version did you use? Please view the detailed code analysis result and know which line code or which method generated this issue.
Best Regards,
Jack
We are trying to better understand customer views on social support experience, so your participation in this interview project would be greatly appreciated if you have time. Thanks for helping make community forums a great place.
Click
HERE to participate the survey.