Hierarchial query returns ex-employees

Question

I have query that was developed from the similar queries I've found on various sites. It display the hierarchy starting from our board of directors in a descending manner. The problem is that the query is pulling our "Ex-employees" which are identified by a person_type_id of 1123. The query is as follows.
SELECT LPAD ('->', 8 * (LEVEL - 1))
|| (SELECT DISTINCT full_name
FROM per_all_people_f
WHERE person_id = paf.person_id
AND PERSON_TYPE_ID <> '1123' -- 1123 = 'Ex-Employee'
AND SYSDATE BETWEEN effective_start_date
AND effective_end_date)
TREE
FROM per_all_assignments_f paf
WHERE SYSDATE BETWEEN paf.effective_start_date
AND paf.effective_end_date
AND paf.primary_flag = 'Y'
AND paf.person_id in (select pf.person_id from per_all_people_f pf where paf.person_id = pf.person_id and pf.PERSON_TYPE_ID <> '1123')
START WITH paf.person_id = (select person_id from per_all_people_f where last_name ='Board of') -- Board of Directors
CONNECT BY PRIOR paf.person_id = paf.supervisor_id
AND paf.primary_flag = 'Y'
AND paf.person_id in (select person_id from per_all_people_f pf where paf.person_id = pf.person_id and pf.PERSON_TYPE_ID <> '1123')
AND SYSDATE BETWEEN paf.effective_start_date
AND paf.effective_end_date
It returns info as follows (partial list). How do I eliminate the Ex-employees (blank lines except for ->?
Board of, Directors
->CEO, Jim
->CFO, Bill
->Doe, Jane
->Smith, Theresa
-> <-- ex-Employee
->Jones, Tammy
->
->
->
->
->
->Frank, Larry
->COO, Berny
->SSO, Jim

Answer 1

I believe you have more than one person_types for ex-employees in the table per_person_types. If that is that case, your query will fetch other ex-employees who have person_type_id different from 1123.
Hence it is always advisable to use person_type_id from the table per_person_type_usages_f and not from the table per_all_people_f.
For your case, I would suggest you try by making a join of per_all_prople_f and per_period_of_service whenever you have to exclude the ex-employees. Do not just believe on the condition 'where per_all_peopl_f.person_type_id != 1123 '
In the join you can use the condition 'where per_periods_of_service.actual_termination_date is null' (along with other conditions in the where clause)
Do let us know how it worked out.
Thanks.