Incorrect Nesting, before the statement ENDFUNCTION

Question

Hello:
I have this simple ABAP program, but I don't seem to make it work:
FUNCTION Z_SAP_GET_CREDIT.
""Interfase local
*"  IMPORTING
*"     VALUE(CLIENT_ID) TYPE  Z_CLIENT_ID OPTIONAL
*"  EXPORTING
*"     VALUE(CREDIT_LIMIT) TYPE  STRING
*"     VALUE(CONDITIONS) TYPE  STRING
*"  EXCEPTIONS
*"      USER_DOES_NOT_EXIST
TYPES: BEGIN OF credit_eq_type,
         WEBTR  TYPE string,
         ZTERM  TYPE int4,
       END OF credit_eq_type .
DATA: credit_eq TYPE credit_eq_type.
SELECT SINGLE *
FROM KNB1
INTO CORRESPONDING FIELDS OF credit_eq
WHERE KUNNR = CLIENT_ID.
*CREDIT_LIMIT = credit_eq-WEBTR.
ENDFUNCTION
I get this error:
Incorrect Nesting, before the statement "ENDFUNCTION", the structure introduced by SELECT must conclude with "END SELECT"
I've done selects before and it wasn't needed.... what is this?
Thanks
Alex

Answer 1

Even though you are specifying SELECT SINGLE * in your code, you are not providing the full key of KNB1 which also includes company code BUKRS. So system expects either a ENDSELECT or your INTO statement to be followed by TABLE itab instead of just INTO strcuture. That is why you got this error. So either do option 1 or 2 as follows.
<u>Option 1</u>
TYPES: BEGIN OF credit_eq_type,
         WEBTR LIKE KNB1-WEBTR,
         ZTERM LIKE KNB1-ZTERM,
       END OF credit_eq_type .
DATA: credit_eq TYPE TABLE OF credit_eq_type with header line.
SELECT SINGLE webtr zterm FROM KNB1
                          INTO TABLE credit_eq
                         WHERE KUNNR = CLIENT_ID.
*CREDIT_LIMIT = credit_eq-WEBTR.
<u>Option 2</u>
TYPES: BEGIN OF credit_eq_type,
         WEBTR LIKE KNB1-WEBTR,
         ZTERM LIKE KNB1-ZTERM,
       END OF credit_eq_type .
DATA: credit_eq TYPE credit_eq_type.
SELECT webtr zterm FROM KNB1 UP TO 1 ROWS
                   INTO credit_eq
                  WHERE KUNNR = CLIENT_ID.
ENDSELECT.
*CREDIT_LIMIT = credit_eq-WEBTR.
<u>Option 3</u>
TYPES: BEGIN OF credit_eq_type,
         WEBTR LIKE KNB1-WEBTR,
         ZTERM LIKE KNB1-ZTERM,
       END OF credit_eq_type .
DATA: credit_eq TYPE credit_eq_type.
SELECT SINGLE webtr zterm FROM KNB1
                          INTO Credit_eq
                         WHERE KUNNR = CLIENT_ID
                           AND BUKRS = <either constant
or another import parameter from the function module>.
*CREDIT_LIMIT = credit_eq-WEBTR.
3rd option is the best one if you have BUKRS. In the case where you don't have BUKRS, use the option 1. Option 2 is least efficient. <b>But in any case, please do not use SELECT * with INTO CORRESPONDING FIELDS when you need only two fields. Instead specify the fields AND yes you cannot use INTO with incompatable fields. They have to be compatible.
Srinivas
Message was edited by: Srinivas Adavi