LDAP not returning correct number of results through Java?

Question

Hello all,
I've written a little testing application for my new shiny LDAP server and have the following method in it, which performs a search based on department number:
public Vector searchLDAP(String depNumber) throws NamingException          
          String uid;
          String mobile;
          String givenName;
          String sn;
          String telephoneNumber;
          String departmentNumber;
          String employeeType;
          String employeeNumber;
          String reportsTo;
          Vector people = new Vector();
          Attributes matchAttributes = new BasicAttributes(false);
          matchAttributes.put(new BasicAttribute("departmentnumber", depNumber));
          NamingEnumeration results = ctx.search(base, matchAttributes);
          SearchResult tempSR;
          Attributes tempAtt;
          LDAPPerson tmp;
          while(results.hasMore())
               uid = "";
               mobile = "";
               givenName = "";
               sn = "";
               telephoneNumber = "";
               departmentNumber = "";
               employeeType = "";
               employeeNumber = "";
               reportsTo = "";
               tempSR = (SearchResult) results.next();
               tempAtt = tempSR.getAttributes();
               if(atts.get("uid")!=null)
                     uid = (String)atts.get("uid").get();
               if(atts.get("mobile")!=null)
                      mobile = (String)atts.get("mobile").get();
               if(atts.get("givenname")!=null)
                      givenName = (String)atts.get("givenname").get();
               if(atts.get("sn")!=null)
                      sn = (String)atts.get("sn").get();
               System.out.println("Working with " + sn);
               if(atts.get("telephonenumber")!=null)
                      telephoneNumber = (String)atts.get("telephonenumber").get();
               if(atts.get("departmentNumber")!=null)
                      departmentNumber = (String)atts.get("departmentNumber").get();
               if(atts.get("employeeType")!=null)
                      employeeType = (String)atts.get("employeeType").get();
               if(atts.get("employeenumber")!=null)
                      employeeNumber = (String)atts.get("employeeNumber").get();
               if(atts.get("reportsTo")!=null)
                      reportsTo = (String)atts.get("reportsTo").get();
               tmp = new LDAPPerson(uid, mobile, givenName, sn, telephoneNumber, departmentNumber, employeeType, employeeNumber, reportsTo);     
               people.add(tmp);
          return people;
     }But for some reason (perhaps too much coding and not enough coffee?) I get the same person's details twice, instead of the two users I'm a) expecting and b) have retrieved using ldapsearch on the command line.
Have I done something really stupid or is there something I'm not aware of?
Thanks!
Gemma

Answer 1

Hello Gemma!
I think you have used a global class attribute atts and not tempAttr. So you get anything else but not what you wish.
So i think you should change the code in the following way,
i thing it should work ...
(Sorry for the bad code formatting ...)
Greetings
public Vector searchLDAP(DirContext ctx, String base, String depNumber) throws NamingException     
String uid;
String mobile;
String givenName;
String sn;
String telephoneNumber;
String departmentNumber;
String employeeType;
String employeeNumber;
String reportsTo;
Vector people = new Vector();
Attributes matchAttributes = new BasicAttributes(false);
matchAttributes.put(new BasicAttribute("departmentnumber", depNumber));
NamingEnumeration results = ctx.search(base, matchAttributes);
while(results.hasMore())
uid = "";
mobile = "";
givenName = "";
sn = "";
telephoneNumber = "";
departmentNumber = "";
employeeType = "";
employeeNumber = "";
reportsTo = "";
SearchResult tempSR = (SearchResult) results.next();
Attributes atts = tempSR.getAttributes();
     if(atts.get("uid")!=null)
     uid = (String)atts.get("uid").get();
     if(atts.get("mobile")!=null)
          mobile = (String)atts.get("mobile").get();
     if(atts.get("givenname")!=null)
givenName = (String)atts.get("givenname").get();
     if(atts.get("sn")!=null)
     sn = (String)atts.get("sn").get();
     System.out.println("Working with " + sn);
     if(atts.get("telephonenumber")!=null)
telephoneNumber = (String)atts.get("telephonenumber").get();
     if(atts.get("departmentNumber")!=null)
departmentNumber = (String)atts.get("departmentNumber").get();
     if(atts.get("employeeType")!=null)
employeeType = (String)atts.get("employeeType").get();
     if(atts.get("employeenumber")!=null)
employeeNumber = (String)atts.get("employeeNumber").get();
     if(atts.get("reportsTo")!=null)
reportsTo = (String)atts.get("reportsTo").get();
LDAPPerson tmp = new LDAPPerson(uid, mobile, givenName, sn, telephoneNumber, departmentNumber, employeeType, employeeNumber, reportsTo);     
     people.add(tmp);
return people;