Modify SQL Query

Question

Hi,
Can the below SQL Query be modified in any simpler way.
IF (V_BillingTypeID = 2) THEN
    select count(*)
      into V_AuthCount
      from payerauthorization pa
     where pa.patientidentificationno = IV_PatientIdentifierno
       and pa.registrationno = IV_UHID;
if (V_AuthCount > 0) then
      select pa.responsetype, pa.payerapprovedamount
        into V_ResponseType, V_ApprovedAmt
        from payerauthorization pa
       where pa.patientidentificationno = IV_PatientIdentifierno
         and pa.registrationno = IV_UHID;
             if V_ResponseType = 3 then
                V_ServiceTariff := V_ServiceTariff -
                           (V_ServiceTariff * (V_ApprovedAmt / 100));
             end if;
       if V_ResponseType = 2 then
          select (pb.totalbillamount + pb.discountamount)
          into V_GrossBillAmt
          from patientbill pb
            where pb.billno = IV_BillNo;
          V_AuthPercentage := ((V_ApprovedAmt / V_GrossBillAmt) * 100);
           V_ServiceTariff  := round(V_ServiceTariff -
                                  (V_AuthPercentage *
                                  (V_ServiceTariff / 100)));
        end if;
              if V_ResponseType = 5 then
                  select (pb.totalbillamount + pb.discountamount)
                  into V_GrossBillAmt
                     from patientbill pb
                       where pb.billno = IV_BillNo;
                        V_AuthPercentage := ((V_ApprovedAmt / V_GrossBillAmt) * 100);
                         V_ServiceTariff  := round(V_ServiceTariff -
                                  (V_AuthPercentage *
                                  (V_ServiceTariff / 100)));
               end if;
  end if;
      select Count(*)
      into V_CRCount
      from creditnote cr
      where cr.billno = iv_Billno;
                      if (V_CRCount > 0) then
                       select cr.creditnoteamount
                         into V_RefundedAmount
                          from creditnote cr
                          where cr.billno = iv_Billno;
                      end if;
    SELECT SUM(GC.REFUNDAMOUNT) INTO V_GCREFUNDAMOUNT FROM GBCREDITNOTE GC;
    V_MAXREFUNDAMOUNT := (V_PatientPaidAmount - (NVL(V_GCREFUNDAMOUNT, 0) +
                         NVL(V_RefundedAmount, 0)));
END IF;Thanks in advance.

Answer 1

Few things i came across are
1. You could remove the query where you do COUNT() just to check if data exist before SELECT..INTO. You can use EXCEPTION handling insted.
2. The condition V_ResponseType = 2 adn V_ResponseType = 5 looks same so you can combine it into a single condition.
I have modified it like this.
if (v_billingtypeid = 2) then
        begin
              select pa.responsetype
                   , pa.payerapprovedamount
                into v_responsetype
                   , v_approvedamt
                from payerauthorization pa
               where pa.patientidentificationno = iv_patientidentifierno
                 and pa.registrationno = iv_uhid;
              if v_responsetype = 3 then
                  v_servicetariff := v_servicetariff - (v_servicetariff * (v_approvedamt / 100));
              end if;
              if v_responsetype in (2, 5) then
                  select (pb.totalbillamount + pb.discountamount)
                    into v_grossbillamt
                    from patientbill pb
                   where pb.billno = iv_billno;
                  v_authpercentage := ((v_approvedamt / v_grossbillamt) * 100);
                  v_servicetariff  := round(v_servicetariff -(v_authpercentage *(v_servicetariff / 100)));
              end if;
        exception
                when no_data_found then
                        null;
        end;
        begin
                select cr.creditnoteamount
                  into v_refundedamount
                  from creditnote cr
                 where cr.billno = iv_billno;
        exception
                when no_data_found then
                        null;
        end;
        select sum(gc.refundamount)
          into v_gcrefundamount
          from gbcreditnote gc;
        v_maxrefundamount := (v_patientpaidamount - (nvl(v_gcrefundamount, 0) + nvl(v_refundedamount, 0)));
end if;Edited by: Karthick_Arp on Feb 21, 2013 3:26 AM
Fixed BEGIN..END mismatch.