My cursor for update doesn't work:(

Question

hi, i have code:
create or replace procedure szkodowosc_STMT_WC is
     date_do    varchar2(8);
     v_data_b1              szkod_wc_blokady_Wc_07.Data_Przetw%TYPE;
     v_data_b2              szkod_wc_blokady_Wc_07.Data_Przetw%TYPE;
     v_data_b3              szkod_wc_blokady_Wc_07.Data_Przetw%TYPE;
     v_brak_blokady         szkod_wc_blokady_Wc_07.Szkodowosc_Procent%TYPE;
     v_blokada_all          szkod_wc_blokady_Wc_07.Szkodowosc_Procent%TYPE;
     v_blokada_za_miesiac   szkod_wc_blokady_Wc_07.Szkodowosc_Procent%TYPE;
     CURSOR cur_szkod_brak_blokady IS
            select data_przetw, szkodowosc_procent
            from szkod_wc_blokady_Wc_07
            where grupa_porownanie = 'brak blokady'
            order by data_przetw;
     CURSOR cur_szkod_blokada_all IS
            select data_przetw, szkodowosc_procent
            from szkod_wc_blokady_Wc_07
            where grupa_porownanie = 'blokada all'  -- blokada od pierwszego stmt
            order by data_przetw;
     CURSOR cur_szkod_blokada_za_miesiac IS
            select data_przetw, szkodowosc_procent
            from szkod_wc_blokady_Wc_07
            where grupa_porownanie = 'blokada za miesiac'    -- blokada od drugiego stmt
            order by data_przetw;
     CURSOR cur_update IS
            select data_przetw, blokada_all
            from SZKOD_WC_BLOKADY_WC_07_results
            for update of blokada_all NOWAIT;    
begin
-- select * from szkod_wc_blokady_Wc_07
delete from SZKOD_WC_BLOKADY_WC_07_results;
commit;
-- przetwarzanie, brak blokady
OPEN cur_szkod_brak_blokady;
   LOOP
      FETCH cur_szkod_brak_blokady INTO v_data_b1, v_brak_blokady;
      EXIT WHEN cur_szkod_brak_blokady%NOTFOUND;
      INSERT INTO SZKOD_WC_BLOKADY_WC_07_results (data_przetw, Brak_Blokady) VALUES (v_data_b1, v_brak_blokady);
   END LOOP;
   COMMIT;
   EXCEPTION
   WHEN OTHERS
   THEN
      DBMS_OUTPUT.PUT_LINE(SQLERRM);             -- dodac wyrzucanie logow do pliku txt
      ROLLBACK;
CLOSE cur_szkod_brak_blokady;
OPEN cur_szkod_blokada_all;
OPEN cur_update;
   LOOP
      FETCH cur_szkod_blokada_all INTO v_data_b2, v_blokada_all;
      EXIT WHEN cur_szkod_blokada_all%NOTFOUND;
      FOR rec IN cur_update
      LOOP
          IF rec.data_przetw = v_data_b2
          THEN
              UPDATE SZKOD_WC_BLOKADY_WC_07_results
              SET blokada_all = v_blokada_all
              WHERE CURRENT OF cur_update;
          END IF;   
      END LOOP;     
      COMMIT;
   END LOOP;
CLOSE cur_update;
CLOSE cur_szkod_blokada_all;
-- select * from SZKOD_WC_BLOKADY_WC_07_results
end;my cur_update should update column blokada_all in SZKOD_WC_BLOKADY_WC_07_results table, but i have still NULLs here, why?
my table after update looks like:
DATA_PRZETW     BRAK_BLOKADY     BLOKADA_ALL     BLOKADA_ZA_MIESIAC
2009-08-14     0,362          
2009-08-21     0,406          
2009-08-28     0,462          
2009-09-04     0,509          
2009-09-11     0,573          
2009-09-18     0,608          
2009-09-25     0,645          
2009-10-02     0,68          
2009-10-09     0,763          
2009-10-16     0,852          
2009-10-23     0,935          
2009-10-30     1,059          
2009-11-06     1,148          
2009-11-13     1,343          
2009-11-20     1,442          
2009-11-27     1,554          
2009-12-04     1,583          
2009-12-11     1,707          
2009-12-18     1,807          
2009-12-25     1,878          
2010-01-01     1,955          
2010-01-08     2,086          
2010-01-15     2,136          
2010-01-22     2,361          
2010-01-29     2,469          
2010-02-05     2,549

Answer 1

looking at your code (it's quite hard to follow with these table name - probably because I don't understand them), your procedure might look like
create or replace procedure szkodowosc_STMT_WC is
begin
   INSERT INTO SZKOD_WC_BLOKADY_WC_07_results
   select data_przetw, szkodowosc_procent
            from szkod_wc_blokady_Wc_07
            where grupa_porownanie = 'brak blokady'
            order by data_przetw;
    UPDATE SZKOD_WC_BLOKADY_WC_07_results r
              SET blokada_all = (select szkodowosc_procent
            from szkod_wc_blokady_Wc_07 b
            where grupa_porownanie = 'blokada all'
            and b.data_przetw = r.data_przetw
end;But it probably can be condensed even further by removing the UPDATE, hope you get the gist. :)