Need to isolate error with output with valid input (code included)

Question

Hey guys, this code will be a bit lengthy as I am posting from two separate Java files: Rectangle.java and RectangleTest.java - Basically I am stumped as to why even valid input keeps resulting in this message: System.out.println("\nThis is a SQUARE, not a Rectangle...Quiting...\n"); . Why am I getting this output? I seriously cant figure this out, and really what I am trying to do is take user input for four sets of coordinates, store them, do some simple math with them to determine if the object they form is a Rectangle and not a square. In the long run I am probably doing the whole thing wrong.
Here is the Rectangle.java code:
public class Rectangle {
     private int x1,x2,x3,x4,y1,y2,y3,y4;
     private int length;
     private int width;
     public Rectangle ()
          this.x1 = 0;
          this.y1 = 0;
          this.x2 = 0;
          this.y2 = 0;
          this.x3 = 0;
          this.y3 = 0;
          this.x4 = 0;
          this.y4 = 0;
     public Rectangle ( int x1, int x2, int x3, int x4, int y1, int y2, int y3, int y4)
          this.setX1(x1);
          this.setX2(x2);
          this.setX3(x3);
          this.setX4(x4);
          this.setY1(y1);
          this.setY2(y2);
          this.setY3(y3);
          this.setY4(y4);
          // First set x1, y1
          if (x1 > 0 && x1 < 20)
               setX1(x1);
          else
               this.x1 = 0;
          if (y1 > 0 && y1 < 20)
               setY1(y1);
          else
               this.y1 = 0;
          // Second set x2,y2
          if (x2 > 0 && x2 < 20)
               setX2(x2);
          else
               this.x2 = 0;
          if (y2 > 0 && y2 < 20)
               setY2(y2);
          else
               this.y2 = 0;
          // Third set x3,y3
          if (x3 > 0 && x3 < 20)
               setX3(x3);
          else
               this.x3 = 0;
          if (y3 > 0 && y3 < 20)
               setY3(y3);
          else
               this.y3 = 0;
          // Last set x4,y4
          if (x4 > 0 && x4 < 20)
               setX4(x4);
          else
               this.x4 = 0;
          if (y4 > 0 && y4 < 20)
               setY4(y4);
          else
               this.y4 = 0;
     }// exit constructor
     // Enter methods
     public int getArea()
          return length * width;
     public int getPerimeter()
          return (2*length) + (2*width);
     public boolean isSquare()
          if (length == width)
                return true;
          else return false;
     public boolean isRectangle()
          if (length != width && length > width)
                return true;
          else return false;
     // Enter Setters and Getters
     public void setLength(){
          this.length = ((x2-x1)^2 + (y2-y1)^2);
     public int getLength(){
          return length;
     public void setWidth(){
          this.width = ((x4-x1)^2 + (y4-y1)^2);
     public int getWidth(){
          return width;
     public void setX1(int x1) {
          this.x1 = x1;
     public int getX1() {
          return x1;
     public void setX2(int x2) {
          this.x2 = x2;
     public int getX2() {
          return x2;
     public void setX3(int x3) {
          this.x3 = x3;
     public int getX3() {
          return x3;
     public void setX4(int x4) {
          this.x4 = x4;
     public int getX4() {
          return x4;
     public void setY1(int y1) {
          this.y1 = y1;
     public int getY1() {
          return y1;
     public void setY2(int y2) {
          this.y2 = y2;
     public int getY2() {
          return y2;
     public void setY3(int y3) {
          this.y3 = y3;
     public int getY3() {
          return y3;
     public void setY4(int y4) {
          this.y4 = y4;
     public int getY4() {
          return y4;
Code for RectangleTest.java:
import java.util.Scanner;
public class RectangleTest {
     public static void main(String[] args)
          int choice;
          int xFirst, xSecond, xThird, xFourth, yFirst, ySecond, yThird, yFourth;
          Scanner input = new Scanner(System.in);  // Scans or reads the inputs from the keyboard of user
          do {
               System.out.print("\nTo START Enter '1'; ");
               System.out.print("\nOr to QUIT Enter '0'; ");
               choice = input.nextInt();
               if (choice == 1)
              // First Set
              System.out.println("\nPlease enter the FIRST set of Coordinates\n");
              System.out.print("Enter X1: ");
              xFirst = input.nextInt();
              System.out.print("Enter Y1: ");
              yFirst = input.nextInt();
              // Second Set
              System.out.println("\nPlease enter the SECOND set of Coordinates\n");
              System.out.print("Enter X2: ");
              xSecond = input.nextInt();
              System.out.print("Enter Y2: ");
              ySecond = input.nextInt();
              // Third Set
              System.out.println("\nPlease enter the THIRD set of Coordinates\n");
              System.out.print("Enter X3: ");
              xThird = input.nextInt();
              System.out.print("Enter Y3: ");
              yThird = input.nextInt();
              // Third Set
              System.out.println("\nPlease enter the FOURTH set of Coordinates\n");
              System.out.print("Enter X4: ");
              xFourth = input.nextInt();
              System.out.print("Enter Y4: ");
              yFourth = input.nextInt();
              // Instantiating the Rectangle class to test it
              Rectangle rectangle1 = new Rectangle(xFirst, xSecond, xThird, xFourth, yFirst, ySecond, yThird, yFourth);
              int lengthRectangle1 = rectangle1.getLength();
              int widthRectangle1 = rectangle1.getWidth();
              int area = rectangle1.getArea();
              int periRect = rectangle1.getPerimeter();
              // Check Shape type
              if (rectangle1.isRectangle())
                   System.out.println("\nThis is a valid Rectangle\n");
              else if (rectangle1.isSquare());
                    System.out.println("\nThis is a SQUARE, not a Rectangle...Quiting...\n");
     }while (choice != 0);
     System.out.println("Bye for now!");
}

Answer 1

NPP83 wrote:
Essentially, I am trying to achieve the following:
1. Store the Cartesian coordinates for the four corners of a Rectangle
2. Verify that the supplied coordinates (by the user) do infact make a Rectangle and not a Square.
Since I don't physically have a Length and Width, but just points, I have to use a little math to create a Length and Width and I came up with ((x2-x1)^2 + (y2-y1)^2) to find the length of one side. I thought I would store this as the way to set the Length/Width (setLength & setWidth), but I havent been able to find a way to bridge the user's input in the main() method of the test program to use the values in this formula. Even then, I am not sure if this simple step would at all help validate the object created by the four sets of points is a Rectangle. I thought that a Rectangle might be created by simply by deductive math where if the Length > Width or Length < Width and Width != Length then I would have a what I was looking for.One side is (X2 - X1) the next side is (Y3 - Y2) the 3rd and 4th sides are: (X4 - X3) and (Y4 - Y1).
Edited by: morgalr on Mar 29, 2010 3:40 PM -- the following comment added:
You should check out getBounds, it may be what you are looking for.