Oracle Procedure- Get aggrigate value based on comparing two columns

Question

Hi All,
I have written a Procedure which accepts one input parameter and returns one refcursor.
The logic used in the procedure is:
The procedure is used to display summary as well as detail report. When the input parameter have more than one comma saperated values then it will act as a summary report and when there will be just one value as the input then it will act as a detail report.
The input parameter is like 'AA12345,BB45434,HJ89736' the first two character is Brand_id and the rest of the 5 character is the propery_id.
The aggrigation aggrigation query is :
Select Month_name,Year,sum(REVPAR),Sum(ADR) from FIS_KPI_TREND where
Brand_id='AA' and SIte_id='12345' group by Month_name,Year;
The above query will worke fine for the Detail report when there will be just one value for the input as 'AA12345'.
The problem is comming for the Summary report when I need to get the aggrigated value for all the brand and site which came in the input parameter.
So i changed the query as:
Select Month_name,Year,sum(REVPAR),Sum(ADR) from FIS_KPI_TREND where
Brand_id||SIte_id in ('AA12345','BB45434','HJ89736')  group by Month_name,Year;
(I'm using parser function to parse comma saperated values.)
By doing this i'm getting the desired result but the performance has decrised as the Index is based on Brand_id and Site_id but i'm Using Brand_ID||Site_id for my search.
Can any one suggest any other way to rewrite this query so that it can take the index as well as give me the sesired output.
Database used : Oracle 10g
Thanks in advance.
Sumit Narayan
Edited by: Sumit Narayan on Apr 11, 2010 10:00 PM

Answer 1

I'd be inclined to do something like this to parse the comma separated list, which would allow you to join without concatenating columns like you're doing now.
ME_XE?select
  substr(column_value, 1, 2)            as brand_id,
  substr(column_value, 3, length(column_value))   as site_id
from table(sys.ODCIVARCHAR2LIST('AA12345','BB45434','HJ89736'));
  2    3    4 
BRAND_ID   SITE_ID
AA         12345
BB         45434
HJ         89736
3 rows selected.
Elapsed: 00:00:00.20
ME_XE?
ME_XE?select * from v$version;
BANNER
Oracle Database 10g Express Edition Release 10.2.0.1.0 - Product
PL/SQL Release 10.2.0.1.0 - Production
CORE  10.2.0.1.0  Production
TNS for Linux: Version 10.2.0.1.0 - Production
NLSRTL Version 10.2.0.1.0 - Production
5 rows selected.
Elapsed: 00:00:00.39
ME_XE?So for your case ...
Select
  f.Month_name,
  f.Year,
  sum(f.REVPAR),
  Sum(f.ADR)
from FIS_KPI_TREND f, table(sys.ODCIVARCHAR2LIST('AA12345','BB45434','HJ89736')) t
where f.Brand_id = t.brand_id
and   f.SIte_id  = t.site_id
group by f.Month_name, f.Year;Edited by: Tubby on Apr 11, 2010 10:12 PM