Override Question

Question

this is my code.
import java.io.*;
import java.security.*;
import javax.crypto.*;
import javax.crypto.spec.*;
public class TextEncryptor implements Encryption, Cloneable, Serializable {
     String encryptedFileName;
     String userText;
     boolean successfulEncryptionPerformed = false;
     KeyGenerator kg;
     SecretKey skey;
     SecretKeyFactory skf;
     DESKeySpec dks;
     Cipher c;
     CipherOutputStream cos;
     PrintWriter pw;
     public TextEncryptor(String encryptedFileName, String userText) {
          this.encryptedFileName = encryptedFileName;
          this.userText = userText;
     public void generateSecretKey() {
        try {
          kg = KeyGenerator.getInstance("DES");
          kg.init(new SecureRandom());
          skey = kg.generateKey();
          skf = SecretKeyFactory.getInstance("DES");
        }catch(Exception e) {
          e.printStackTrace();
     public void initialiseCipher() {
        try {
          Class spec = Class.forName("javax.crypto.spec.DESKeySpec");
          dks = (DESKeySpec)skf.getKeySpec(skey, spec);
          c = Cipher.getInstance("DES/CFB8/NoPadding");
          c.init(Cipher.ENCRYPT_MODE, skey);          
        }catch(Exception e) {
          e.printStackTrace();
     public boolean performEncryption() {
        try {
          cos = new CipherOutputStream(new FileOutputStream(encryptedFileName), c);
          pw = new PrintWriter(new OutputStreamWriter(cos));
          pw.println(userText);
          pw.close();
          successfulEncryptionPerformed = true;
        }catch(Exception e) {
          e.printStackTrace();
          return successfulEncryptionPerformed;
     public DESKeySpec getDESKeySpec() {     
          return dks;     
     public Cipher getIV() {
          return c;
     public boolean equals(Object o) {
          if(o == null) {
               return false;
          TextEncryptor te;
          try {
               te = (TextEncryptor) o;
          }catch(ClassCastException cce) {
               return false;
          return (encryptedFileName.equals(te.encryptedFileName)) && (userText.equals(te.userText));
}My question is since the only two variables that can be set (in th constructor) are encryptedFileName and userText, do i need to override the clone() method, as these two variables are immutable(strings), but what about the other variables, these are always set to the same values in the methods listed above.please help,
thanks

Answer 1

My question is since the only two variables that can be set (in th constructor) are encryptedFileName and
userText, do i need to override the clone() method, as these two variables are immutable(strings), but
what about the other variables, these are always set to the same values in the methods listed above.please
help,
thanksWell, if you implement Cloneable, then you really should implement clone(), otherwise it doesn't make much sense. Even if you do implement it just as
public Object clone() {
    return super.clone();
}