PLSQL update problem, very strange, am i making stupid mistake?

Question

PROCEDURE update_member( membersid in hkmembers.memberid%TYPE,
firstname in hkmembers.firstname%TYPE,)
IS
BEGIN
update hkmembers
set FIRSTNAME = firstname
where MEMBERID = membersid;
DBMS_OUTPUT.put_line(firstname);
END;
i test the procedure, and it returns message telling that the execution is run successfully, but make no effect of the update.....
i try add "commit;" at the end but it doent work either coz the only thing that commit does is stopping you rollback...
Can anyone spot my stupid mistake?
Thank you very much

Answer 1

Problematic line is:
set FIRSTNAME = firstname -- column name = parameter name
Use different names for parameters, for example:
PROCEDURE update_member(
  p_membersid IN hkmembers.memberid%TYPE,
  p_firstname IN hkmembers.firstname%TYPE)
IS
BEGIN
  UPDATE hkmembers
     SET firstname = p_firstname
   WHERE memberid  = p_membersid;
END;
/Regards,
Zlatko
This is an example of optimistic locking :)
Message was edited by:
Zlatko Sirotic