Poor performance of transformation end routine

Question

Hi Folks,
I have written a transformation end routine to update a Cube for WBS Elements reading the Master Data and Hierarchy tables.  The code seems to be working but with a lot of time spent on reading the endroutine.  Could someone take a look and advice the efficient way to write this?
Purpose: 
Read WBS Element master data for the WBS Element delivered in the datapackage (comm. Structure).  Read the WBS Element hierarchy table for the WBS Element to determine what its level is. If the record is found, level is 4 and approval year is not empty, we use that. Otherwise if the record is found but it turns out to be a level 3, use the WBS element as well. If all fails (eg the level is 4 but there is no approval year), determine the parent WBS element, see code after else statement.
Finally, if the WBS element above is the same as the one in the comm. Structure (for which we read already the master data in table t_h_wbs_elemt), fetch approval year from the table t_h_wbs_elemt (this increases performance because there is no need to read the master data for every new record), otherwise read the new WBS element master data in the header of t_h_wbs_elemt.
Edited by: ramesh ramaraju on Jan 7, 2010 4:50 PM

Answer 1

Hi,
Try like this
DATA: lv_nodename type RSSHNODENAME.
DATA: lt_mwbs_elemt type table of /bi0/mwbs_elemt,
lw_mwbs_elemt type /bi0/mwbs_elemt.
DATA: lt_hwbs_elemt type table of /bi0/hwbs_elemt,
      lw_hwbs_elemt type /bi0/hwbs_elemt.
***instead of using select * try to specidfy the fields other wise it will fetch fiull records
***or if you are using select * specking a where condition avodi into corresponding fields instead use the field name
select * from /bi0/mwbs_elemt
into corresponding fields of table lt_mwbs_elemt.
IF SY-SUBRC = 4.
RAISE EXCEPTION TYPE CX_RSROUT_ABORT.
ENDIF.
***instead of using select * try to specidfy the fields other wise it will fetch fiull records
***or if you are using select * specking a where condition avodi into corresponding fields instead use the field name
select * from /bi0/hwbs_elemt
into corresponding fields of table lt_hwbs_elemt.
sort lt_hwbs_elemt by nodename.
sort lt_mwbs_elemt by wbs_elemt.
clear E_S_RESULT.
loop at RESULT_PACKAGE into E_S_RESULT.
clear lw_mwbs_elemt.
loop at lt_mwbs_elemt into lw_mwbs_elemt
where wbs_elemt = e_s_result-wbs_elemt.
endloop.
***instead of looping again use a read statement
read table lt_mwbs_elemt where where wbs_elemt = e_s_result-wbs_elemt binary search.
clear lw_hwbs_elemt.
loop at lt_hwbs_elemt into lw_hwbs_elemt
where nodename = e_s_result-wbs_elemt.
endloop.
***instead of looping again use a read statement
read table lt_hwbs_elemt where where wbs_elemt = e_s_result-wbs_elemt binary search.
clear lv_nodename.
IF sy-subrc EQ 0 AND lw_hwbs_elemt-tlevel EQ 4
and lw_mwbs_elemt-appr_year ne 0.
lv_nodename = e_s_result-wbs_elemt.
ELSEIF sy-subrc EQ 0 AND lw_hwbs_elemt-tlevel EQ 4
and lw_mwbs_elemt-prog_def_s ne ' '.
lv_nodename = e_s_result-wbs_elemt.
ELSEIF sy-subrc EQ 0 AND lw_hwbs_elemt-tlevel EQ 3.
lv_nodename = e_s_result-wbs_elemt.
ENDIF.
IF lw_mwbs_elemt-wbs_elemt ne lv_nodename.
clear lw_mwbs_elemt.
LOOP at lt_mwbs_elemt into lw_mwbs_elemt
where wbs_elemt = lv_nodename.
ENDLOOP.
ENDIF.
IF lw_mwbs_elemt-wbs_elemt EQ lv_nodename.
E_S_RESULT-PROG_DEF_S = lw_mwbs_elemt-prog_def_s.
E_S_RESULT-APPR_YEAR = lw_mwbs_elemt-APPR_YEAR.
ENDIF.
APPEND E_S_RESULT TO E_T_RESULT.
ENDLOOP.
REFRESH RESULT_PACKAGE[].
MOVE E_T_RESULT] TO RESULT_PACKAGE.
Regards,
Ravi