RowFilter.NumberFilter: can't handle "mixed" concrete Number types

Question

cross-post from
http://stackoverflow.com/questions/7993546/rowfilter-numberfilter-cant-handle-mixed-concrete-number-types
Copying here:
Happens at least one of the values (values == value in RowFilter, value in entry) is a decimal. Here's a failing test:
@Test
public void testRowFilterNumberMixCore() {
    TestEntry entry = new TestEntry(1.2f);
    RowFilter filter = RowFilter.numberFilter(ComparisonType.AFTER, 1, 0);
    assertTrue(entry + "must be included " + filter, filter.include(entry));
}the output is:
junit.framework.AssertionFailedError:
[entry: 1.2] must be included [RowFilter: ComparisonType = AFTER, comparableValue: 1, comparableClass: class java.lang.Integer]The reason is that NumberFilter falls back to comparing the numbers by their number.longValue() if they are not the same class (and by that comparable to each other)
Knowing that detail, the test failure is not astonishing (in hind-sight, would have never thought of that being an issue ;-) One level of defense is to make sure - in client code - that the numbers to compare are of the same class. That's not always possible (think f.i.: a tableColumn with columnClass Number) So I'm wondering if/how to improve on the fallback. Something like:
        if (one instanceof Comparable && one.getClass() == other.getClass()) {
            // same class, use comparator
            return ((Comparable) one).compareTo(other);
        if (areIntegers(one, other)) {
            // all integers, use longValue
            return longCompare(one, other);
        if (areDecimals(one, other)) {
            // anything to do here?
        // at last resort convert to BigDecimal and compare those:
        BigDecimal bigOne = new BigDecimal(one.toString());
        BigDecimal bigOther = new BigDecimal(other.toString());
        return bigOne.compareTo(bigOther);Doing so, makes the test pass - I'm a bit weary about hidden (read: unknown to me :) pitfalls. Any warnings/alternatives highly welcome!
Thanks,
Jeanette

Answer 1

FYI: nothing much turned up anywhere, so decided to solve as outlined.
Thanks for your interest :-)
Jeanette