Sp_transaction notification for serial number duplication

Question

Hi All
I need your help with this sp , i found it here on the portal and its not working 100% please check and see if you guys can assisit me.
set ANSI_NULLS ON
set QUOTED_IDENTIFIER ON
go
ALTER proc [dbo].[SBO_SP_TransactionNotification]
@object_type nvarchar(25),                     -- SBO Object Type
@transaction_type nchar(1),               -- [A]dd, <u>pdate, [D]elete, [C]ancel, C[L]ose
@num_of_cols_in_key int,
@list_of_key_cols_tab_del nvarchar(255),
@list_of_cols_val_tab_del nvarchar(255)
AS
begin
-- Return values
declare @error  int                    -- Result (0 for no error)
declare @error_message nvarchar (200)           -- Error string to be displayed
select @error = 0
select @error_message = N'Ok'
declare @val nvarchar (1200)           -- Error string to be displayed
declare @chrin nvarchar(30)
declare @item nvarchar(455)
declare @SysSer nvarchar(455)
declare @qry nvarchar(255)
declare @IntSer nvarchar(32)
declare @whs nvarchar(8)
declare @count int
declare @base nvarchar(6)
set @count = 0
--     ADD     YOUR     CODE     HERE
IF @transaction_type IN ('A','U') AND (@object_type = '94' )
BEGIN
set @item = LEFT( @list_of_cols_val_tab_del, CHARINDEX(CHAR(9),  @list_of_cols_val_tab_del,1) - 1)
set @SysSer = substring(@list_of_cols_val_tab_del, len(@item)+1, 30)
--set @qry = 'select intrserial from osri where itemcode =' + @item + ' and convert(varchar,sysserial) = convert(varchar,' + @SysSer + ')'
select @IntSer = intrserial from osri where itemcode = @item and convert(varchar,sysserial) = convert(varchar,@SysSer)
set @error_message = @IntSer
set @error = 1
select @error, @error_message
END
select @error, @error_message
END
and I have serial number checking on every transactions.
Rgds
Bongani

Answer 1

Here is a working SP
declare @val nvarchar (1200)           -- Error string to be displayed
declare @chrin nvarchar(30)
declare @item nvarchar(455)
declare @SysSer varchar(10)
declare @qry nvarchar(255)
declare @IntSer nvarchar(32)
DECLARE @count int
set @count = 0
--=========================
--S/N Duplication Check
--=========================
IF @transaction_type IN ('A','U') AND (@object_type = '94' )  -- For Goods Recipts
BEGIN
set @item = LEFT( @list_of_cols_val_tab_del, CHARINDEX(CHAR(9),  @list_of_cols_val_tab_del,1) - 1)
set @SysSer = ltrim(rtrim(substring(@list_of_cols_val_tab_del, len(@item)+2, 30)))
select @IntSer = intrserial from osri where itemcode = @item and convert(varchar,sysserial) = @SysSer
SELECT @count = COUNT(*) FROM OSRI WHERE INTRSERIAL = @IntSer
IF @count > 1
BEGIN
set @error = 1
set @error_message = N'Duplicate S/N was found in the system for Item No.' +@item +' S/N : ' + @IntSer
END 
END
Regards
Bongani