The logical problem in turnover in for ?

Question

Welcome
wrote this code, everything is true but there is a logical problem to be solved first idea of this program is a moving train to the contrary, it can stop and operated once again and that can add cars and locomotives and can delete it but there is a problem when adding that the train carriages have remained stable cart after the first turnover Thus ...
THAT shows us the error ..
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class Train extends JFrame implements ActionListener{
    private boolean check = false;
    private boolean stopped = true;
    private boolean add = false;
    private int trainPlace = 0;
    private int INDEX_START = 0;
    public int speed = 300;
    private ImageIcon CurrentImage ;
    private boolean front=true, back=false ;
    private int carrNum = 0 ;
    private JPanel screen, area , controlroom;
    private JButton[][] street;
    public JButton[] keybord;
    private String s[] = {"Start","Back","Fast","Slow","Add Carriage","Delete Carriage","Rest","Check","Desiners"};
    private ImageIcon images[][] ={{
                    new ImageIcon("images/UpRight.jpg"),
                    new ImageIcon("images/RightDown.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    {new ImageIcon("images/Vert.jpg"),
                    new ImageIcon("images/DownRight.jpg"),
                    new ImageIcon("images/Horiz.jpg"),
                    new ImageIcon("images/RightDown.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/Vert.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/Vert.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/Vert.jpg"),
                    new ImageIcon("images/UpRight.jpg"),
                    new ImageIcon("images/Horiz.jpg"),
                    new ImageIcon("images/RightUp.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/DownRight.jpg"),
                    new ImageIcon("images/RightUp.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/NoTrack.jpg"),
                    new ImageIcon("images/NoTrack.jpg")}};
    private ImageIcon frontImagesTrain[]={
                    new ImageIcon("images/TrainDown.jpg"),
                    new ImageIcon("images/TrainDown.jpg"),
                    new ImageIcon("images/TrainLeft.jpg"),
                    new ImageIcon("images/TrainLeft.jpg"),
                    new ImageIcon("images/TrainDown.jpg"),
                    new ImageIcon("images/TrainLeft.jpg"),
                    new ImageIcon("images/TrainUp.jpg"),
                    new ImageIcon("images/TrainUp.jpg"),
                    new ImageIcon("images/TrainUp.jpg"),
                    new ImageIcon("images/TrainUp.jpg"),
                    new ImageIcon("images/TrainRight.jpg"),
                    new ImageIcon("images/TrainDown.jpg"),
                    new ImageIcon("images/TrainRight.jpg"),
                    new ImageIcon("images/TrainDown.jpg")};
        private ImageIcon trackImagesTrain[]={
                new ImageIcon("images/Vert.jpg"),
                new ImageIcon("images/RightUp.jpg"),
                new ImageIcon("images/Horiz.jpg"),
                new ImageIcon("images/UpRight.jpg"),
                new ImageIcon("images/RightUp.jpg"),
                new ImageIcon("images/DownRight.jpg"),
                new ImageIcon("images/Vert.jpg"),
                new ImageIcon("images/Vert.jpg"),
                new ImageIcon("images/Vert.jpg"),
                new ImageIcon("images/UpRight.jpg"),
                new ImageIcon("images/RightDown.jpg"),
                new ImageIcon("images/DownRight.jpg"),
                new ImageIcon("images/Horiz.jpg"),
                new ImageIcon("images/RightDown.jpg")};
          private ImageIcon carrinImagesTrain[]={
                    new ImageIcon("images/Carriage1Down.jpg"),
                    new ImageIcon("images/Carriage1Down.jpg"),
                    new ImageIcon("images/Carriage1Left.jpg"),
                    new ImageIcon("images/Carriage1Left.jpg"),
                    new ImageIcon("images/Carriage1Down.jpg"),
                    new ImageIcon("images/Carriage1Left.jpg"),
                    new ImageIcon("images/Carriage1Up.jpg"),
                    new ImageIcon("images/Carriage1Up.jpg"),
                    new ImageIcon("images/Carriage1Up.jpg"),
                    new ImageIcon("images/Carriage1Up.jpg"),
                    new ImageIcon("images/Carriage1Right.jpg"),
                    new ImageIcon("images/Carriage1Down.jpg"),
                    new ImageIcon("images/Carriage1Right.jpg"),
                    new ImageIcon("images/Carriage1Down.jpg")};
    private int[]frontPath={13, 18,17,16,21,20,15,10,5,0,1,6,7,8};
  private int[]frontPath2={8, 13,18,17,16,21,20,15,10,5,0,1,6,7};  
    private ImageIcon icon;
    private JLabel labelInfo;
    public Train () {  
       screen = new JPanel(new GridLayout(1,1));
       Font f =new Font ("Sanserif",Font.BOLD,18);
       labelInfo = new JLabel("WELCOM" ,JLabel.CENTER);
       labelInfo.setFont(f);
       screen.setBackground(Color.red);
       screen.add(labelInfo);
       getContentPane().add(BorderLayout.NORTH,screen );
        street = new JButton[5][5];
        area = new JPanel (new GridLayout(5,5));
        for(int r=0; r<5; r++) 
            for (int c=0; c<5; c++){
                street[r][c] = new JButton("", images[r][c]);
                area.add(street[r][c]);
        getContentPane().add(BorderLayout.CENTER,area );   
        keybord = new JButton[9];
        controlroom = new JPanel(new GridLayout(5,2));   
//        ActionHandler handler = new ActionHandler();
        for (int i=0; i <9; i++)
            keybord[i] = new JButton(s);
keybord[i].addActionListener(this);
controlroom.add(keybord[i]);
          keybord[i].setEnabled(false);
          keybord[7].setEnabled(true);
getContentPane().add(BorderLayout.SOUTH,controlroom );
public void moveTrainFront(){
int trainPlace1 = trainPlace;
try{
if (trainPlace == frontPath.length-1) trainPlace = 0;
else trainPlace ++;
               if (carrNum == 0 )
     int i = frontPath[trainPlace]/5;
     int j = frontPath[trainPlace] - i * 5;
     int r = frontPath[trainPlace1]/5;
     int c = frontPath[trainPlace1] - r * 5;
     street[i][j].setIcon(frontImagesTrain[trainPlace]);
     street[r][c].setIcon(trackImagesTrain[trainPlace1]);
               else
                    int i1 = frontPath[trainPlace]/5;
                    int j1 = frontPath[trainPlace] - i1 * 5;
                    street[i1][j1].setIcon(frontImagesTrain[trainPlace]);     
                    int trainPlace2 = trainPlace;
                    for (int z = 1; z <= carrNum; z++)
if (trainPlace2 - z < 0) trainPlace2 = 13;
                              int i2 = frontPath[trainPlace2 - z]/5;
                              int j2 = frontPath[trainPlace2 - z] - i2 * 5;
                              street[i2][j2].setIcon(carrinImagesTrain[trainPlace2 - z]);
          int r1 = frontPath[trainPlace1 - carrNum]/5;
                    int c1 = frontPath[trainPlace1 - carrNum] - r1 * 5;
                    street[r1][c1].setIcon(trackImagesTrain[trainPlace1 - carrNum]);
}catch(ArrayIndexOutOfBoundsException aiex){System.out.println("the array out of index");}
// Move train Back
public void moveTrainBack(){
int trainPlace1 = trainPlace;
try{
if (trainPlace == 0) trainPlace = 13;
else trainPlace--;
int i = frontPath[trainPlace]/5;
int j = frontPath[trainPlace] - i * 5;
int r = frontPath[trainPlace1]/5;
int c = frontPath[trainPlace1] - r * 5;
street[i][j].setIcon(frontImagesTrain[trainPlace]);
street[r][c].setIcon(trackImagesTrain[trainPlace1]);
}catch(ArrayIndexOutOfBoundsException aiex){System.out.println("the array out of index");}
public void setRest(){
setStop(true);
          setSpeed(300);
int i = frontPath[trainPlace]/5;
int j = frontPath[trainPlace] - i * 5;
street[i][j].setIcon(trackImagesTrain[trainPlace]);
trainPlace = 0;
i = frontPath[trainPlace]/5;
j = frontPath[trainPlace] - i * 5;
street[i][j].setIcon(frontImagesTrain[0]);
public void setCheck (boolean c)
int i = frontPath[trainPlace]/5;
int j = frontPath[trainPlace] - i * 5;
street[i][j].setIcon(frontImagesTrain[0]);
check = c ;
public boolean getCheck (){ return  check ;}
public void setSpeed (int s){speed = s ;}
public int getSpeed(){return  speed;}
public void setStop(boolean s){stopped = s ;}
public boolean getStop(){return  stopped ;}
public void setBack(boolean s){back = s ;}
public boolean getBack(){return  back;}
     public void setAdd(){carrNum++ ;}
public boolean getAdd(){return  add;}
// Action
     public void actionPerformed(ActionEvent e){
          if(e.getSource()==keybord[0])//Start
          if (stopped)
          keybord[0].setText("Stop");
               setStop(false);
               labelInfo.setText("Running");
else      
               {    setStop(true);
               keybord[0].setText("Start");
                    labelInfo.setText("Stop");
          if(e.getSource()==keybord[1])//Front And Back
          if (!back)
               setBack(true);
          keybord[1].setText("Front");
               labelInfo.setText("Back");
          else      
               setBack(false);
          keybord[1].setText("Back");
               labelInfo.setText("Front");
          }     else if (e.getSource()==keybord[2])//Fast
          if (speed <= 0)
          labelInfo.setText("You've arrived the maximum speed : " + getSpeed());
          else {      setSpeed(speed  - 10);
               labelInfo.setText("The Train speed is slow down to : " + getSpeed());
     else if(e.getSource()==keybord[3])//Slow
          {setSpeed(speed + 10);
                labelInfo.setText("The Train speed is pulled up to : "+getSpeed());
else if(e.getSource()==keybord[4]) //ADD carrin
                    setAdd();
                    labelInfo.setText("Add Carriage");
          //setStop(false);
else if(e.getSource()==keybord[5]) //Delete carrin
               labelInfo.setText("Delete Carrin");
     else if(e.getSource()==keybord[6]) //Rest
               setRest();     
          labelInfo.setText("Rest");
     else if (e.getSource()==keybord[7]) //Check
     setCheck(true);
     keybord[7].setEnabled(false);
     keybord[0].setEnabled(true);
     keybord[1].setEnabled(true);
     keybord[2].setEnabled(true);
     keybord[3].setEnabled(true);
     keybord[4].setEnabled(true);
     keybord[5].setEnabled(true);
     keybord[6].setEnabled(true);
     keybord[8].setEnabled(true);
     labelInfo.setText("The Train is Checked");
else if(e.getSource()==keybord[8]) //desiners
     String x = "";
               labelInfo.setText("Desiners About");
               JOptionPane.showMessageDialog(null,"The Progect is Under The Auspices of:"
               + "\n??" + "\n" + "\n ??" +
               "\n ??" + "\n??" + "\n ??" + "\n" + "\n" + "\n?? " + "\n C 2007");     }     
This main ..
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.lang.Thread;
public class TestTrain{     
    public static void main(String[]args){
        Train train = new Train ();
          MoveTrain mt = new MoveTrain(train);
        train.setTitle("Train");
        train.setSize(421,550);
        train.setVisible(true);
        train.addWindowListener (
        new WindowAdapter (){
             public void windowClosing(WindowEvent e ){
                  System.exit(0);
          mt.start();
}This Threads
import java.lang.Thread;
public class MoveTrain extends Thread {
     Train train ;
    public MoveTrain (Train train){
           this.train= train;
     public void run(){
           while(!train.getCheck());
           while (train.getCheck()){
                try {sleep (train.getSpeed()); }
                catch (InterruptedException e ){System.out.println("unknown error");}
                 if (!train.getStop())
                    if(!train.getBack())
                            {train.moveTrainFront();
                      else  train.moveTrainBack();
}This Link image icon ..
http://www.geocities.com/alhairan_2003/as/777/UpRight.jpg
http://www.geocities.com/alhairan_2003/as/777/Vert.jpg
http://www.geocities.com/alhairan_2003/as/777/TrainUp.jpg
http://www.geocities.com/alhairan_2003/as/777/TrainRight.jpg
http://www.geocities.com/alhairan_2003/as/777/TrainLeft.jpg
http://www.geocities.com/alhairan_2003/as/777/TrainDown.jpg
http://www.geocities.com/alhairan_2003/as/777/Train.jpg
http://www.geocities.com/alhairan_2003/as/777/RightUp.jpg
http://www.geocities.com/alhairan_2003/as/777/RightDown.jpg
http://www.geocities.com/alhairan_2003/as/777/NoTrack.jpg
http://www.geocities.com/alhairan_2003/as/777/Horiz.jpg
http://www.geocities.com/alhairan_2003/as/777/DownRight.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage3Up.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage3Right.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage3Left.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage3Down.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage2Up.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage2Right.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage2Left.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage2Down.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage1Right.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage1Left.jpg
http://www.geocities.com/alhairan_2003/as/777/Carriage1Down.jpg
thanks :)

Answer 1

        String[] car1Names = {
            "Carriage1Down", "Carriage1Left", "Carriage1Down", "Carriage1Right"
        };The first image name should be "Carriage1Up" but it is missing in your directory.
import java.awt.*;
import java.awt.event.*;
import java.awt.image.BufferedImage;
import java.io.*;
import javax.imageio.ImageIO;
import javax.swing.*;
public class MC6 implements Runnable, ActionListener {
    JLabel[] grid;
    BufferedImage[] trackImages;
    BufferedImage[] trainImages;
    BufferedImage[][] carImages;
    int[] imageKeys;
    int[] trackKeys;
    int[] forwardKeys;
    int[] reverseKeys;
    int keyIndex = 0;
    int carCount = 0;           // [0 - 3]
    boolean goingAhead = true;
    boolean changeDirections = false;
    Thread thread = null;
    boolean moving = false;
    final int DELAY = 1000;
    public MC6() {
        loadImages();
    public void actionPerformed(ActionEvent e) {
        String ac = e.getActionCommand();
        if(ac.equals("START"))
            changeDirections = false;
            start();
        if(ac.equals("STOP"))
            stop();
        if(ac.equals("FORWARD") || ac.equals("REVERSE"))
            changeDirections = true;
        if(ac.equals("ADD CARRIAGE"))
            carCount += (carCount+1 <= 3) ? 1 : 0;
        if(ac.equals("REMOVE CARRIAGE")) {
            int carIndex = getCarIndex(carCount);
            int trackIndex = trackKeys[carIndex];
            int imageIndex = imageKeys[carIndex];
            grid[trackIndex].setIcon(new ImageIcon(trackImages[imageIndex]));           
            carCount -= (carCount-1 >=0 ) ? 1 : 0;
    public void run() {
        while(moving) {
            // Clear track in preparation for next advance.
            if(changeDirections) {
                clearTrack();
                // Adjust keyIndex by one increment in the direction of travel
                // to allow it to return it to its current position after the
                // next advance in position (further below).
                advance();
                goingAhead = !goingAhead;
                changeDirections = false;
            } else {
                // Replace last car with track image before train advances.
                int carIndex = getCarIndex(carCount);
                int trackIndex = trackKeys[carIndex];
                int imageIndex = imageKeys[carIndex];
                grid[trackIndex].setIcon(new ImageIcon(trackImages[imageIndex]));
            // Move to next position on the track.
            advance();
            // Set locomotive.
            setLocomotive();
            // Set the cars following the locomotive.
            setCars();
            try {
                Thread.sleep(DELAY);
            } catch(InterruptedException e) {
                System.out.println("interrupted");
                stop();
    private int getCarIndex(int carNumber) {
        int n = carNumber;
        int index;
        if(goingAhead) {
            index = keyIndex-n;
            if(index < 0)
                index += trackKeys.length;
        } else {
            index = (keyIndex+n) % trackKeys.length;
        return index;
    private void advance() {
        keyIndex = goingAhead ?
                       (keyIndex+1 > trackKeys.length-1) ? 0 : keyIndex+1
                       (keyIndex-1 < 0) ? trackKeys.length-1 : keyIndex-1;
    private void clearTrack() {
        // Remove all cars from track before direction change.
        for(int j = 0; j < carCount; j++) {
            int carIndex = getCarIndex(j+1);
            int trackIndex = trackKeys[carIndex];
            int imageIndex = imageKeys[carIndex];
            grid[trackIndex].setIcon(new ImageIcon(trackImages[imageIndex]));
    private void setLocomotive() {
        int trackIndex = trackKeys[keyIndex];
        int imageIndex = goingAhead ? forwardKeys[keyIndex]
                                    : reverseKeys[keyIndex];
        grid[trackIndex].setIcon(new ImageIcon(trainImages[imageIndex]));
    private void setCars() {
        for(int j = 0; j < carCount; j++) {
            int carIndex = getCarIndex(j+1);
            int trackIndex = trackKeys[carIndex];
            int imageIndex = goingAhead ? forwardKeys[carIndex]
                                        : reverseKeys[carIndex];
            grid[trackIndex].setIcon(new ImageIcon(carImages[j][imageIndex]));
    private void start() {
        if(!moving) {
            moving = true;
            thread = new Thread(this);
            thread.setPriority(Thread.NORM_PRIORITY);
            thread.start();
    public void stop() {
        moving = false;
        if(thread != null)
            thread.interrupt();
        thread = null;
    private void loadImages() {
        String[] trackNames = {
            "UpRight", "RightDown", "Vert", "DownRight", "Horiz", "RightUp", "NoTrack"
        String[] trainNames = { "TrainUp", "TrainLeft", "TrainDown", "TrainRight" };
        String[] car1Names = {
            "Carriage1Down", "Carriage1Left", "Carriage1Down", "Carriage1Right"
        String[] car2Names = {
            "Carriage2Up", "Carriage2Left", "Carriage2Down", "Carriage2Right"
        String[] car3Names = {
            "Carriage3Up", "Carriage3Left", "Carriage3Down", "Carriage3Right"
        trackImages = getImages(trackNames);
        trainImages = getImages(trainNames);
        BufferedImage[] car1Images = getImages(car1Names);
        BufferedImage[] car2Images = getImages(car2Names);
        BufferedImage[] car3Images = getImages(car3Names);
        carImages = new BufferedImage[][]{ car1Images, car2Images, car3Images };
    private BufferedImage[] getImages(String[] ids) {
        BufferedImage[] images = new BufferedImage[ids.length];
        for(int j = 0; j < ids.length; j++) {
            String path = "images/" + ids[j] + ".jpg";
            try {
                images[j] = ImageIO.read(new File(path));
            } catch(IOException e) {
                System.out.println("Read error for " + path +
                                   ": " + e.getMessage());
                images[j] = null;
        return images;
    private JPanel getCenterComponent() {
        imageKeys = new int[] {
            0, 1, 3, 4, 1,  2,  5,  4,  0,  5,  3,  2,  2, 2
        trackKeys = new int[] {
            0, 1, 6, 7, 8, 13, 18, 17, 16, 21, 20, 15, 10, 5
        forwardKeys = new int[] {
            0, 3, 2, 3, 3,  2,  2,  1,  1,  2,  1,  0,  0, 0
        reverseKeys = new int[] {
            1, 0, 1, 1, 0,  0,  3,  3,  0,  3,  2,  2,  2, 2
        grid = new JLabel[25];
        JPanel panel = new JPanel(new GridLayout(5,0));
        for(int j = 0; j < grid.length; j++) {
            ImageIcon icon;
            int index = getIndexForValue(j);
            if(index != -1) {
                icon = new ImageIcon(trackImages[imageKeys[index]]);
            } else {
                icon = new ImageIcon(trackImages[6]);
            grid[j] = new JLabel(icon);
            panel.add(grid[j]);
        return panel;
    private int getIndexForValue(int value) {
        for(int j = 0; j < trackKeys.length; j++) {
            if(value == trackKeys[j])
                return j;
        return -1;
    private JPanel getControls() {
        String[] ids = {
            "Start", "Stop", "Forward", "Reverse", "Add Carriage", "Remove Carriage"
        JPanel panel = new JPanel(new GridLayout(0,2));
         for(int j = 0; j < ids.length; j++) {
            JButton button = new JButton(ids[j]);
            button.setActionCommand(ids[j].toUpperCase());
            button.addActionListener(this);
            panel.add(button);
        return panel;
    public static void main(String[] args) {
        MC6 test = new MC6();
        JFrame f = new JFrame();
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.getContentPane().add(test.getCenterComponent());
        f.getContentPane().add(test.getControls(), "Last");
        f.pack();
        f.setLocation(200,100);
        f.setVisible(true);
}