Trigger - Identifying Modified Columns

Question

Hi All,
I have created AFTER INSERT OR DELETE OR UPDATE FOR EACH ROW trigger. To audit the changes, if update or delete performed old values will get insert into PRM_CURFILEDATE_AUDIT and if insert happen new values will get insert.
In PRM_CURFILEDATE_AUDIT table there is column called COMMENTS. If value for particular column gets updated I want to add that column name along with new value.
Trigger:-
CREATE OR REPLACE TRIGGER CRUFILEDATE_AUDIT_TRG
AFTER INSERT OR DELETE OR UPDATE ON CURFILEDATE_TEST
FOR EACH ROW
BEGIN
DECLARE
lv_Updtype CHAR(10);
lv_Sid VARCHAR2 (30);
lv_Machine VARCHAR2 (64);
lv_Osuser VARCHAR2 (30);
lv_Program VARCHAR2 (48);
BEGIN
Select sid
Into lv_Sid
From v$session
where Audsid = (Select Sys_context('Userenv','SessionID') From Dual);
Select Machine,Program,Osuser
Into lv_Machine,lv_Program,lv_Osuser
From V$session
Where Sid = lv_Sid ;
IF Inserting
Then lv_Updtype := 'INSERT';
Elsif Deleting
Then lv_Updtype := 'DELETE';
Elsif Updating
Then lv_Updtype := 'UPDATE';
End If;
-- Insert record into PRM_CURFILEDATE_AUDIT table
IF Inserting THEN
Insert into PRM_CURFILEDATE_AUDIT ( FILETYPE,CHNGDATE,FILEDATE,RECDESC,APPL,UPDTYPE,OSUSER,MACHINE,PROGRAM,RUN_DATE)
Values
(:new.FILETYPE ,:new.CHNGDATE,:new.FILEDATE ,:new.RECDESC,:new.APPL,lv_UPDTYPE,lv_OSUSER ,lv_MACHINE,lv_PROGRAM ,to_char(SYSDATE,'YYYYMMDD - hh24:mi:ss'));
END IF;
IF Updating OR Deleting Then
Insert into PRM_CURFILEDATE_AUDIT ( FILETYPE,CHNGDATE,FILEDATE,RECDESC,APPL,UPDTYPE,OSUSER,MACHINE,PROGRAM,RUN_DATE)
Values
(:old.FILETYPE ,:old.CHNGDATE,:old.FILEDATE ,:old.RECDESC,:old.APPL,lv_UPDTYPE,lv_OSUSER ,lv_MACHINE,lv_PROGRAM ,to_char(SYSDATE,'YYYYMMDD - hh24:mi:ss'));
End if;
END;
END;
Thankx in advance.

Answer 1

so.. what is your question?
you could change this
Select sid
Into lv_Sid
From v$session
where Audsid = (Select Sys_context('Userenv','SessionID') From Dual);
Select Machine,Program,Osuser
Into lv_Machine,lv_Program,lv_Osuser
From V$session
Where Sid = lv_Sid ;to this
Select sid , Machine,Program,Osuser
Into lv_Sid , lv_Machine,lv_Program,lv_Osuser
From v$session
where Audsid = Sys_context('Userenv','SessionID');no need for two different queries...
or maybe, only use the SYS_CONTEXT:
lv_Sid := sys_context ('userenv', 'sessionid');
lv_Machine := sys_context ('userenv', ''); --<--- look up yourself
lv_Program  := sys_context ('userenv', '') --<--- look up yourself;
lv_Osuser  := sys_context ('userenv', 'os_user');http://download.oracle.com/docs/cd/B19306_01/server.102/b14200/functions165.htm#SQLRF06117
and why do you change the DATE to a CHAR when you insert your record?
any reason why you would use CHAR instead of VARCHAR2? ( CHAR(10) for this lv_Updtype )