Tuning of procedure having cursor

Question

I have following procedure which has to be tuned. I was thinking of using Bulk collect, but I believe I cannot use because I am having one select statement before update. art_neg_item_level table has got 40000000 records and art_prod_series has got 7000000 records. The procedure is not getting executed at all (even in one full day). Please suggest some alternative solution
CREATE OR REPLACE PROCEDURE Art_Neg_Item_Cost_Update IS
v_prod_id                    art_neg_item_level.prod_id%TYPE;
v_busi_dte                    art_neg_item_level.busi_dte%TYPE;
v_ser_ltr                    art_neg_item_level.ser_ltr%TYPE;
v_itm_qty                    art_neg_item_level.itm_qty%TYPE;
v_curr_cost                    art_prod_series.curr_cost%TYPE;
v_ord_no                    art_neg_item_level.ord_no%TYPE;
CURSOR get_transaction_data IS
     SELECT prod_id, ser_ltr, busi_dte, itm_qty, ord_no
          FROM art_neg_item_level
          WHERE extd_cost=0;
BEGIN
-- Loop through the import data, parse out the string to variables
OPEN get_transaction_data;
LOOP
FETCH get_transaction_data INTO v_prod_id, v_ser_ltr, v_busi_dte, v_itm_qty, v_ord_no;
EXIT WHEN get_transaction_data%NOTFOUND;
BEGIN
     SELECT a.curr_cost
     INTO v_curr_cost
     FROM art_prod_series a
     WHERE a.eff_dte = (SELECT MAX(c.eff_dte)
                         FROM art_prod_series c
                         WHERE a.prod_id = c.prod_id
                         AND a.ser_ltr = c.ser_ltr
                              AND c.eff_dte <= v_busi_dte
     AND a.curr_cost <> 0
     AND v_prod_id = a.prod_id
     AND v_ser_ltr = a.ser_ltr;
     IF SQL%ROWCOUNT <> 0 THEN
          UPDATE art_neg_item_level
          SET cost = v_curr_cost,
               extd_cost = v_curr_cost*v_itm_qty
          WHERE prod_id = v_prod_id
          AND     ser_ltr = v_ser_ltr
          AND     busi_dte = v_busi_dte
          AND     itm_qty = v_itm_qty
          AND     ord_no = v_ord_no
          AND extd_cost = 0;
          COMMIT;
     END IF;
EXCEPTION
     WHEN NO_DATA_FOUND THEN
          NULL;
END;
END LOOP;
CLOSE get_transaction_data;
COMMIT;
END Art_Neg_Item_Cost_Update;

Answer 1

Hi
Please go for using collection instead of cursors.. Please try this
CREATE OR REPLACE PROCEDURE Art_Neg_Item_Cost_Update IS
v_prod_id art_neg_item_level.prod_id%TYPE;
v_busi_dte art_neg_item_level.busi_dte%TYPE;
v_ser_ltr art_neg_item_level.ser_ltr%TYPE;
v_itm_qty art_neg_item_level.itm_qty%TYPE;
v_curr_cost art_prod_series.curr_cost%TYPE;
v_ord_no art_neg_item_level.ord_no%TYPE;
BEGIN
-- Loop through the import data, parse out the string to variables
--OPEN get_transaction_data;
--LOOP
--FETCH get_transaction_data INTO v_prod_id, v_ser_ltr, v_busi_dte, v_itm_qty, v_ord_no;
--EXIT WHEN get_transaction_data%NOTFOUND;
for i in(SELECT prod_id, ser_ltr, busi_dte, itm_qty, ord_no
FROM art_neg_item_level
WHERE extd_cost=0)
loop
BEGIN
SELECT a.curr_cost
INTO v_curr_cost
FROM art_prod_series a
WHERE a.eff_dte = (SELECT MAX(c.eff_dte)
FROM art_prod_series c
WHERE a.prod_id = c.prod_id
AND a.ser_ltr = c.ser_ltr
AND c.eff_dte <= i.busi_dte
AND a.curr_cost <> 0
AND i.prod_id = a.prod_id
AND i.ser_ltr = a.ser_ltr;
IF SQL%ROWCOUNT 0 THEN
UPDATE art_neg_item_level
SET cost = v_curr_cost,
extd_cost = v_curr_cost*i.itm_qty
WHERE prod_id =i.prod_id
AND ser_ltr =i.ser_ltr
AND busi_dte = i.busi_dte
AND itm_qty = i.itm_qty
AND ord_no = i.ord_no
AND extd_cost = 0;
COMMIT;
END IF;
EXCEPTION
WHEN NO_DATA_FOUND THEN
NULL;
END;
END LOOP;
CLOSE get_transaction_data;
COMMIT;
END Art_Neg_Item_Cost_Update;