Update code not working

Question

ok.. i have a vacancies page, each vacancy has a link next to
it called "edit" when you click on the link it does this:
<a href="vacancyedit.cfm?ID=#ID#">
on vacancyedit.cfm there is a form. the fields on the form
are populated with this query:
<cfquery name="edit_vacancy"
datasource="allieddatabase">
SELECT *
FROM new_vacancy_table1
WHERE ID = #ID#
ORDER BY ID DESC
</cfquery>
the form looks like this:
<form
action="<cfoutput>#CurrentPage#</cfoutput>"
method="POST" name="edit_vacancy_form">
<label for="textfield">Auto ID</label>
<input
value="<cfoutput>#edit_vacancy.ID#</cfoutput>"
type="text" name="id" id="id">
<label for="label">Area</label>
<input
value="<cfoutput>#edit_vacancy.area#</cfoutput>"
type="text" name="textfield2" id="label">
<label for="label2">Pattern</label>
<input
value="<cfoutput>#edit_vacancy.pattern#</cfoutput>"
type="text" name="textfield3" id="label2">
<label for="label3">Hours</label>
<input
value="<cfoutput>#edit_vacancy.hrs#</cfoutput>"
type="text" name="textfield4" id="label3">
<label for="label4">Rate</label>
<input
value="<cfoutput>#edit_vacancy.rate#</cfoutput>"
type="text" name="textfield5" id="label4">
<label for="textarea">Description</label>
<textarea name="textarea"
class="text_entry"><cfoutput>#edit_vacancy.description#</cfoutput></textarea>
<br>
<input type="submit" name="Submit" value="Submit"
id="submit_button">
<input type="hidden" name="MM_UpdateRecord"
value="edit_vacancy_form">
</form>
so i make the alterations to the queried data as required
then click submit. this is the update code:
<cfset CurrentPage=GetFileFromPath(GetTemplatePath())>
<cfif IsDefined("FORM.MM_UpdateRecord") AND
FORM.MM_UpdateRecord EQ "edit_vacancy_form">
<cfquery datasource="allieddatabase">
UPDATE new_vacancy_table1
SET area=
<cfif IsDefined("FORM.textfield2") AND #FORM.textfield2#
NEQ "">
<cfqueryparam value="#FORM.textfield2#"
cfsqltype="cf_sql_clob" maxlength="50">
<cfelse>
</cfif>
, pattern=
<cfif IsDefined("FORM.textfield3") AND #FORM.textfield3#
NEQ "">
<cfqueryparam value="#FORM.textfield3#"
cfsqltype="cf_sql_clob" maxlength="50">
<cfelse>
</cfif>
, hrs=
<cfif IsDefined("FORM.textfield4") AND #FORM.textfield4#
NEQ "">
<cfqueryparam value="#FORM.textfield4#"
cfsqltype="cf_sql_clob" maxlength="50">
<cfelse>
</cfif>
, rate=
<cfif IsDefined("FORM.textfield5") AND #FORM.textfield5#
NEQ "">
<cfqueryparam value="#FORM.textfield5#"
cfsqltype="cf_sql_clob" maxlength="50">
<cfelse>
</cfif>
, "description"=
<cfif IsDefined("FORM.textarea") AND #FORM.textarea# NEQ
"">
<cfqueryparam value="#FORM.textarea#"
cfsqltype="cf_sql_clob">
<cfelse>
</cfif>
WHERE ID=<cfqueryparam value="#FORM.id#"
cfsqltype="cf_sql_numeric">
</cfquery>
<cflocation url="vacancyadmin.cfm">
</cfif>
this should then update my changes and take me back to
vacancyadmin.cfm. however all i get is the following error message:
Error Executing Database Query.
Parameter ?_5 has no default value.
The error occurred in
F:\data\webdesigns\wwwroot\CFIDE\Allied\vacancyedit.cfm: line 35
33 : ''
34 : </cfif>
35 : WHERE ID=<cfqueryparam value="#FORM.id#"
cfsqltype="cf_sql_clob" maxlength="10">
36 : </cfquery>
37 : <cflocation url="vacancyadmin.cfm">
SQL UPDATE new_vacancy_table1 SET area= (param 1) , pattern=
(param 2) , hrs= (param 3) , rate= '' , "description"= (param 4)
WHERE ID= (param 5)
DATASOURCE allieddatabase
VENDORERRORCODE 3088
SQLSTATE  
Resources:
* Check the ColdFusion documentation to verify that you are
using the correct syntax.
* Search the Knowledge Base to find a solution to your
problem.
Browser Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Remote Address 10.0.0.201
Referrer
http://allied-srv-03/CFS/vacancyedit.cfm?ID=14
Date/Time 07-Apr-07 12:56 PM
Stack Trace
at
cfvacancyedit2ecfm242791332.runPage(F:\data\webdesigns\wwwroot\CFIDE\Allied\vacancyedit.c fm:35)
at
cfvacancyedit2ecfm242791332.runPage(F:\data\webdesigns\wwwroot\CFIDE\Allied\vacancyedit.c fm:35)
com.inzoom.adojni.ComException: Parameter ?_5 has no default
value. in Microsoft JET Database Engine code=3088 Type=1
at com.inzoom.ado.Command.jniExecute(Native Method)
at com.inzoom.ado.Command.execute(Command.java:40)
at com.inzoom.jdbcado.Statement.exec(Statement.java:34)
at
com.inzoom.jdbcado.PreparedStatement.execute(PreparedStatement.java:201)
at
coldfusion.server.j2ee.sql.JRunPreparedStatement.execute(JRunPreparedStatement.java:87)
at coldfusion.sql.Executive.executeQuery(Executive.java:756)
at coldfusion.sql.Executive.executeQuery(Executive.java:675)
at coldfusion.sql.Executive.executeQuery(Executive.java:636)
at coldfusion.sql.SqlImpl.execute(SqlImpl.java:236)
at
coldfusion.tagext.sql.QueryTag.doEndTag(QueryTag.java:500)
at
cfvacancyedit2ecfm242791332.runPage(F:\data\webdesigns\wwwroot\CFIDE\Allied\vacancyedit.c fm:35)
at coldfusion.runtime.CfJspPage.invoke(CfJspPage.java:152)
at
coldfusion.tagext.lang.IncludeTag.doStartTag(IncludeTag.java:349)
at
coldfusion.filter.CfincludeFilter.invoke(CfincludeFilter.java:65)
at
coldfusion.filter.ApplicationFilter.invoke(ApplicationFilter.java:225)
at
coldfusion.filter.RequestMonitorFilter.invoke(RequestMonitorFilter.java:51)
at coldfusion.filter.PathFilter.invoke(PathFilter.java:86)
at
coldfusion.filter.LicenseFilter.invoke(LicenseFilter.java:27)
at
coldfusion.filter.ExceptionFilter.invoke(ExceptionFilter.java:69)
at
coldfusion.filter.BrowserDebugFilter.invoke(BrowserDebugFilter.java:52)
at
coldfusion.filter.ClientScopePersistenceFilter.invoke(ClientScopePersistenceFilter.java:2 8)
at
coldfusion.filter.BrowserFilter.invoke(BrowserFilter.java:38)
at
coldfusion.filter.GlobalsFilter.invoke(GlobalsFilter.java:38)
at
coldfusion.filter.DatasourceFilter.invoke(DatasourceFilter.java:22)
at
coldfusion.filter.RequestThrottleFilter.invoke(RequestThrottleFilter.java:115)
at coldfusion.CfmServlet.service(CfmServlet.java:107)
at
coldfusion.bootstrap.BootstrapServlet.service(BootstrapServlet.java:78)
at
jrun.servlet.ServletInvoker.invoke(ServletInvoker.java:91)
at
jrun.servlet.JRunInvokerChain.invokeNext(JRunInvokerChain.java:42)
at
jrun.servlet.JRunRequestDispatcher.invoke(JRunRequestDispatcher.java:257)
at
jrun.servlet.ServletEngineService.dispatch(ServletEngineService.java:541)
at
jrun.servlet.jrpp.JRunProxyService.invokeRunnable(JRunProxyService.java:204)
at
jrunx.scheduler.ThreadPool$DownstreamMetrics.invokeRunnable(ThreadPool.java:318)
at
jrunx.scheduler.ThreadPool$ThreadThrottle.invokeRunnable(ThreadPool.java:426)
at
jrunx.scheduler.ThreadPool$UpstreamMetrics.invokeRunnable(ThreadPool.java:264)
at jrunx.scheduler.WorkerThread.run(WorkerThread.java:66)
sorry its such a long post but i thought it best to post all
the info. can anyone see what the problem is with my code?
thanks in advance
zac

Answer 1

Zac,
You really shouldn't make the Primary Key for the table
editable.
Try removing this from the form:
<label for="textfield">Auto ID</label>
<input
value="<cfoutput>#edit_vacancy.ID#</cfoutput>"
type="text" name="id" id="id">
And make it a hidden input like this:
<input
value="<cfoutput>#edit_vacancy.ID#</cfoutput>"
type="hidden" name="id" id="id">
Ken Ford
Adobe Community Expert
Fordwebs, LLC
http://www.fordwebs.com
"zac1234" <[email protected]> wrote in
message news:[email protected]...
> ok.. i have a vacancies page, each vacancy has a link
next to it called "edit"
> when you click on the link it does this:
>
> <a href="vacancyedit.cfm?ID=#ID#">
>
> on vacancyedit.cfm there is a form. the fields on the
form are populated with
> this query:
>
> <cfquery name="edit_vacancy"
datasource="allieddatabase">
> SELECT *
> FROM new_vacancy_table1
> WHERE ID = #ID#
> ORDER BY ID DESC
> </cfquery>
>
> the form looks like this:
>
> <form
action="<cfoutput>#CurrentPage#</cfoutput>"
method="POST"
> name="edit_vacancy_form">
>
> <label for="textfield">Auto ID</label>
> <input
value="<cfoutput>#edit_vacancy.ID#</cfoutput>"
type="text" name="id"
> id="id">
>
> <label for="label">Area</label>
> <input
value="<cfoutput>#edit_vacancy.area#</cfoutput>"
type="text"
> name="textfield2" id="label">
> <label for="label2">Pattern</label>
> <input
value="<cfoutput>#edit_vacancy.pattern#</cfoutput>"
type="text"
> name="textfield3" id="label2">
> <label for="label3">Hours</label>
> <input
value="<cfoutput>#edit_vacancy.hrs#</cfoutput>"
type="text"
> name="textfield4" id="label3">
> <label for="label4">Rate</label>
> <input
value="<cfoutput>#edit_vacancy.rate#</cfoutput>"
type="text"
> name="textfield5" id="label4">
> <label for="textarea">Description</label>
> <textarea name="textarea"
>
class="text_entry"><cfoutput>#edit_vacancy.description#</cfoutput></textarea>
> <br>
> <input type="submit" name="Submit" value="Submit"
id="submit_button">
> <input type="hidden" name="MM_UpdateRecord"
value="edit_vacancy_form">
> </form>
>
> so i make the alterations to the queried data as
required then click submit.
> this is the update code:
>
> <cfset
CurrentPage=GetFileFromPath(GetTemplatePath())>
> <cfif IsDefined("FORM.MM_UpdateRecord") AND
FORM.MM_UpdateRecord EQ
> "edit_vacancy_form">
> <cfquery datasource="allieddatabase">
> UPDATE new_vacancy_table1
> SET area=
> <cfif IsDefined("FORM.textfield2") AND
#FORM.textfield2# NEQ "">
> <cfqueryparam value="#FORM.textfield2#"
cfsqltype="cf_sql_clob"
> maxlength="50">
> <cfelse>
> ''
> </cfif>
> , pattern=
> <cfif IsDefined("FORM.textfield3") AND
#FORM.textfield3# NEQ "">
> <cfqueryparam value="#FORM.textfield3#"
cfsqltype="cf_sql_clob"
> maxlength="50">
> <cfelse>
> ''
> </cfif>
> , hrs=
> <cfif IsDefined("FORM.textfield4") AND
#FORM.textfield4# NEQ "">
> <cfqueryparam value="#FORM.textfield4#"
cfsqltype="cf_sql_clob"
> maxlength="50">
> <cfelse>
> ''
> </cfif>
> , rate=
> <cfif IsDefined("FORM.textfield5") AND
#FORM.textfield5# NEQ "">
> <cfqueryparam value="#FORM.textfield5#"
cfsqltype="cf_sql_clob"
> maxlength="50">
> <cfelse>
> ''
> </cfif>
> , "description"=
> <cfif IsDefined("FORM.textarea") AND #FORM.textarea#
NEQ "">
> <cfqueryparam value="#FORM.textarea#"
cfsqltype="cf_sql_clob">
> <cfelse>
> ''
> </cfif>
> WHERE ID=<cfqueryparam value="#FORM.id#"
cfsqltype="cf_sql_numeric">
> </cfquery>
> <cflocation url="vacancyadmin.cfm">
> </cfif>
>
> this should then update my changes and take me back to
vacancyadmin.cfm.
> however all i get is the following error message:
>
> Error Executing Database Query.
> Parameter ?_5 has no default value.
>
> The error occurred in
F:\data\webdesigns\wwwroot\CFIDE\Allied\vacancyedit.cfm:
> line 35
>
> 33 : ''
> 34 : </cfif>
> 35 : WHERE ID=<cfqueryparam value="#FORM.id#"
cfsqltype="cf_sql_clob"
> maxlength="10">
> 36 : </cfquery>
> 37 : <cflocation url="vacancyadmin.cfm">
>
> SQL UPDATE new_vacancy_table1 SET area= (param 1) ,
pattern= (param 2) ,
> hrs= (param 3) , rate= '' , "description"= (param 4)
WHERE ID= (param 5)
> DATASOURCE allieddatabase
> VENDORERRORCODE 3088
> SQLSTATE  
> Resources:
>
> * Check the ColdFusion documentation to verify that you
are using the
> correct syntax.
> * Search the Knowledge Base to find a solution to your
problem.
>
> Browser Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8.1.3)
> Gecko/20070309 Firefox/2.0.0.3
> Remote Address 10.0.0.201
> Referrer
http://allied-srv-03/CFS/vacancyedit.cfm?ID=14
> Date/Time 07-Apr-07 12:56 PM
> Stack Trace
> at
>
cfvacancyedit2ecfm242791332.runPage(F:\data\webdesigns\wwwroot\CFIDE\Allied\vaca
> ncyedit.cfm:35) at
>
cfvacancyedit2ecfm242791332.runPage(F:\data\webdesigns\wwwroot\CFIDE\Allied\vaca
> ncyedit.cfm:35)
>
> com.inzoom.adojni.ComException: Parameter ?_5 has no
default value. in
> Microsoft JET Database Engine code=3088 Type=1
> at com.inzoom.ado.Command.jniExecute(Native Method)
> at com.inzoom.ado.Command.execute(Command.java:40)
> at com.inzoom.jdbcado.Statement.exec(Statement.java:34)
> at
com.inzoom.jdbcado.PreparedStatement.execute(PreparedStatement.java:201)
> at
>
coldfusion.server.j2ee.sql.JRunPreparedStatement.execute(JRunPreparedStatement.j
> ava:87)
> at
coldfusion.sql.Executive.executeQuery(Executive.java:756)
> at
coldfusion.sql.Executive.executeQuery(Executive.java:675)
> at
coldfusion.sql.Executive.executeQuery(Executive.java:636)
> at coldfusion.sql.SqlImpl.execute(SqlImpl.java:236)
> at
coldfusion.tagext.sql.QueryTag.doEndTag(QueryTag.java:500)
> at
>
cfvacancyedit2ecfm242791332.runPage(F:\data\webdesigns\wwwroot\CFIDE\Allied\vaca
> ncyedit.cfm:35)
> at
coldfusion.runtime.CfJspPage.invoke(CfJspPage.java:152)
> at
coldfusion.tagext.lang.IncludeTag.doStartTag(IncludeTag.java:349)
> at
coldfusion.filter.CfincludeFilter.invoke(CfincludeFilter.java:65)
> at
coldfusion.filter.ApplicationFilter.invoke(ApplicationFilter.java:225)
> at
coldfusion.filter.RequestMonitorFilter.invoke(RequestMonitorFilter.java:51)
> at
coldfusion.filter.PathFilter.invoke(PathFilter.java:86)
> at
coldfusion.filter.LicenseFilter.invoke(LicenseFilter.java:27)
> at
coldfusion.filter.ExceptionFilter.invoke(ExceptionFilter.java:69)
> at
coldfusion.filter.BrowserDebugFilter.invoke(BrowserDebugFilter.java:52)
> at
>
coldfusion.filter.ClientScopePersistenceFilter.invoke(ClientScopePersistenceFilt
> er.java:28)
> at
coldfusion.filter.BrowserFilter.invoke(BrowserFilter.java:38)
> at
coldfusion.filter.GlobalsFilter.invoke(GlobalsFilter.java:38)
> at
coldfusion.filter.DatasourceFilter.invoke(DatasourceFilter.java:22)
> at
>
coldfusion.filter.RequestThrottleFilter.invoke(RequestThrottleFilter.java:115)
> at coldfusion.CfmServlet.service(CfmServlet.java:107)
> at
coldfusion.bootstrap.BootstrapServlet.service(BootstrapServlet.java:78)
> at
jrun.servlet.ServletInvoker.invoke(ServletInvoker.java:91)
> at
jrun.servlet.JRunInvokerChain.invokeNext(JRunInvokerChain.java:42)
> at
jrun.servlet.JRunRequestDispatcher.invoke(JRunRequestDispatcher.java:257)
> at
jrun.servlet.ServletEngineService.dispatch(ServletEngineService.java:541)
> at
>
jrun.servlet.jrpp.JRunProxyService.invokeRunnable(JRunProxyService.java:204)
> at
>
jrunx.scheduler.ThreadPool$DownstreamMetrics.invokeRunnable(ThreadPool.java:318)
> at
>
jrunx.scheduler.ThreadPool$ThreadThrottle.invokeRunnable(ThreadPool.java:426)
> at
>
jrunx.scheduler.ThreadPool$UpstreamMetrics.invokeRunnable(ThreadPool.java:264)
> at
jrunx.scheduler.WorkerThread.run(WorkerThread.java:66)
>
>
>
> sorry its such a long post but i thought it best to post
all the info. can
> anyone see what the problem is with my code?
>
> thanks in advance
>
> zac
>
>