Update from a collection needs to error

Question

I am uploading a file into a collection..
then looping through the collection and updating a table with the following code..
It works for the ones that works, but does not display an error for any that don't work..
what would be the best way for this to catch the errors, and not commit any of changes from the collection if one of the records in the file uploaded doesn't work..
for r in (
select c001,c002 from htmldb_collections where collection_name='P50_COLLECTION' )
loop
if v('P50_PROPERTY_CLAIM_CHOICES') = 'CMR_RECIEVD' then
update property_claim set CMR_RECEIVED = r.c002 where CLAIM_NO = r.c001;
end if;
end loop;
--------------

Answer 1

The UPDATE may not actually update the data in many occasions (in above code)
when if condition not satisfied
when 'conditions' in where clause does not met
when there is no data in collections
so for any of above case, oracle won't raise any exception and thats the reason why you don;t see any message even though data has not been updated.
So update your process as follows.. so user will get error message when no rows updated..
BEGIN
if v('P50_PROPERTY_CLAIM_CHOICES') = 'CMR_RECIEVD' then
update property_claim
set CMR_RECEIVED = (select c002 from htmldb_collections
where collection_name='P50_COLLECTION' and CLAIM_NO = c001)
WHERE CLAIM_NO in (select c001 from htmldb_collections
where collection_name='P50_COLLECTION');
end if;
-- if no rows updated then show error message
-- alternatively you can also raise any custom exception here
IF SQL%NOTFOUND THEN
wwv_flow.g_notification := 'Error - No rows updated';
END IF;
COMMIT;
EXCEPTION
WHEN OTHERS THEN
rollback;
-- you can see this when you run in debug mode
wwv_flow.debug('Exception Raised ' ||SQLCODE ||'Message'|| SQLERRM);
wwv_flow.g_notification := 'Exception Raised ' ||SQLCODE ||'Error Message'|| SQLERRM;
END;Cheers,
Hari
Edited by: Hari_639 on Dec 10, 2009 8:58 AM