Using = and =

Question

I have created a function that accepts two parameters fromstyleid and tostyleid. These parameters can either have a % or a value. When I pass in a value for the TOSTYLEID I get all rows up to the specified row but not the value that was passed. If I execute a select against the database using the same syntax I get the top value returned.
This is the portion of the where clause that uses the parameters:
AND (SEWN.STYLE.STYLE_ID >= DECODE(''' || FromStyleID ||''', ''%'', SEWN.STYLE.STYLE_ID,''' || FromStyleID|| ''')
AND SEWN.STYLE.STYLE_ID <= DECODE(''' || ToStyleID ||''', ''%'', SEWN.STYLE.STYLE_ID,''' || ToStyleID|| '''))
This would return 7 rows if it specify 18803 for the fromstyleid and 30011 for the tostyleid
if I execute the following in SQL Plus I get 8 rows
select styleid from styles where styleid >= 18803 and styleid <= 30011
Any suggestions on what is happening would be greatly appreciated.
Thom

Answer 1

Below is the full function. Dynamic sql is being used because one of the parameters, divisionid, is passed in as either a single value or a list of values seperated by ,. The commas are replaced with ',' and a single quote appended to front and back of the new string. If there is a different way to do this then please advise.
create or replace FUNCTION UF_ITM(BusinessUnitID char, DivisionID char, FromStyleID char, ToStyleID char, ProductType char) return types.ref_cursor
AS
itm_cursor types.ref_cursor;
divid varchar(25);
BEGIN
divid := '''' ||replace(divisionid,',',''',''') || '''';
OPEN itm_cursor FOR
'SELECT
STYLE_COLOR_ID.CURRENT_COST_PERIOD_CODE,
STYLE.STYLE_ID,
STYLE.STYLE_DESCRIPTION,
STYLE.UNIT_OF_MEASURE_CODE,
STYLE_COLOR_ID.COLOR_ID,
DIV_LBL.LABEL_ID,
STYLE.STYLE_CATEGORY_ID,
STYLE_COLOR_ID.INVENTORY_GL_CATEGORY_CODE,
STYLE_COLOR_ID.SIZE_RANGE_CODE,
STYLE_COLOR_ID.STY_COLO_IDEN_INVE_USAG_IND,
STYLE_COLOR_ID.DEFA_DEMAND_SIZE_SCALE_CODE,
STYLE_COLOR_ID.DEFA_SUPPLY_SIZE_SCALE_CODE,
STYLE_COLOR_ID.IDENTIFIER_ID,
STYLE.EDI_SELECTION_CODE, STYLE_COLOR_ID.STYLE_COLOR_IDEN_BOM_LEVEL,
STYLE.DIV_ID
FROM
STYLE_COLOR_ID,
STYLE,
DIV_LBL,
SEWN.LABEL
WHERE
( STYLE.BUID=DIV_LBL.BUID(+)
and STYLE.DIV_ID=DIV_LBL.DIV_ID(+)
and STYLE.LABEL_ID=DIV_LBL.LABEL_ID(+) )
AND ( DIV_LBL.BUID=LABEL.BUID
and DIV_LBL.LABEL_ID=LABEL.LABEL_ID )
AND ( STYLE.BUID=STYLE_COLOR_ID.BUID
and STYLE.STYLE_ID=STYLE_COLOR_ID.STYLE_ID )
AND ( LABEL.BUID = ''' || BusinessUnitId || ''')
AND (STYLE.STYLE_ID >= DECODE(''' || FromStyleID ||''', ''%'', STYLE.STYLE_ID,''' || FromStyleID|| ''')
AND STYLE.STYLE_ID <= DECODE(''' || ToStyleID ||''', ''%'', STYLE.STYLE_ID,''' || ToStyleID|| '''))
AND STYLE.STYLE_PRODUCT_TYPE_IND LIKE ''' || ProductType || '''
AND STYLE.DIV_ID IN (' || DivID || ')';
RETURN itm_cursor;
end uf_itm;
/