Cant send mail from method

Question

Hi All
I have a class that I developed, one of my methods should send mail.
I tried using the function : SO_NEW_DOCUMENT_SEND_API1 in order to do so.
I also tried using the class : cl_bcs .
In both methods I have written commit work after activating the function/method.
The mail did get into my private outbox, but it did not reach SCOT ( transaction ).
I tried writing the same code as I wrote in the method inside a program and it worked fine ( including the SCOT part).
Do any of u have any idea why would the same code work in a regular program and not in a method?????
Thanks
Nitsan

Answer 1

Hi Nitsan,
Please check the code below. It will surely work.
DATA:
     it_text TYPE STANDARD TABLE OF solisti1
              WITH NON-UNIQUE DEFAULT KEY,
     it_cont TYPE STANDARD TABLE OF solisti1
              WITH NON-UNIQUE DEFAULT KEY.
  DATA: send_request       TYPE REF TO cl_bcs.
*  DATA: text               TYPE bcsy_text.
*  DATA: binary_content     TYPE solix_tab.
  DATA: document           TYPE REF TO cl_document_bcs.
  DATA: sender             TYPE REF TO if_sender_bcs. "cl_sapuser_bcs.
  DATA: recipient          TYPE REF TO if_recipient_bcs.
  DATA: bcs_exception      TYPE REF TO cx_bcs.              "#EC *
  DATA: sent_to_all        TYPE os_boolean.
  DATA: wa_subject(50) TYPE c.
  IF admin_flag = 'X'.
    wa_subject = text-046.
  ELSE.
    wa_subject = text-047.
  ENDIF.
  CLEAR wa_err_flg.
  PERFORM create_style CHANGING it_text.     u201Csee below
  PERFORM create_message USING
    p_pernr wa_first_name wa_last_name wa_admin_name att_flag correction_flag reclass_flag miss_receipt_flag w_total_amt.    u201Csee below
  TRY.
*     -------- create persistent send request ------------------------
      send_request = cl_bcs=>create_persistent( ).
*     -------- create and set document with attachment ---------------
*     create document from internal table with text
      document = cl_document_bcs=>create_document(
                      i_type    = 'HTM'
                      i_text    = it_text
*                      i_length  = '12'
                      i_subject = wa_subject ).
*     add attachment to document
*     BCS expects document content here e.g. from document upload
*     binary_content = ...
      IF att_flag IS NOT INITIAL.
        CALL METHOD document->add_attachment
          EXPORTING
            i_attachment_type    = 'HTM'
            i_attachment_subject = wa_subject
            i_att_content_text   = it_cont.
      ENDIF.
*     add document to send request
      CALL METHOD send_request->set_document( document ).
*     --------- set sender -------------------------------------------
*     note: this is necessary only if you want to set the sender
*           different from actual user (SY-UNAME). Otherwise sender is
*           set automatically with actual user.
      sender ?= cl_cam_address_bcs=>create_internet_address(
                                        'ur email address' ).
*      sender = cl_sapuser_bcs=>create( sy-uname ).
      CALL METHOD send_request->set_sender
        EXPORTING
          i_sender = sender.
*     SENDER = 'ExpCompliance'.   "<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
*     --------- add recipient (e-mail address) -----------------------
*     create recipient - please replace e-mail address !!!
      DATA: wa_addr TYPE ad_smtpadr.
      MOVE wa_email_addr TO wa_addr.
      recipient = cl_cam_address_bcs=>create_internet_address(
                                        wa_addr ).
*     add recipient with its respective attributes to send request
      CALL METHOD send_request->add_recipient
        EXPORTING
          i_recipient = recipient
          i_express   = 'X'.
*     ---------- send document ---------------------------------------
      CALL METHOD send_request->send(
        EXPORTING
          i_with_error_screen = 'X'
        RECEIVING
          result              = sent_to_all ).
  IF sent_to_all = 'X'.
        COMMIT WORK.
        LOOP AT i_person_data ASSIGNING <fs_person_data>.
          MOVE <fs_person_data> TO wa_error_data.
          CONCATENATE wa_error_data-comments text-020 INTO wa_error_data-comments SEPARATED BY space.
          APPEND wa_error_data TO i_success.
        ENDLOOP.
      ELSE.
        LOOP AT i_person_data ASSIGNING <fs_person_data>.
          MOVE <fs_person_data> TO wa_error_data.
          MOVE text-021 TO wa_error_data-comments.
          APPEND wa_error_data TO i_email_errors.
          MOVE 'X' TO wa_err_flg.
          MOVE 'X' TO <fs_person_data>-error_flag.
        ENDLOOP.
      ENDIF.
* *                     exception handling
* * replace this very rudimentary exception handling
* * with your own one !!!
    CATCH cx_bcs INTO bcs_exception.
*      WRITE: 'Fehler aufgetreten.'(001).
*      WRITE: 'Fehlertyp:'(002), bcs_exception->error_type.
*      EXIT.
*begin v02
      LOOP AT i_person_data ASSIGNING <fs_person_data>.
        MOVE <fs_person_data> TO wa_error_data.
        MOVE text-021 TO wa_error_data-comments.
        APPEND wa_error_data TO i_email_errors.
        MOVE 'X' TO wa_err_flg.
        MOVE 'X' TO <fs_person_data>-error_flag.
      ENDLOOP.
*end v02
  ENDTRY.
  COMMIT WORK.    <<<< important!!!! You must do this after each email sent
**********************************************************additional forms for style and message text********************************************
*&      Form  create_style
*       text
*      <--P_IT_TEXT  text
FORM create_style  CHANGING fpi_text TYPE it_text.
  DATA: w_line TYPE soli.
  CONCATENATE '<STYLE type = "text/css">'
    'A:link {COLOR: navy; TEXT-DECORATION: none}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE 'A:visited {COLOR: #3389a9;' 'TEXT-DECORATION: none}' INTO
  w_line.
  APPEND w_line TO fpi_text.
  w_line = 'A:hover {COLOR: #590000; TEXT-DECORATION: underline}'.
  APPEND w_line TO fpi_text.
  w_line = 'A:unknown {COLOR: white; TEXT-DECORATION: none}'.
  APPEND w_line TO fpi_text.
  w_line = 'B {      FONT-WEIGHT: bold}'.
  APPEND w_line TO fpi_text.
  CONCATENATE
'BODY {FONT-WEIGHT: normal; FONT-SIZE: 10pt; MARGIN: 0px; FONT-STYLE:'
'normal; FONT-FAMILY: Arial, Helvetica, sans-serif; BACKGROUND-COLOR:'
  'white}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'H1 {FONT-WEIGHT: bold; FONT-SIZE: 20pt; COLOR: black; FONT-STYLE:'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'H2 {FONT-WEIGHT: bold; FONT-SIZE: 16pt; COLOR: black; FONT-STYLE:'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'H3 {FONT-WEIGHT: bold; FONT-SIZE: 14pt; COLOR: black; FONT-STYLE:'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'H4 {FONT-WEIGHT: bold; FONT-SIZE: 12pt; COLOR: black; FONT-STYLE:'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'H5 {FONT-WEIGHT: bold; FONT-SIZE: 10pt; COLOR: black; FONT-STYLE:'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  w_line = 'I {      FONT-STYLE: italic }'.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'P {FONT-WEIGHT: normal; FONT-SIZE: 10pt; COLOR: black; FONT-STYLE:'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  'TD {FONT-WEIGHT: normal; FONT-SIZE: 10pt; COLOR: black; FONT-STYLE'
  'normal; FONT-FAMILY: Arial, Helvetica, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  '.SectionBlockHeader {'
  'FONT-WEIGHT: bold; FONT-SIZE: 10pt; COLOR: #000066; FONT-FAMILY:'
  'Verdana}' INTO w_line.
  APPEND w_line TO fpi_text.
  CONCATENATE
  '.channelcontent {'
  'FONT-SIZE: 11px; MARGIN-BOTTOM: 3px; COLOR: #000000; FONT-FAMILY:'
  'Verdana, sans-serif}' INTO w_line.
  APPEND w_line TO fpi_text.
  w_line = '</STYLE>'.
  APPEND w_line TO fpi_text.
ENDFORM.                    " create_style
*&      Form  create_message
*      Create message text
FORM create_message USING p_pernr TYPE persno
                          wa_first_name LIKE pa0002-vorna
                          wa_last_name LIKE pa0002-nachn
                          wa_admin_name LIKE pa0002-vorna
                          wa_att_flag TYPE c
                          wa_corr_flag TYPE c
                          wa_reclass_flag TYPE c
                          wa_miss_receipt_flag TYPE c
                          wa_total_amt TYPE wertv8.         "#EC NEEDED
  DATA: wa_amount_text LIKE wa_text_store.
  DATA: wa_ptr_dir(80)  TYPE c.
  DATA: char_total_amt(10) TYPE c.
  FIELD-SYMBOLS: <fs_more_text> LIKE wa_text_store.
*get auditors phone number
  READ TABLE i_person_data INDEX 1 INTO wa_person_data.
  CLEAR wa_phone-phone.
  READ TABLE i_auditor INTO wa_auditor WITH KEY usrid = wa_person_data-auditor.
  IF sy-subrc NE 0.
    MOVE text-033 TO wa_auditor-phone.
  ENDIF.
  CONCATENATE '(' wa_auditor-phone+0(3) ')' ' ' wa_auditor-phone+3(3) '-' wa_auditor-phone+6(4) INTO wa_auditor-phone.
  CONCATENATE wa_first_name wa_last_name INTO wa_ptr_dir SEPARATED BY space.
  WRITE wa_total_amt TO char_total_amt CURRENCY wa_person_data-loc_curr.
  PERFORM get_payroll_date USING p_pernr CHANGING w_date.
*line 1
  REPLACE '[NAME]' IN  <fs_text_store>-zline1 WITH wa_first_name.
  REPLACE '[ADMIN_NAME]' IN  <fs_text_store>-zline1 WITH wa_admin_name.
  APPEND <fs_text_store>-zline1 TO it_text.
*line 2
  CONCATENATE wa_first_name wa_last_name INTO wa_ptr_dir SEPARATED BY space.
  CONDENSE wa_ptr_dir.
  REPLACE '[PTR_DIR]' IN <fs_text_store>-zline2 WITH wa_ptr_dir.
  REPLACE '[INSERT TABLE]' IN  <fs_text_store>-zline2 WITH ' '.
  IF wa_admin_name IS NOT INITIAL.
    REPLACE 'Your' IN <fs_text_store>-zline2 WITH 'The'.
  ENDIF.
  IF sy-subrc = 0.
    APPEND <fs_text_store>-zline2 TO it_text.
    PERFORM insert_table USING wa_att_flag p_pernr.
  ELSE.
    APPEND <fs_text_store>-zline2 TO it_text.
  ENDIF.
*line3
  REPLACE '[INSERT TABLE]' IN  <fs_text_store>-zline3 WITH ''.
  IF sy-subrc = 0.
    APPEND <fs_text_store>-zline3 TO it_text.
    PERFORM insert_table USING wa_att_flag p_pernr.
  ELSE.
    APPEND <fs_text_store>-zline3 TO it_text.
  ENDIF.
*line4'
  IF <fs_text_store>-zline4 IS NOT INITIAL.
    REPLACE '[INSERT TABLE]' IN  <fs_text_store>-zline4 WITH ' '.
    IF sy-subrc = 0.
      APPEND <fs_text_store>-zline4 TO it_text.
      PERFORM insert_table USING wa_att_flag p_pernr.
    ELSE.
      APPEND <fs_text_store>-zline4 TO it_text.
    ENDIF.
  ENDIF.
  IF wa_total_amt IS NOT INITIAL.
    READ TABLE it_text_store INTO wa_amount_text WITH KEY zline10 = 'Amount Text' .
    IF sy-subrc NE 0.
      CLEAR wa_error_data.
      MOVE 'Amount Text is not on ZTE_TEXT_STORE table. ' TO wa_error_data-comments.
      APPEND wa_error_data TO i_spreadsheet_errors.
      RETURN.
    ELSE.
      REPLACE '[DATE]' IN  wa_amount_text-zline1 WITH w_date.
      REPLACE '[AMOUNT]' IN  wa_amount_text-zline1 WITH char_total_amt.
      IF wa_admin_name IS NOT INITIAL.
        REPLACE 'your' IN wa_amount_text-zline1 WITH 'the'.
      ENDIF.
      APPEND wa_amount_text-zline1 TO it_text.
    ENDIF.
  ENDIF.
  IF wa_reclass_flag = 'X'.
    READ TABLE it_text_store ASSIGNING <fs_more_text> WITH KEY zline10 = 'Re-Class of Expense' .
    IF sy-subrc NE 0.
      CLEAR wa_error_data.
      MOVE text-022 TO wa_error_data-comments.
      APPEND wa_error_data TO i_spreadsheet_errors.
      RETURN.
    ELSE.
      IF wa_admin_name IS NOT INITIAL.
        REPLACE 'your' IN <fs_more_text>-zline2 WITH 'the'.
      ENDIF.
      APPEND <fs_more_text>-zline2 TO it_text.
    ENDIF.
  ENDIF.
  IF wa_total_amt LT 0.
    APPEND wa_amount_text-zline2 TO it_text.
    APPEND wa_amount_text-zline3 TO it_text.
    APPEND wa_amount_text-zline4 TO it_text.
  ENDIF.
*line5
  IF <fs_text_store>-zline5 IS NOT INITIAL.
    REPLACE '[PHONE]' IN <fs_text_store>-zline5 WITH wa_auditor-phone.
    IF wa_auditor-name IS NOT INITIAL.
      REPLACE text-023 IN <fs_text_store>-zline5 WITH wa_auditor-name.  "the expense compliance help desk
    ENDIF.
    APPEND <fs_text_store>-zline5 TO it_text.
  ENDIF.
*line6
  IF <fs_text_store>-zline6 IS NOT INITIAL.
    APPEND <fs_text_store>-zline6 TO it_text.
  ENDIF.
*line7
  IF <fs_text_store>-zline7 IS NOT INITIAL.
    APPEND <fs_text_store>-zline7 TO it_text.
  ENDIF.
*line8
  IF <fs_text_store>-zline8 IS NOT INITIAL.
    APPEND <fs_text_store>-zline8 TO it_text.
  ENDIF.
*line9
  IF <fs_text_store>-zline9 IS NOT INITIAL.
    APPEND <fs_text_store>-zline9 TO it_text.
  ENDIF.
ENDFORM.                    " create_message
Regards,
Guru.
Edited by: Guru Gompa on Sep 17, 2009 12:38 PM