Code seems logical enough to me, please help!!!!!??

Question

int i = 0;
int j = database.length;
while ( i < j )
if (database[i] == null)
{ database[i] = bankrecord;
i = database.length ; //break out of the loop termination has ended
else if ( database.getUserID().equals(bankrecord.getUserID()) )
{} // do not add customer to database as it already exists
else
{   //the customer is not in database so add it to position
database[i+1] = bankrecord; //customer is not in database so add it to next position in database
i = database.length; //break out of loop.
i++;
please reply??

Answer 1

Hi again,
ok, I will assume the [ ] at the right places - let's see what you are doing in the first while-loop
( I have substituted database.length by DATABASE_LENGTH because it is always the same as it)
I also use a x instead of an i - because i in brackets produce italic fontstyle :)
int x = 0;
while (x<DATABASE_LENGTH)
if (database[x]==null) { database[x]=bankrecord; x = DATABASE_LENGTH; } else
if (!database[x].getUserID().equals(bankrecord.getUserID()))
database[x+1] = bankrecord;
x = DATABASE_LENGTH;
x++;
ok, that inserts the first bankrecord correct - because there is nothing in the database-array - if there would be something in it - say position 0 to 2, and none of them are the same as the bankrecord to insert - what would happen?
Bankrecord on position 1 would be overwritten by the new one - losing that information stored there before.
You can add a new bankrecord only if you have tested all the other records before, if they all don't match with the new one - so the insertion is more like this
int x = 0;
while (x<DATABASE_LENGTH)
if (database[x]==null)
{ database[x]=bankrecord;
x = DATABASE_LENGTH; }
else if (database[x].getUserID().equals(bankrecord.getUserID()))
{ x = DATABASE_LENGTH;
} else x++;
this loop exits on 3 conditions:
1. record is added to the database in the first unused position
2. record has been in the database before
3. there is no room in the database for new entries
the same can be used to insert the second record - so it is obvious to use a method for that part:
method void insertRecord(BankRecord r) {
int x = 0;
while (x<DATABASE_LENGTH)
if (database[x]==null)
{ database[x]=r;
x = DATABASE_LENGTH; }
else if (database[x].getUserID().equals(r.getUserID()))
{ x = DATABASE_LENGTH;
} else x++;
now you can use that easy
bankrecord = new BankRecord();
bankrecord.setUserID("w110");
insertRecord(bankrecord);
bankrecord = new BankRecord();
bankrecord.setUserID("w119");
insertRecord(bankrecord);
it would be easier too, if you provide a second constructor for the BankRecord class
public BankRecord(String UserID) { userID = UserID; }
then you are able to use it that way
insertRecord(new BankRecord("w110"));
insertRecord(new BankRecord("w119"));
you see the difference? :)
greetings Marsian