EA1: A few formatter issues

Question

1. Alignment of AND keywords in select statement is wrong.
  function get_segment_size(ownname in varchar2,   segname in varchar2, segtype in varchar2) return number is indsize number(16);
  begin
    begin
      select bytes
      into indsize
      from dba_segments
      where owner = ownname
       and segment_type = segtype
       and segment_name = segname;
    exception
    when others then
      raise;
    end;
    return indsize;
  end;becomes
FUNCTION get_segment_size
    ownname IN VARCHAR2,
    segname IN VARCHAR2,
    segtype IN VARCHAR2 )
  RETURN NUMBER
IS
  indsize NUMBER ( 16 ) ;
BEGIN
  BEGIN
     SELECT bytes
       INTO indsize
       FROM dba_segments
      WHERE owner  = ownname
  AND segment_type = segtype
  AND segment_name = segname;
  EXCEPTION
  WHEN OTHERS THEN
    raise;
  END;
  RETURN indsize;
END;The ANDs are left aligned with the enclosing block rather than right aligned with the 'master keywords'.
2. NUMBER(?,?) and VARCHAR2(?) declarations have parentheses and sizes split over multiple lines.
  index_list dba_indexes_tab;
  rebuild_stmt varchar2(200);
  end_time date;
  start_size number(16,   0);
  end_size number(16,   0);
  batch app_support_batch_runs % rowtype;
  batch_results resultset;becomes
  index_list dba_indexes_tab;
  rebuild_stmt VARCHAR2
    200
  end_time DATE;
  start_size NUMBER
    16, 0
  end_size NUMBER
    16, 0
  batch app_support_batch_runs % rowtype;
  batch_results resultset;3. Some array subscripted expressions have their parentheses split across multiple lines.
    end_time := sysdate;
    batch_results := resultset();
    batch_results.extend;
    batch_results(batch_results.last).asjr_result_type := 'ELAPSED_TIME';
    batch_results(batch_results.last).asjr_result_key := 'ALL';
    batch_results(batch_results.last).asjr_result_value :=((end_time -batch.asbr_component_start_time) *(24 *60 *60));becomes
  end_time      := sysdate;
  batch_results := resultset
  batch_results.extend;
  batch_results
    batch_results.last
  .asjr_result_type := 'ELAPSED_TIME';
  batch_results
    batch_results.last
  .asjr_result_key := 'ALL';
  batch_results
    batch_results.last
  .asjr_result_value :=
    ( end_time -batch.asbr_component_start_time ) * ( 24 *60 *60 )
  ;Another similar block later in the same package is left as single lines.
4. 3 seems to apply generally to expressions involving parentheses - array subscripts, procedure calls. Some are done properly, others are spread across multiple lines.
5. Various keywords are not recognised by the formatter, although they are by the syntax highlighter. (They are in bold, but not upper case)
raise
extend
last
immediate
6. There doesn't seem to be away to format the current selection rather than the whole buffer (in the PL/SQL editor)

Answer 1

Given this -
select prej.asbr_component_name,
  prej.asbr_batch_start_time,
  etime.asjr_result_value Elapsed,
  prer.asjr_result_value Size_before,
  postr.asjr_result_value Size_after,
  prer.asjr_result_value -postr.asjr_result_value Shrinkage
from app_support_batch_runs prej
inner join app_support_job_result prer on prer.asjr_asbr_id = prej.asbr_id
inner join app_support_job_result postr on postr.asjr_asbr_id = prej.asbr_id
inner join app_support_job_result etime on etime.asjr_asbr_id = prej.asbr_id
where prer.asjr_result_type = 'START_SIZE'
and postr.asjr_result_type = 'END_SIZE'
and etime.asjr_result_type = 'ELAPSED_TIME'
order by prej.asbr_component_name;with [em]indent AND/OR[em] unchecked, you get this.
SELECT prej.asbr_component_name    ,
  prej.asbr_batch_start_time        ,
  etime.asjr_result_value Elapsed   ,
  prer.asjr_result_value Size_before,
  postr.asjr_result_value Size_after,
  prer.asjr_result_value -postr.asjr_result_value Shrinkage
   FROM app_support_batch_runs prej
INNER JOIN app_support_job_result prer
     ON prer.asjr_asbr_id = prej.asbr_id
INNER JOIN app_support_job_result postr
     ON postr.asjr_asbr_id = prej.asbr_id
INNER JOIN app_support_job_result etime
     ON etime.asjr_asbr_id    = prej.asbr_id
  WHERE prer.asjr_result_type = 'START_SIZE'
AND postr.asjr_result_type    = 'END_SIZE'
AND etime.asjr_result_type    = 'ELAPSED_TIME'
ORDER BY prej.asbr_component_name;The problems with this are.
1) The sql statement as a whole is indented (ie the select keyword)
2) Despite 1), INNER, AND and ORDER are NOT indented at all whereas the should be at least level with the select. I suspect the problem may be that it is trying to right align 'INNER JOIN' and 'ORDER BY' with the SELECT-FROM-WHERE.I thing the ON of the join clauses is right aligned.
3) The column list isn't right. The columns should be left aligned and positioned one space to the right of the select keyword ( or at a pinch on a new line, indented from the select keyword by 2 columns)
with [em]indent AND/OR[em] checked, you get this.
SELECT prej.asbr_component_name    ,
  prej.asbr_batch_start_time        ,
  etime.asjr_result_value Elapsed   ,
  prer.asjr_result_value Size_before,
  postr.asjr_result_value Size_after,
  prer.asjr_result_value -postr.asjr_result_value Shrinkage
   FROM app_support_batch_runs prej
INNER JOIN app_support_job_result prer
     ON prer.asjr_asbr_id = prej.asbr_id
INNER JOIN app_support_job_result postr
     ON postr.asjr_asbr_id = prej.asbr_id
INNER JOIN app_support_job_result etime
     ON etime.asjr_asbr_id    = prej.asbr_id
  WHERE prer.asjr_result_type = 'START_SIZE'
  AND postr.asjr_result_type  = 'END_SIZE'
  AND etime.asjr_result_type  = 'ELAPSED_TIME'
ORDER BY prej.asbr_component_name;This is better but still has the problems with right-alignment.
With [em]Right-align master keywords[em] unchecked...
SELECT prej.asbr_component_name     ,
  prej.asbr_batch_start_time        ,
  etime.asjr_result_value Elapsed   ,
  prer.asjr_result_value Size_before,
  postr.asjr_result_value Size_after,
  prer.asjr_result_value -postr.asjr_result_value Shrinkage
FROM app_support_batch_runs prej
INNER JOIN app_support_job_result prer
ON prer.asjr_asbr_id = prej.asbr_id
INNER JOIN app_support_job_result postr
ON postr.asjr_asbr_id = prej.asbr_id
INNER JOIN app_support_job_result etime
ON etime.asjr_asbr_id        = prej.asbr_id
WHERE prer.asjr_result_type  = 'START_SIZE'
  AND postr.asjr_result_type = 'END_SIZE'
  AND etime.asjr_result_type = 'ELAPSED_TIME'
ORDER BY prej.asbr_component_name;IMO This is best but I would like ON indented with respect to the INNER JOIN it belongs to.
So in terms of this sql statement, I think the only bug is the alignment of columns. The right alignment option doesn't work very well for longer 'keywords' (mainly the new-fangled sql-92 stuff). Perhaps a redefinition of what constitutes a master keyword would do better.