Error when trying to send an attachment

Question

Hi there,
I am running an application in Tomcat 5.5 and I am trying to send an email with an attachment via java mail. The attachment will eventually be a zip file containing wav files but I can't seem to get it to work with a text file yet.
I may be a little confused...I am especially confused with the DataHandlerSet stuff.
Here is the code:
public String sendmail(String msgSubject)
     //Sets some variables.
    String emailmultipart = "true"; //if this is set to false sends a simple message.
    String msgText = "Some text \n\n";
    String smtphost = "myhost";
    String emailto = "[email protected]";
    String emailfrom =  "[email protected]";
    //Gives the path of where the sound files are.
    File soundfile = new File("myfile.txt");
    boolean debug = true; // change to get more information
    String msgText2 = "multipart message";
    boolean sendmultipart = Boolean.valueOf(emailmultipart).booleanValue();
       // set the host
    Properties props = new Properties();
    props.put("mail.smtp.host", smtphost);
      // create some properties and get the default Session
    Session session = Session.getDefaultInstance(props, null);
    session.setDebug(debug);
    try
          // create a message
           Message msg = new MimeMessage(session);
           // set the from address
           InternetAddress from = new InternetAddress(emailfrom);
           msg.setFrom(from);
           //set the to address
           InternetAddress[] address =
               new InternetAddress(emailto)
           msg.setRecipients(Message.RecipientType.TO, address);
           //set subject - support request id
           msg.setSubject(msgSubject);
          //decides whether to send plain text message or multi text message (from true/false in the command line)
          //sends a simple plain text email
          if(!sendmultipart)
             // send a plain text message
             msg.setContent(soundfile, "text/plain");
          //sends an attached file.
          else
             // send a multipart message// create and fill the first message part
             MimeBodyPart mbp1 = new MimeBodyPart();
             //adds the text as normal
             mbp1.setContent(msgText, "text/plain");
             // create and fill the second message part
            MimeBodyPart mbp3 = new MimeBodyPart();
            // attach the file to the message
              //FileDataSource fds = new FileDataSource(filen);
              FileDataSource fds = new FileDataSource(soundfile);
             mbp3.setDataHandler(new DataHandler(fds));
             mbp3.setFileName(fds.getName());
//             mbp3.setContent();
            Multipart mp = new MimeMultipart();
            //adds the text to the message
            mp.addBodyPart(mbp1);
              //adds the attachment to the message
              mp.addBodyPart(mbp3);
            // adds the content to the message
            msg.setContent(mp);
         //Transport - sends the message.
         Transport.send(msg);
    catch(MessagingException mex)
      mex.printStackTrace();
    //log.debug("At end of Send email");
    return "nothing";
}Here is the error:
javax.mail.MessagingException: IOException while sending message;
nested exception is:
     java.io.IOException: "text/html" DataContentHandler requires String object, was given object of type class javax.mail.internet.MimeMultipart
     at com.sun.mail.smtp.SMTPTransport.sendMessage(SMTPTransport.java:566)
     at javax.mail.Transport.send0(Transport.java:151)
     at javax.mail.Transport.send(Transport.java:80)
     at questionnaireweb.Formemail.sendmail(Formemail.java:337)
     at org.apache.jsp.web.emailrecorded_jsp._jspService(org.apache.jsp.web.emailrecorded_jsp:338)
     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:99)
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
     at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:325)
     at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
     at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:245)
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
     at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
     at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
     at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
     at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
     at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
     at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
     at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:825)
     at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:731)
     at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:526)
     at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
     at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
     at java.lang.Thread.run(Thread.java:595)
I'd be really grateful for any help. I can't seem to get past this error not matter what I try. Sending the simple mail works, but sending an attachment produces the error above. I have seen similar errors before but when the user actually wants to send html and not a file.
Thanks a lot,
Jess

Answer 1

HI ,Thanks for your response. That was an error in the code I posted, but wasn't the error I was trying to solve. Once correcting that error you pointed out I am getting the problems not when I send a plain text email like:
          if(!sendmultipart)
             // send a plain text message
             msg.setContent(msgText, "text/plain");
          }but when I try and send multipart messages doing this:
          else
             // send a multipart message// create and fill the first message part
                   MimeBodyPart mbp1 = new MimeBodyPart();
     mbp1.setText(msgText);
      // create and fill the second message part
     MimeBodyPart mbp3 = new MimeBodyPart();
     // attach the file to the message
     FileDataSource fds = new FileDataSource(soundfile);
     mbp3.setDataHandler(new DataHandler(fds));
     mbp3.setFileName(fds.getName());
                   Multipart mp = new MimeMultipart();
     //adds the text to the message
      mp.addBodyPart(mbp1);
      //adds the attachment to the message
      mp.addBodyPart(mbp3);
       // adds the content to the message
      msg.setContent(mp);
     }So i get the error when executing the else branch.
Can you spot any errors here? I get the same error as mentioned earlier.
Thanks a lot,
Jess