Hc, hcg, and libmapm PKGBUILDs advice/testing

Question

Hello,
I am writing a calculator - hc (cli version) and hcg (gui version) which require the MAPM library.
More information can be found here:
http://bbs.archlinux.org/viewtopic.php?id=85641
goran'agar and I wrote PKGBUILDs for these 3:
# Contributor: Fabio Comolli <[email protected]>
pkgname=mapm
pkgver=4.9.5
pkgrel=1
pkgdesc="Mike's Arbitrary Precision Math Library"
url="http://www.tc.umn.edu/~ringx004/mapm-main.html"
depends=('gcc')
provides=('mapm')
source=("http://www.tc.umn.edu/~ringx004/mapm-$pkgver.tar.gz")
md5sums=('a92ff86b6240f78f882661e0b1c11920')
license=('freeware')
arch=('i686' 'x86_64')
build() {
cd $startdir/src/mapm_$pkgver
gcc -c -Wall -O2 -fPIC map*.c || return 1
gcc -shared -o libmapm.so.0 map*.o || return 1
mkdir -p $startdir/pkg/usr/lib
mkdir -p $startdir/pkg/usr/include
mkdir -p $startdir/pkg/usr/share/mapm
cp $startdir/src/mapm_$pkgver/libmapm.so.0 $startdir/pkg/usr/lib
cp $startdir/src/mapm_$pkgver/m_apm*.h $startdir/pkg/usr/include
cp -a $startdir/src/mapm_$pkgver/DOCS $startdir/pkg/usr/share/mapm
# Contributor: Fabio Comolli <[email protected]>
pkgname=hcg
pkgver=0.4.2
pkgrel=1
pkgdesc="HoubySoft Calculator - a calculator with lot of options and abundant functions"
url="http://hc.houbysoft.com"
depends=('mapm' 'gtk2' 'glib2')
provides=('hcg')
source=("http://houbysoft.com/download/$pkgname-$pkgver-src.tar.gz")
md5sums=('3c06c0d9e4ffb220a30820c733d55d1d')
license=('GPL 3')
arch=('i686' 'x86_64')
build() {
cd $startdir/src/$pkgname-$pkgver-src
gcc -DHCG `pkg-config gtk+-2.0 gthread-2.0 --cflags` -DHCG_E -c main.c || return 1
gcc -DHCG `pkg-config gtk+-2.0 gthread-2.0 --cflags` -DHCG_E -c utils.c || return 1
gcc -DHCG_E -c hc_functions.c || return 1
gcc -DHCG_E -c hc.c || return 1
gcc `pkg-config gtk+-2.0 gthread-2.0 --cflags --libs` main.o utils.o hc_functions.o hc.o /usr/lib/libmapm.so.0 -o hcg || return 1
mkdir -p $startdir/pkg/usr/bin
mkdir -p $startdir/pkg/usr/share/$pkgname
cp $startdir/src/$pkgname-$pkgver-src/$pkgname $startdir/pkg/usr/bin
cp -a $startdir/src/$pkgname-$pkgver-src/README $startdir/pkg/usr/share/$pkgname
cp -a $startdir/src/$pkgname-$pkgver-src/LICENSE $startdir/pkg/usr/share/$pkgname
# Contributor: Jan Dlabal <dlabaljan at gmail dot com>
pkgname=hc
pkgver=0.4.2
pkgrel=1
pkgdesc="HoubySoft Calculator - a calculator with lot of options and abundant functions - CLI version"
url="http://hc.houbysoft.com"
depends=('mapm')
provides=('hc')
source=("http://houbysoft.com/download/$pkgname-$pkgver-src.tar.gz")
md5sums=('2256ea75ecee8bd41a3d1d02bb189945')
license=('GPL 3')
arch=('i686' 'x86_64')
build() {
cd $startdir/src/$pkgname-$pkgver-src
gcc -c main.c || return 1
gcc -c hc.c || return 1
gcc -c hc_functions.c || return 1
gcc main.o hc_functions.o hc.o /usr/lib/libmapm.so.0 -lm -o hc || return 1
mkdir -p $startdir/pkg/usr/bin
mkdir -p $startdir/pkg/usr/share/$pkgname
cp $startdir/src/$pkgname-$pkgver-src/$pkgname $startdir/pkg/usr/bin
cp -a $startdir/src/$pkgname-$pkgver-src/README $startdir/pkg/usr/share/$pkgname
cp -a $startdir/src/$pkgname-$pkgver-src/LICENSE $startdir/pkg/usr/share/$pkgname
So I am just submitting these for review and testing, and further advice as to what to do now, ie is it ready to be uploaded to AUR? Is there anything else that needs to be done? Anything that should be changed in the PKGBUILDs?
Thanks

Answer 1

Thanks for your advice. I fixed everything (hopefully) except the Makefile, because all the packages were originally built statically, and so I think it's simpler to just do this.
Modified PKGBUILD for mapm:
# Contributor: Fabio Comolli <[email protected]>
pkgname=mapm
pkgver=4.9.5
pkgrel=1
pkgdesc="Mike's Arbitrary Precision Math Library"
arch=('i686' 'x86_64')
url="http://www.tc.umn.edu/~ringx004/mapm-main.html"
license=('custom')
source=("http://www.tc.umn.edu/~ringx004/mapm-$pkgver.tar.gz")
md5sums=('a92ff86b6240f78f882661e0b1c11920')
build() {
cd $srcdir/mapm_$pkgver
gcc -c -Wall -O2 -fPIC map*.c || return 1
gcc -shared -o libmapm.so.0 map*.o || return 1
mkdir -p $pkgdir/usr/lib
mkdir -p $pkgdir/usr/include
mkdir -p $pkgdir/usr/share/mapm
cp $srcdir/mapm_$pkgver/libmapm.so.0 $pkgdir/usr/lib
cp $srcdir/mapm_$pkgver/m_apm*.h $pkgdir/usr/include
cp -a $srcdir/mapm_$pkgver/DOCS $pkgdir/usr/share/mapm
install -D -m644 ../../mapm_license.txt $pkgdir/usr/share/licenses/$pkgname/LICENSE || return 1
mapm_license.txt to be included (the source package does not contain any file specially for the license, so it's probably simpler to cut it from the README and put it in a new file?):
MAPM
Version 4.9.5
December 10, 2007
Michael C. Ring
[email protected]
Latest release will be available at
http://tc.umn.edu/~ringx004
* Copyright (C) 1999 - 2007 Michael C. Ring *
* This software is Freeware. *
* Permission to use, copy, and distribute this software and its *
* documentation for any purpose with or without fee is hereby granted, *
* provided that the above copyright notice appear in all copies and *
* that both that copyright notice and this permission notice appear *
* in supporting documentation. *
* Permission to modify the software is granted. Permission to distribute *
* the modified code is granted. Modifications are to be distributed by *
* using the file 'license.txt' as a template to modify the file header. *
* 'license.txt' is available in the official MAPM distribution. *
* To distribute modified source code, insert the file 'license.txt' *
* at the top of all modified source code files and edit accordingly. *
* This software is provided "as is" without express or implied warranty. *
Modified hcg PKGBUILD:
# Contributor: Fabio Comolli <[email protected]>
pkgname=hcg
pkgver=0.4.2
pkgrel=1
pkgdesc="HoubySoft Calculator - a calculator with lot of options and abundant functions"
arch=('i686' 'x86_64')
url="http://hc.houbysoft.com"
license=('GPL3')
depends=('mapm' 'gtk2' 'glib2')
source=("http://houbysoft.com/download/$pkgname-$pkgver-src.tar.gz")
md5sums=('3c06c0d9e4ffb220a30820c733d55d1d')
build() {
cd $srcdir/$pkgname-$pkgver-src
gcc -DHCG `pkg-config gtk+-2.0 gthread-2.0 --cflags` -DHCG_E -c main.c || return 1
gcc -DHCG `pkg-config gtk+-2.0 gthread-2.0 --cflags` -DHCG_E -c utils.c || return 1
gcc -DHCG_E -c hc_functions.c || return 1
gcc -DHCG_E -c hc.c || return 1
gcc `pkg-config gtk+-2.0 gthread-2.0 --cflags --libs` main.o utils.o hc_functions.o hc.o /usr/lib/libmapm.so.0 -o hcg || return 1
mkdir -p $pkgdir/usr/bin
mkdir -p $pkgdir/usr/share/$pkgname
cp $srcdir/$pkgname-$pkgver-src/$pkgname $pkgdir/usr/bin
cp -a $srcdir/$pkgname-$pkgver-src/README $pkgdir/usr/share/$pkgname
cp -a $srcdir/$pkgname-$pkgver-src/LICENSE $pkgdir/usr/share/$pkgname
Modified hc PKGBUILD:
# Contributor: Jan Dlabal <dlabaljan at gmail dot com>
pkgname=hc
pkgver=0.4.2
pkgrel=1
pkgdesc="HoubySoft Calculator - a calculator with lot of options and abundant functions - CLI version"
arch=('i686' 'x86_64')
url="http://hc.houbysoft.com"
license=('GPL3')
depends=('mapm')
source=("http://houbysoft.com/download/$pkgname-$pkgver-src.tar.gz")
md5sums=('2256ea75ecee8bd41a3d1d02bb189945')
build() {
cd $srcdir/$pkgname-$pkgver-src
gcc -c main.c || return 1
gcc -c hc.c || return 1
gcc -c hc_functions.c || return 1
gcc main.o hc_functions.o hc.o /usr/lib/libmapm.so.0 -lm -o hc || return 1
mkdir -p $pkgdir/usr/bin
mkdir -p $pkgdir/usr/share/$pkgname
cp $srcdir/$pkgname-$pkgver-src/$pkgname $pkgdir/usr/bin
cp -a $srcdir/$pkgname-$pkgver-src/README $pkgdir/usr/share/$pkgname
cp -a $srcdir/$pkgname-$pkgver-src/LICENSE $pkgdir/usr/share/$pkgname
Do you think it's ready for upload now?
Regards,
Jan