Problem Executing Macro from Ribbon, Runs fine when called from intermediate, or 'normal' butons

Question

Hi,
I've come across a very strange problem, we've been using some fairly simple macro's within excel for the last few months, I've recently come into a strange problem.
I decided to make things easier by putting commands onto the ribbon and creating an addin, as this code is reused by most of our workbooks, and having thousands of files with this code in seems like an awesome way to fill up our drives :)
Basically the code seems to just ignore the saveas command when run from the ribbon, code runs, ends saying successful, in the debugger stepping over the code it appears to step over the saveas command as appears that it's been excused without fail, however
no file gets created, workbook does not get saved and it keeps its original book<x> caption
here's a quick example of my code, I have a class module registering application commands
the ribbon button i'm using is just a print button, using the application print which then calls this before print function
this is the code that fires from the ribbon, we always print out 2 copies i'm not sure if this can be simplified?
If Application.Workbooks.Count = 0 Then Exit Sub
If CheckRangeExists("BVSID") = 1 Then
ActiveWindow.SelectedSheets.PrintOut Copies:=2, Collate:=True, IgnorePrintAreas:=False
End If
Using CTRL P or File Print this works fine, BeforePrint triggers each time, but within Save Invoice it calls the Application.SaveAs function, when this print is fired from the ribbon this simply seems to get ignored
Private Sub App_WorkbookBeforePrint(ByVal Wb As Workbook, Cancel As Boolean)
'check worksheet belongs to bvs plugin
If CheckRangeExists("BVSID") = 1 Then
'code to save
If SaveInvoice = 0 Then Cancel = True
End If
End Sub
incase there is something weird i'm missing, this is the line that throws up no errrors, simply doesn't work, more annoyingly the SaveInvoice function returns no error, which in turn prints out the document, and its only until after you check for the file
you would realise it didn't save, I've since put a check in to check the file has saved, so far everysingle time it does not save from the ribbon, pressing CTRL P or clicking File Print will always save the file?
ActiveWorkbook.SaveAs Filename:=Path & Range("Invoice").Value & ".xlsx", FileFormat:=xlOpenXMLWorkbook, CreateBackup:=False
before I have Application.DisplayAlerts = False and after Application.DisplayAlerts = True
As the code is within an Addin my probably overly basic idea is to create a hidden range with the name BVSID, with the idea the events only fire with the sheets I've created
Finally, If I type the
ActiveWindow.SelectedSheets.PrintOut Copies:=2, Collate:=True, IgnorePrintAreas:=False
in the debug window the code also runs, triggers the before print and saves the files
any help would be most appreciated :)

Answer 1

Thanks for the time!
it works fine when using the normal print button on the custom ui, its when using a macro combined with
ActiveWindow.SelectedSheets.PrintOut
I've just created a blank workbook, with a class module to capture the before print, I've put 2 buttons on the custom ribbon, one using the default command, and the other to call a macro to reference the printout command
before print gets activated on both tries, however the saveas command gets ignored, seems to run, but not do anything when called using the .PrintOut command.
Here's the code I've used to test
This Workbook code
Private XLApp As CExcelEvents
'set applications to be avaliable in the cexcelevents class module
Private Sub Workbook_Open()
Set XLApp = New CExcelEvents
End Sub
Module for custom button (not actually sure if this needs to be in a module but this is to mimic the same behaviour i'm getting with the addin
Sub PrintInvoice(control As IRibbonControl)
ActiveWindow.SelectedSheets.PrintOut Copies:=2, Collate:=True, IgnorePrintAreas:=False
End Sub
Class Events CExcelEvents
'get application events
Private WithEvents App As Application
Private Sub App_WorkbookBeforePrint(ByVal Wb As Workbook, Cancel As Boolean)
ActiveWorkbook.SaveAs "C:\Test\Book1_Copy.xlsm", XlFileFormat.xlOpenXMLWorkbookMacroEnabled
End Sub
Private Sub Class_Initialize()
Set App = Application
End Sub
Private Sub Class_Terminate()
Set App = Nothing
End Sub
CustomUI Code
<customUI xmlns="http://schemas.microsoft.com/office/2009/07/customui">
<ribbon startFromScratch="false">
<tabs>
<tab id="customTab" label="Custom Tab">
<group id="customGroup" label="Custom Group">
<button idMso="FilePrint" imageMso="FilePrint" size="large"/>
<button id="btnPrint" label="Print" imageMso="FilePrint" size="large" onAction="PrintInvoice" supertip="Saves Invoice Then Prints to Default Printer" enabled="true"/>
</group>
</tab>
</tabs>
</ribbon>
</customUI>
the button id btnprint is what I've been testing with so I copy pasted that button from the customui code I had
I can't see away to add the workbook as an attachment, if needed I can upload it here too, this workbook was just created from scratch just incase its the addin I've got making some weird error