Problem in deep cloning

Question

Hai Friends,
I am trying to use deep cloneing for copying objects and then setting the appropriate values to the properties of copied object. When we make deep clone copy, it is supposed to retain original property values. But in the example I tried, it shows only zeros. The source code and the output is given below. i seek your expertise and my advance thanks for any help to resolve my problem.
* This class extends the class of Javas Point2D.Double
import java.awt.geom.Point2D;
import java.awt.Rectangle;
import java.io.Serializable;
import java.awt.Graphics2D;
import javax.swing.JFrame;
import java.awt.Graphics;
import java.awt.Color;
import java.awt.geom.AffineTransform;
import java.util.ArrayList;
import java.io.Serializable;
import java.io.ObjectInputStream;
import java.io.ByteArrayOutputStream;
import java.io.ObjectOutputStream;
import java.io.ByteArrayInputStream;
import java.lang.ClassNotFoundException;
import java.io.IOException;
public class point2D extends Point2D.Double implements Cloneable, Serializable{
// Properties
     Color drawColor =Color.red;
* Constructor
point2D(){ }
point2D( double xx, double yy){ super(xx,yy); }
public void setLocation( double xx, double yy){
     super.setLocation(xx,yy);}
public void setDrawColor( Color drawColor){
     drawColor = this.drawColor;}
* Draw a rectangle around through point.
public Rectangle getPointRect(){
int width = 4;
return new Rectangle( (int)x-width/2,(int)y-width/2, width, width);
* Check for a given point coinciding with point2D
* location check is true, if it contains the point
public boolean locationCheck( double x, double y){
     return getPointRect().contains((int)x,(int)y);
* Draw method.
public void draw( Graphics2D g2d ){
     g2d.setColor(drawColor);
g2d.fill( getPointRect());
public Object deepClone()
try{
ByteArrayOutputStream b = new ByteArrayOutputStream();
ObjectOutputStream out = new ObjectOutputStream(b);
out.writeObject(this);
out.close();
ByteArrayInputStream bIn = new ByteArrayInputStream(b.toByteArray());
ObjectInputStream oi = new ObjectInputStream(bIn);
oi.close();
return oi.readObject();
catch (IOException e)
{ System.out.println("exception:"+e.getMessage());
e.printStackTrace();
return null;
catch( ClassNotFoundException cnfe){
System.out.println("exception:"+ cnfe.getMessage());
cnfe.printStackTrace();
return null;}          
public static void main( String[] args){
     point2D pp = new point2D();
     pp.setLocation( 100.,150.);
     System.out.println( pp.locationCheck(100.5, 149.5));
System.out.println( pp.getX() + " " + pp.getY());
     point2D ppp = (point2D)pp.deepClone();
System.out.println( ppp.getX() + " " + ppp.getY());
The output:
true
100.0 150.0
0.0 0.0

Answer 1

Hai sztejkat,
I tried with adding methods to save and restore the state of the non-serializable class and it works.
What is the reason to implement deep clone in point2D - this class does not contain any references >except Color, which is an immutable class and can be safely shared by multiple objects. In this case the >shallow copy will work fine. In my opinion the method you have choosen to implement deep copy is one >of the worst possible, looking from performance point of view. Shallow copy makes a new reference but pointing to the same object. My intension of deep copying was to create a new object. However, I fully agree with you that for simple instances of Point2D.Double, it is better to create a new onject using " new" operator than deepcopying.
With best regards,
Chinnaswamy