Problem with step off record

Question

Hi,
Need to Create an Opportunity and step off the record. An error message should be thrown if the Probablity of the Opportunty is 0% and Sales Cycle is blank.
like below I have written the code:
function BusComp_PreWriteRecord ()
var prob;
var stage;
prob=this.GetFieldValue("Primary Revenue Win Probability");
stage=this.GetFieldValue("Sales Stage");
if(prob == '0' && stage == '')
TheApplication.RaiseErrorText("% should not be 0 and sales stage should not be blank");
else if((Revenue == '$0.00')&&(Quality == '5-Poor'||Quality =='4-Fair'))
TheApplication.RaiseErrorText("With this combination of Revenue and Quality values can not be changed");
     return (CancelOperation);
     return (ContinueOperation);
Following error is thowing while stepping of the record:
TypeError 1406:The script refers to a method that either does not exist or has an incorrect syntax.Verify that the method syntax is correct and the object supports the method (SBL-SCR-00141)
can you please direct where went wrong.
Thank You.

Answer 1

First of: use try,catch,finally
http://download.oracle.com/docs/cd/B31104_02/books/eScript/eScript_JSLOverview44.html#wp1004538
In the finally part is where you would release/destroy any object variables that you have created.
Like instances of business components or business objects. Like this:
finally
loAccCUAddrBC = null;
loAccountBO = null;
You should have a naming convention for you variables. With some prefix/postfix.
like
l = local variable
g = global variable (variables declared in the (declaration) part)
use a type prefix
s = string
o = object (those are the ones you should release/destroy in the finally part)
i = integer
some postfix
BC = Business Component
BO = Business Object
e.g. loAccountBO, loAccCUAddrBC, ...
And once again, try as best you can to avoid writing script. It will
slow down the application, make it harder to upgrade, ...
First place to look:
Simple configuration with calculated fields, pre-defaults, ....
User Props on (Business Components, Applets, Integration Obj.)
Work flows
If all that fails, look to scripting.
And when you to, make sure you write your scripts well.
If you need the code more then once, put it into a business service.
And now to your code.
It look like Server Script code and then you need TheApplication().
and not just TheApplication.
try
var lsProb;
var lsStage;
var l?Revenue; // needs type and a get for the value
var l?Quality; // needs type and a get for the value
lsProb = this.GetFieldValue("Primary Revenue Win Probability");
lsStage = this.GetFieldValue("Sales Stage");
if(lsProb == '0' && lsStage == '')
TheApplication().RaiseErrorText("% should not be 0 and sales stage should not be blank");
else if((l?Revenue == '$0.00')&&(l?Quality == '5-Poor'||l?Quality =='4-Fair'))
TheApplication().RaiseErrorText("With this combination of Revenue and Quality values can not be changed");
catch(e)
     throw(e);
finally
return (ContinueOperation);