Still not solved problem

Question

Hello Friends,
I am using 6 tables in my report.i want to display recores by AT NEW and Related stuff.
Can i use following code for query and internal tables ?
or Sujjest me Better code.
to use loop within loop is not good idea.
I want to disply Records
total Document type wise ->year wise -> Month wise -> Sales Order Number wise->Item Numberwise -> Production order numberwise
This is interactive report of 8-9 screens !!
Main problem is to make AT new with different loop !!
Sujjest me with code !!
Points will be rewarded soon !!
Regards,
Nimesh Master
TABLE DECLARATION ************************
TABLES : VBAK,AFPO,AUFM,MAKT,KNA1,VBAP.
INTERNAL TABLE DECLARATION *******************
DATA : BEGIN OF T1 OCCURS 0,
AUART TYPE VBAK-AUART,
NETWR TYPE VBAK-NETWR,
KUNNR TYPE VBAK-KUNNR,
VBELN TYPE VBAK-VBELN,
AUDAT TYPE VBAK-AUDAT,
END OF T1.
DATA : BEGIN OF T2 OCCURS 0,
NETWR TYPE VBAP-NETWR,
POSNR TYPE VBAP-POSNR,
END OF T2.
DATA : BEGIN OF T3 OCCURS 0,
AUFNR TYPE AFPO-AUFNR,
KDPOS TYPE AFPO-KDPOS,
KDAUF TYPE AFPO-KDAUF,
PSMNG TYPE AFPO-PSMNG,
WEMNG TYPE AFPO-WEMNG,
END OF T3.
DATA : BEGIN OF T4 OCCURS 0,
DMBTR TYPE AUFM-DMBTR,
MATNR TYPE AUFM-MATNR,
ELIKZ TYPE AUFM-ELIKZ,
END OF T4.
DATA : BEGIN OF T5 OCCURS 0,
NAME1 TYPE KNA1-NAME1,
END OF T5.
DATA : BEGIN OF T6 OCCURS 0,
MAKTX TYPE MAKT-MAKTX,
END OF T6.
FREE T1.
SELECT VBELN NETWR AUART AUDAT KUNNR FROM VBAK INTO CORRESPONDING FIELDS
OF TABLE T1 WHERE AUART IN AUART AND VBELN IN VBELN.
FREE T2.
SELECT NETWR POSNR FROM VBAP INTO CORRESPONDING FIELDS OF TABLE T2
FOR ALL ENTRIES IN T1 WHERE VBELN = T1-VBELN .
FREE T3.
SELECT AUFNR PSMNG WEMNG KDPOS FROM AFPO INTO CORRESPONDING FIELDS OF
TABLE T3 FOR ALL ENTRIES IN T1 WHERE KDAUF = T1-VBELN .
FREE T4.
SELECT DMBTR MATNR ELIKZ FROM AUFM INTO CORRESPONDING FIELDS OF
TABLE T4 FOR ALL ENTRIES IN T3 WHERE AUFNR = T3-AUFNR.
FREE T6.
SELECT MAKTX FROM MAKT INTO CORRESPONDING FIELDS OF TABLE T6 WHERE
MATNR = T4-MATNR.
FREE T5.
SELECT NAME1 FROM KNA1 INTO CORRESPONDING FIELDS OF TABLE T5 WHERE
KUNNR = T1-KUNNR.
  LOOP AT T1.
    AT NEW VBELN.
     WRITE : / T1-VBELN .
    ENDAT.
   AT NEW AUFNR.
      WRITE : / T1-AUFNR.
   ENDAT.
    AT END OF AUFNR.
      SUM.
      IF T1-PSMNG = T1-WEMNG.
        T1-CLOSE_ORD1 = T1-CLOSE_ORD1 + T1-DMBTR.
      ELSE.
        T1-OPEN_ORD1 = T1-OPEN_ORD1 + T1-DMBTR.
      ENDIF.
      TOT_DMBTR_C = TOT_DMBTR_C + T1-CLOSE_ORD1.
      TOT_DMBTR_O = TOT_DMBTR_O + T1-OPEN_ORD1 .
    ENDAT.
    AT END OF VBELN.
      SUM.
      P =  TOT_DMBTR_C.
      Q =  TOT_DMBTR_O.
      TMP_OC_SALES  = NET_PRICE - P.
        TMP_PER_SALES = ( TMP_OC_SALES * 100 ) / NET_PRICE .
        TMP_TOT_MAT =  P + Q.
        TMP_PER_MAT = ( TMP_TOT_MAT  * 100 ) / NET_PRICE.
        TOT_NET_SALES_A = TOT_NET_SALES_A + NET_PRICE.
        TOT_P_A = TOT_P_A + P.
        TOT_Q_A = TOT_Q_A + Q.
      ENDIF.
      FORMAT COLOR 2 ON.
      WRITE : 20 NET_PRICE,
              50 P,
              65 Q,
              83 TMP_OC_SALES,
              100 TMP_PER_SALES,'%',
              120 TMP_TOT_MAT ,
              139 TMP_PER_MAT,'%'.
      FORMAT COLOR 2 OFF.
    ENDAT.
  ENDLOOP.
1. Tell me is it appropriate to take same number of INTERNAL TABLE as DDIC  
    TABLE ??
2. Wat should be the queries for them ?
3. How i use AT NEW with Different Loop for Internal tables ??

Answer 1

i am gving u the silmilar kind of code where i used 4-5 tables.
1> used for all entries tat will increase the performance
2> use read instead of at
3> use work area
REPORT  ZBH_FI_ALV1 No Standard Page Heading.
TABLES:T001,SKA1,SKB1,BKPF,BSEG.
TYPE-POOLS:slis.
               TYPES DECLARTIONS
TYPES:begin of str_bkpf,
      blart type blart,
      bukrs type bukrs,
      belnr type bseg-belnr,
      gjahr type gjahr,
      budat type budat,
      end of str_bkpf.
TYPES: begin of str_bseg,
       belnr type belnr_d,
       gjahr type gjahr,
       buzei type buzei,
       bschl type bschl,
       hkont type hkont,
       bukrs type bukrs,
       blart type blart,
       budat type bkpf-budat,
       saknr type saknr,
       fstag type fstag,
       ktopl type ktopl,
       bilkt type bilkt,
       end of str_bseg.
TYPES:begin of str_t001,
      bukrs type bukrs,
      ktopl type ktopl,
      end of str_t001.
TYPES:begin of str_ska1,
      bilkt type bilkt,
      ktopl type ktopl,
      saknr type saknr,
      end of str_ska1.
TYPES:begin of str_skb1,
      fstag type fstag,
      bukrs type bukrs,
      saknr type saknr,
      end of str_skb1.
               DATA  DECLARATIONS
DATA:it_bkpf type standard table of str_bkpf  ,
     it_bseg type standard table of  str_bseg ,
     it_t001 type standard  table of str_t001 ,
     it_ska1 type standard  table of str_ska1 ,
     it_skb1 type standard table of str_skb1 ,
    fieldcat type slis_t_fieldcat_alv WITH HEADER LINE,
    events   type slis_t_event WITH HEADER LINE,
    layout  type slis_layout_alv,
    layout type  slis_layout_alv1 ,
    ALV type SY-REPID.
data:w_index type sy-tabix.
data: wa_bkpf like line of it_bkpf,
      wa_bseg like line of it_bseg,
      wa_t001 like line of it_t001,
      wa_ska1 like line of it_ska1,
      wa_skb1 like line of it_skb1.
                 INPUT VARIABLES
SELECT-OPTIONS:s_BUKRS FOR BKPF-BUKRS obligatory,
               s_BLART FOR BKPF-BLART obligatory,
               s_BUDAT FOR BKPF-BUDAT,
               s_BSCHL FOR BSEG-BSCHL,
               s_HKONT FOR BSEG-HKONT.
               SELECT STATEMENTS
START-OF-SELECTION.
  select   blart      "Document type
           bukrs      "Company Code
           belnr      "Accounting Document Number
           gjahr      "Fiscal Year
           budat      "Posting Date in the Document
           from bkpf
           into
           table it_bkpf
           where bukrs in s_bukrs
           and   blart in s_blart
           and budat in s_BUDAT.
check sy-subrc = 0.
  if not it_bkpf[] is initial.
   select belnr "Accounting Document Number
          gjahr "Fiscal Year
          buzei "Number of Line Item Within Accounting Document
          bschl  "Posting Key
          hkont  "General Ledger Account
          bukrs  "Company Code
          from bseg
          into table it_bseg
          for all entries in it_bkpf
          where  belnr = it_bkpf-belnr
          and    gjahr = it_bkpf-gjahr
          and    bukrs = it_bkpf-bukrs.
          endif.
  if not s_BSCHL[] is initial.
    delete it_bseg where not bschl in s_bschl.
  endif.
  if not s_HKONT[] is initial.
    delete it_bseg where not hkont in s_hkont.
  endif.
  if it_bseg[] is not initial.
    sort it_bseg by bukrs gjahr belnr.
    refresh it_t001.
    SELECT bukrs              "Company Code
           ktopl              "Chart of Accounts
           from T001
           into table it_t001
           where bukrs in s_bukrs.
    if not it_t001[] is initial.
      sort it_t001 by bukrs.
      refresh it_ska1.
      SELECT bilkt           "Group Account Number
             ktopl           "Chart of Accounts
             saknr           "G/L account number
             from SKA1
             into table it_ska1
             for all entries in it_t001
             where ktopl = it_t001-ktopl.
      if not it_ska1[] is initial.
        sort it_ska1.
        refresh it_skb1.
        SELECT fstag  "Field status group
               bukrs  "Company code
               saknr  "G/L account number
               from skb1
               into table it_skb1
               for all entries in it_ska1
               where bukrs in s_bukrs and
                       SAKNR = it_ska1-saknr.
      endif.
      endif.
      endif.
  loop at it_bseg into wa_bseg.
    w_index = sy-tabix.
    read table it_bkpf into wa_bkpf with key BUKRS = wa_bseg-bukrs.
    if sy-subrc = 0.
    wa_bseg-blart = wa_bkpf-blart.
    Read Table it_t001 into wa_t001 with key bukrs = wa_bseg-bukrs.
    if sy-subrc = 0.
    wa_bseg-ktopl = wa_t001-ktopl.
    if sy-subrc = 0.
    Read table it_ska1 into wa_ska1 with key ktopl = wa_bseg-ktopl.
    wa_bseg-saknr = wa_ska1-saknr.
    wa_bseg-bilkt = wa_ska1-bilkt.
    if sy-subrc = 0.
    Read Table it_skb1 into wa_skb1 with key bukrs = wa_bseg-bukrs saknr = wa_bseg-hkont.
    wa_bseg-fstag = wa_skb1-fstag.
    modify it_bseg  from wa_bseg index w_index transporting ktopl bilkt saknr fstag blart.
    endif.
    endif.
    endif.
endif.
  endloop.
regards
bhanu
all the  best