When does a method do too much?

so I'm trying to write cleaner and more effective code, but one of the problems i always find myself in is that i never know how large a method should be. obviously its relative to the job it's doing and such, but i was wondering if there was some sort of general rule of thumb i can follow to know when a method is doing too much work (or not enough for that matter)

askhole wrote:
pabs123 wrote:
so I'm trying to write cleaner and more effective code, but one of the problems i always find myself in is that i never know how large a method should be. obviously its relative to the job it's doing and such, but i was wondering if there was some sort of general rule of thumb i can follow to know when a method is doing too much work (or not enough for that matter)Keep it down to just one line, or at the most two.Yes, cram as much complexity into a single line of code to reduce readability, maintainability, etc. Let's make life harder for ourselves because our employer will be impressed by how few lines of code we used at the expense of every important programming principle. Great advice!
Mel

Similar Messages

InDesign crashes when I use the clipboard too much

Wow, this site is truly terrible.
Anyway.
I am experiencing a crash in InDesign when I use the clipboard too much.
I have a habit of hitting "Ctrl + C" more than once, and this appears to trigger a race condition that causes a crash.
It's reproducable but doesn't happen every time.

TomMettam wrote:
Wow, this site is truly terrible.
What's that supposed to mean?
Are you saying you hit Ctrl-C more than once without changing the selection? I don't tend to do that, so I don't know if it's a problem, but I've NEVER had that error using the clipboard in ID. What version of Windows are you running? You seem to have ID CC (dark interface is a clue), but is it 32- or 64-bit?

Last Paragraph line when using full justification stretches too much

One thing that really bothers me is the way that the last line of a paragraph will stretch out over the whole width of a page when you are using full justification, even when the line is only one or two words. This is simply unacceptable from an esthetic point of view. Does Pages 2 fix this annoying behavior—which really makes full justification practically unusable—or is that still broke?

Hullo jzents:
I've run into this too, although only when pagination
occurs: i.e., you go to the next page. Haven't struck
it otherwise, and frankly had barely noticed it until
I changed to Pages 2. However it's still there. I
haven't struck it enough yet to find a workaround -
although you might try inserting your cursor in front
of a paragraph or line break - or checking invisibles
to see if you can spot what's going on when it
happens. Trouble is, before I get to that, the
problem's usually gone. To cheer you up a bit though,
it's a failing of other programs too, and I often
notice it in my local newspaper where it doesn't get
cleaned up at all!
But seriously, it's a bug and needs a fix. Be sure to
report it to Apple.
And if anyone's got a surefire trick for dealing with
it in the meantime, I'll be trying their answer too.
On the other hand, if it were something you could
live with through a method to avoid it - then why
isn't it in the help screens?
Cheers.
You told me what I did not want to know, which is that it is not fixed in Pages 2. It does not happen in some other WP that I have used, so it is very disapointing that Pages fails in this regard. Cheers!

S10e emergency shutdown when screen opened too much?

Type: 4187-5LG
When the screen is tilted too much the computer shuts down, and I have to remove AC power and the battery for 15 seconds before it can be started again.
I know it has a limit of 130 degrees, but the hinges are quite firm and it is not possible to tell when it is at the limit! - I have read the Hardware Maintenance Manual and was unable to find an answer.
Does the S10e have an emergency switch in the hinge, or am I hurting my new little workhorse?
Hans
Message Edited by hpholm on 01-03-2009 01:40 AM
Solved!
Go to Solution.

This sounds like either a brute force issue, or your machine has issues. My friend has an S10 and I can open the screen right to the stops and nothing happens. Note that I'm not pressing real hard, I open it until it won't open anymore and then stop trying to open it more.
If you're sitting it on the floor and doing handstands on the two halves to get it to open more, then that would be the source of your problem.
Since I assume you aren't doing something like that, I'd bet you've got some wiring issue near one of the hinges and something is shorting out somewhere it shouldn't.

HT4101 What does it mean when it says that the USB device requires too much power?

What does it mean when it says that the USB device requires too much power, when using the ipad lightening pin camera connection kit?

Just that. The iPad allocates a certain amount of power to that port. If the device you're trying to plug in wants more than the iPad is willing to give, it'll trigger that warning.
If it's something that you just must hook up you can try using a powered USB hub, but results are mixed at best.
What are you trying to hook to your iPad?

Why does my Macbook pro said "unplug the device using too much power to re-enable USB devices" when i plug in my iphone's charger to connect my phone with the mac?

my iphone 5's charger is not working anymore with the mac or the normal plug in neither, i dont know why. whenever i plug in my mac, i have to twist the charger a little and my mac said "USB Devices Disabled: Unplug the device using too much power to re-enable USB devices". of course it cant connect with the itunes in my mac, but somehow it still syncs the music to my iphone... i don't understand why. please help me thanks!

try resetting the ipad,or change the cable ,it woould work

MBP freezes when doing too much and cmd-tabbing

My MBP sometimes freezes when I am doing a bunch of stuff on my laptop and then I cmd-tab to another application. When I say my laptop freezes, I mean that the system is frozen, keyboard input does not work, but moving the mouse DOES work (even though clicking on anything doesn't do anything.) I have to do a hard reset to get out of this, meaning I press and hold on the power button until the computer shuts down.
Any suggestions as to how I can fix this? I've encountered this numerous times, typically once a week usually. It actually seems like it happens during times when I am cmd-tabbing very rapidly (i.e. when doing web development, I will cmd-tab to my browser, refresh, cmd-tab to my text editor, etc. but how can this freeze my powerful system?! I only typically use about 1.5 GB of the RAM).
Thanks in advance!

If there any pattern to what applications you have open when you get the freezing? You will probably find it's an application rather than the application switcher itself. Also, check your Dashboard widgets. If you are using 3rd party widgets try closing them and see if the problem goes away.
You can also try deleting your Finder preferences by dragging the file…
~/Library/Preferences/com.apple.finder.plist
… to the Trash (don't empty it just yet) and then immediately restarting and see if that makes a difference.

Hi from the last two days my iphone have very slow to open the apps and very slow when i check the notification window , it taking too much time to open when i tap to down . help me to resolve the issue.

Hi, from the last two days my iphone( iphone 4 with ios 5) have very slow to open the apps and very slow when i check the notification window , it taking too much time to open when i tap to down . help me to resolve the issue.

The Basic Troubleshooting Steps are:
Restart... Reset... Restore...
iPhone Reset
http://support.apple.com/kb/ht1430
Try this First... You will Not Lose Any Data...
Turn the Phone Off...
Press and Hold the Sleep/Wake Button and the Home Button at the Same Time...
Wait for the Apple logo to Appear and then Disappear...
Usually takes about 15 - 20 Seconds... ( But can take Longer...)
Release the Buttons...
Turn the Phone On...
If that does not help... See Here:
Backing up, Updating and Restoring
http://support.apple.com/kb/HT1414

On my MacBook Pro with Retina Display, Why does the "USB Devices Disabled Unplug the device using too much power to re-enable USB devices" keep coming up after I unplugged the usb device?

On my MacBook Pro with Retina Display 15", that I purchased a few weeks ago, started coming up with the following message on my desktop:
"USB Devices Disabled Unplug the device using too much power to re-enable USB devices".
I unplugged the device and the message still keeps coming up.
This is what I have done so far to troubleshoot:
I shut down the laptop. When booting up I pressed the command+option+p+r at the same time. It comes up with a menu to reinstall OSX, Get help online, Run Disk Utility, etc. I choose the disk utility and repair the disk and then restarted.
The message keeps popping up and I can't seem to get rid of it. Why does the message keep popping up even though I don't have any devices hooked up to the laptop at all? Any help to reenable my usb ports and get rid of the messaage would be helpful.

I talked to Apple Support and we at least stopped the bleeding, a little bit. These are the troubleshooting steps I did before I contacted Apple Support:
1. Reinstalled OSX
2. Restore the last known good Time Machine Backup.
This did not fix my issue, so I called Apple Support and they told me this:
1. Turn Power off.
2. Wait 15 seconds.
3. Plug in Magsafe adapter.
4. Wait 15 seconds.
5. Hold down the Shift+Option+Power Button for 20-30 seconds.
6. Turn Power back on.
Ok, this stopped the bleeding a little, but as soon as I plugged in a Apple USB Superdrive
and a Apple Mini Displayport to VGA Adapter. This "USB Devices Disabled" pop-up pops up like every 30 minutes now. At least, it is not constantly popping up after I close it, so I guess it will do for the temporary. Going to contact Apple support, later, though to see what else can be done.

I don't want to write too much code is there a different way of doing this

I am writing a precedure to check on the max test scores for different codes ('S01','S02'.S03') --there are more
then I need to insert the table if the record with the best score does not exists for example for b.sortest_tesc_code = 'BSV', I am writing a cursor
for each code (.sortest_tesc_code = 'S01') is there a way to do this different? so I cant do something like a.sortest_tesc_code in ('S01','S02'.S03') and store in a
variable then insert, the problem is that you can have a student that have only one test other that have two etc..etc.. is not consistent, also If the b.sortest_tesc_code = 'BSV') is already in the table I don't do an insert I will have to do an update if the sortest_test_score is greater since the student can submit scores more than once... In another words check if the record exists( b.sortest_tesc_code = 'BSV') if is there compare with the new max score and if the new max score is greater then update.. If the score (by code) is not in the table insert
Hope this is clear, this is what I have, I now it will work but it will be too much code..check for exists and not exists in two different precedures..
Thank you
CURSOR get_the_max_scores_S01_cur IS
            SELECT
             sortest_pidm, a.sortest_test_score, a.sortest_tesc_code,
             a.sortest_test_date,a.sortest_equiv_ind
            FROM
            saturn.spriden, saturn.sortest a, saturn.stvtesc
           WHERE
           a.sortest_pidm = spriden_pidm
          AND stvtesc_code = a.sortest_tesc_code
          AND spriden_change_ind IS NULL
       -----and   a.sortest_tesc_code in ('S01','S02'.S03')
       AND a.sortest_tesc_code = 'S01'
       --and spriden_id = p_student_id --
       ---for test purposes
       AND sortest_pidm = 133999 ----THE WILL BE A PARAMETER
       AND a.sortest_test_score =
              (SELECT MAX (b.sortest_test_score)
                 FROM saturn.sortest b
                WHERE a.sortest_tesc_code = b.sortest_tesc_code
                      AND a.sortest_pidm = b.sortest_pidm)
                            AND NOT EXISTS
              (SELECT 1   FROM    saturn.sortest b
              WHERE    A.sortest_tesc_code = b.sortest_tesc_code
                      AND a.sortest_pidm = b.sortest_pidm
                      and   b.sortest_tesc_code = 'BSV');
     BEGIN
                 UTL_FILE.fclose_all;
                 v_file_handle := UTL_FILE.fopen (v_out_path, v_out_file, 'a');
                UTL_FILE.put_line (v_file_handle,
                      CHR (10) || TO_CHAR (SYSDATE, 'DD-MON-YYYY HH:MI:SS'));
               UTL_FILE.put_line (v_file_handle, 'sortest_best_sct_scorest');
               --check for an open cursor before opening
               IF get_the_max_scores_S01_cur%ISOPEN
                   THEN
                    CLOSE get_the_max_scores_S01_cur;
               END IF;
            OPEN get_the_max_scores_S01_cur;
             LOOP
                   FETCH get_the_max_scores_S01_cur
                   INTO v_pidm, v_tscore, v_testcode,
                           v_test_date, v_equiv_ind;
                   EXIT WHEN get_the_max_scores_S01_cur%NOTFOUND;
               IF get_the_max_scores_S01_cur%FOUND
                THEN
                   INSERT INTO saturn.sortest
                   (sortest_pidm,sortest_tesc_code,sortest_test_date,sortest_test_score,
                    sortest_activity_date,sortest_equiv_ind,sortest_user_id,sortest_data_origin)
                    VALUES
                    v_pidm,
                   'BSV',
                    v_test_date,
                     v_tscore,
                     sysdate,
                    v_equiv_ind,
                    p_user,
                    'best_test_scores process'
               END IF;
               END LOOP;
               COMMIT;
               ---Initialize variables
                v_pidm := NULL;
                v_test_date := NULL;
                v_tscore := NULL;
                v_equiv_ind := NULL;
                v_testcode := NULL;
             CLOSE get_the_max_scores_S01_cur;
----then another do the same for S02...S03

Thank you, here is the code, I change the name of the tables, but it is the same concept.what I need is to extract the max score for each code (s01,s02,s03,s04)
then insert a record with a different code in the same table
BSM     Best Math SAT (S01)
BSW     Best writing SAT (S04)
BSC     Best READING SAT (S03)
BSE     Best READING SAT (S02)
I need to be able to check if the BS codes are already in the table (BSM...BSC..) IF they are not do an insert and if they are do an update get the maximun score
again (the students can submit more than one score form the same code and any date) and if the maximun is different(greater) of what is already in the database (with the BSM...BSC.. codes) do an update, IF NOT if is the same or less don't update...
I need the PERSON table because I need to use the ID as a parameter they (user) can run the process for one ID or all the records in the table TEST
Thank you, I hope is clear
create table TEST
TEST_PIDM                  NUMBER(8)            NOT NULL,
TEST_TESC_CODE        VARCHAR2(4 CHAR)     NOT NULL,
TEST_TEST_DATE        DATE                 NOT NULL,
TEST_TEST_SCORE       VARCHAR2(5 CHAR)     NOT NULL,
TEST_ACTIVITY_DATE    DATE                 NOT NULL,
TEST_EQUIV_IND        VARCHAR2(1 CHAR)     NOT NULL
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'EB' ,TO_DATE( '01-JUN-2004', 'DD-MON-YYYY'),'710',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'M2' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'710',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S01' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'750',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S01' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'720',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S02' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'740',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S02' ,TO_DATE( '05-JUL-2005', 'DD-MON-YYYY'),'730',SYSDATE,'N'
FROM DUAL ;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S03' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'780',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S03' ,TO_DATE( '05-JUL-2005', 'DD-MON-YYYY'),'740',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S04' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'770',SYSDATE,'N'
FROM DUAL;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S04' ,TO_DATE( '05-JUL-2005', 'DD-MON-YYYY'),'740',SYSDATE,'N'
FROM DUAL;
CREATE TABLE PERSON
PERSON_PIDM                NUMBER(8)         NOT NULL,
PERSON_ID                  VARCHAR2(9 CHAR) NOT NULL
INSERT INTO PERSON
( PERSON_PIDM ,   PERSON_ID)
SELECT
128019,'003334556'
FROM DUAL ;
CREATE TABLE VALTSC
VALTSC_CODE             VARCHAR2(4 CHAR)     NOT NULL,
VALTSC_DESC             VARCHAR2(30 CHAR)
INSERT INTO VALTSC
VALTSC_CODE,
VALTSC_DESC
SELECT
'S01' ,
'XXS01'
FROM DUAL;
INSERT INTO VALTSC
VALTSC_CODE,
VALTSC_DESC
SELECT
'S02' ,
'XXS02'
FROM DUAL
INSERT INTO VALTSC
VALTSC_CODE,
VALTSC_DESC
SELECT
'S03' ,
'XXS03'
FROM DUAL;
INSERT INTO VALTSC
VALTSC_CODE,
VALTSC_DESC
SELECT
'S04' ,
'XXS04'
FROM DUAL;

R3load ttaking too much time when table REPOSRC is loaded

Hello,
I am installing the SAP ECC 6.0 SR2 on SUN Solaris 10 on DB2 V9.1. 17 jobs of the 19 have been completed in ABAP Import phase but it is taking too much time while doing this SAPSSEXC. It is running aroung 10 hours. There is no error is giving. So I have canceled the SAP Installation. After that I have started through manual OS command
/sapmnt/<SID>/exe/R3load -dbcodepage 4102 -i /<instdir>/SAPSSEXC.cmd -l /<instdir>/SAPSSEXC.log -stop_on_error -merge_bck
It is also running around 9 hours. I do not why it is happening and when it will be completed.
Can you help me what will check for doing this job fast or can help me how to resolve this issue?
I have checked these SAP notes 454368 and 455195
If i change any DB2 parameter, I have to restart the DB2 Database. What will I do? I can not understand what to do now.
Please help me ASAP.
Thanks
Gautam Poddar

Hello,
running the R3load import step manually you might try to add the option
-loadprocedure fast LOAD
Pay attention to write the LOAD in capital letters!
This will invoke the LOAD-API whenever possible.
This should save some time on "normal" tables without LOB-columns.
For your table REPOSRC that has a BLOB column the LOAD-API will not be taken.
So I am sorry this will not work for your special case.
(Thanks for the hint to Frank-Martin Haas)
Kind regards
Waldemar Gaida
Edited by: Waldemar Gaida on Jan 10, 2008 8:26 AM

Error cannot use device the connected USB device requires too much power this error appeared when I added my camera

Error appeared when I connected my camera to iPad I used a camera connection device error cannot use device t he connected USB device requires too much power
Thanking you
Wendy Banks

Some cameras are designed to use the power suppled via USB when they're plugged into another device, usually a PC or laptop. The iPad does not supply sufficient power for a camera. The iPad Camera kit allows for either a camera to be plugged in only for the transfer of photos, not as a power sourse, or the removal of the SD Card from a camera so it can transfer photos as an alternative.

When I connect my camera to my iPad I get a requires too much power error message

I keep getting a "usb device requires too much power" error when I connect my external camera to my iPad.

Doing a search on here it looks like other people have the same problem with Sony cybershot cameras. If you have a card reader which doesn't draw too much power then you could try using that with the USB part of the kit.

HT4106 I got the USB camera adapter but when I connect it with my ipad mini and my Samsung camera pl120 it appears on my ipad that is too much power.....I don't know what to do????

I got the USB camera adapter for the ipad mini but when I connect it with my Samsung camera pl120, it appears that's too much power on my ipad mini..,,,so I don't know what to do??????

If you have the card reader part of the camera kit and your camera uses SD cards, try doing it that way. It is the least troublesome way.
BUt if that doesn't work, then it may be a setting on your camera. Your camera may be trying to pull power from the iPad for you to download, and the iPad won't put out that much, triggering the error. If you have a power supply for your camera you can try using that. If not, maybe something in here can help you
http://support.apple.com/kb/HT4101
you might also check on Samsung's site. See if they have any advice specific to iPads that can help.

Why does Firefox keep telling me that it is using too much memory, (eg: 235MB) and I should restart Firefox?

Lately Firefox has been popping up a warning while I am on the internet saying, that "Firefox" is using too much memory. It suggests shutting down Firefox and restarting Firefox. It also told me how much memory that is in use at that time. It is usually about 235MB or more. What is normal memory use for Firefox to use while I am on the internet? Does high usage mean that some other person is trying to get into my computer?

You appear to have AVG installed:
*See --> http://forums.avg.com/ww-en/avg-forums?sec=thread&act=show&id=173969#post_173969
From reading on the internet, it appears that when there is a spike in memory usage, AVG "interprets" that as a memory leak, possibly caused by malware. AVG could be incorrect concerning that assumption. Maybe they are being a bit too conservative about memory usage; just my opinion.
The decision is yours to turn off the "advisor" or leave it on.
'''If this reply solves your problem, please click "Solved It" next to this reply when <u>signed-in</u> to the forum.'''
Not related to your question, but...
You may need to update some plug-ins. Check your plug-ins and update as necessary:
*Plug-in check --> http://www.mozilla.org/en-US/plugincheck/
*Adobe Shockwave for Director Netscape plug-in: [https://support.mozilla.com/en-US/kb/Using%20the%20Shockwave%20plugin%20with%20Firefox#w_installing-shockwave Installing ('''''or Updating''''') the Shockwave plugin with Firefox]
*'''''Adobe PDF Plug-In For Firefox and Netscape''''': [https://support.mozilla.com/en-US/kb/Using%20the%20Adobe%20Reader%20plugin%20with%20Firefox#w_installing-and-updating-adobe-reader Installing/Updating Adobe Reader in Firefox]
*Shockwave Flash (Adobe Flash or Flash): [https://support.mozilla.com/en-US/kb/Managing%20the%20Flash%20plugin#w_updating-flash Updating Flash in Firefox]
*'''''Next Generation Java Plug-in for Mozilla browsers''''': [https://support.mozilla.com/en-US/kb/Using%20the%20Java%20plugin%20with%20Firefox#w_installing-or-updating-java Installing or Updating Java in Firefox]

When does a method do too much?

Similar Messages

Maybe you are looking for