Win32 - timer class error

Question

heres my timer class:
class Timer
private:
UINT_PTR timerid=0;
unsigned int intInterval=0;
HWND timerwindow=NULL;
void TimerProc(HWND hwnd,UINT uMsg,UINT idEvent,DWORD dwTime)
timerprocedure();
static void CALLBACK _TimerProc(HWND hwnd,UINT uMsg,UINT idEvent,DWORD dwTime )
reinterpret_cast<Timer*>(idEvent)->TimerProc(hwnd,uMsg,idEvent,dwTime);
public:
std::function<void()> timerprocedure=NULL;
property<unsigned int> Interval
Get(unsigned int)
return intInterval;
Set(unsigned int uintInterval)
intInterval = uintInterval;
if (intInterval==0 && timerid!=0)
KillTimer(timerwindow,timerid);
void Start()
if(timerid!=0)
KillTimer(timerwindow,timerid);
timerwindow=GetForegroundWindow();
timerid=SetTimer( timerwindow,reinterpret_cast<UINT_PTR>(this),(UINT)intInterval,&Timer::_TimerProc);
SetWindowText(timerwindow,to_string(GetLastError()).c_str());
void Stop()
KillTimer(timerwindow,timerid);
timerid=0;
~Timer()
KillTimer(timerwindow,timerid);
yesterday was working. and i was seen 1 bug, stoped sometimes when the window loses the focus.
but now the GetLastError() give 6: invalid handle.
these don't makes sence to me :(
is there another timer that don't need the HWND?(for avoid future problems)

Answer 1

On 2/15/2015 1:29 PM, Cambalinho wrote:
i had created them on window procedure.
What is "them"? Created how? What do you mean by "on window procedure".
  and that timer class is another timer. what i mean is the timer
WM_TIMER and my timer class aren't created
The only SetTimer call in the code you've shown is the one you admit is failing. To the extent a problem exists, it must be in the code you haven't shown. Lacking mind-reading abilities, I'm afraid I'm unable to assist you any further.
so maybe the message loop is crazy :(
Looks OK to me. Well, it may call IsDialogMessage with a NULL handle, but I believe this should cause IsDialogMessage to return FALSE and then the normal message dispatch takes place. Just to be sure, you may want to make it
[code]
if (!FormActivated || !IsDialogMessage(FormActivated, &msgEvents))
[code]
Igor Tandetnik
my problem is: no timer is executed :(
 and i don't understand why. only the handle been invalid :(
see my form\window window procedure:
void setParent(HWND parent=GetDesktopWindow())
if (hwnd==NULL)
WNDCLASSEX FormClass;
char classname[20]="Form";
sprintf(classname,"%s",strCaption.c_str());
HINSTANCE mod = (HINSTANCE)GetModuleHandle(NULL);
FormClass.cbSize = sizeof(WNDCLASSEX);
FormClass.style = CS_HREDRAW | CS_VREDRAW;
FormClass.lpfnWndProc = WndProcForm;
FormClass.cbClsExtra = 0;
FormClass.cbWndExtra = 0;
FormClass.hInstance = mod;
FormClass.hIcon = LoadIcon(NULL, IDI_APPLICATION);
FormClass.hCursor = LoadCursor(NULL, IDC_ARROW);
FormClass.hbrBackground = (HBRUSH)((COLOR_WINDOW)+1);
FormClass.lpszMenuName = NULL;
FormClass.lpszClassName = classname;
FormClass.hIconSm = LoadIcon(NULL, IDI_APPLICATION);
// register the new window class
RegisterClassEx(&FormClass);
hwnd = CreateWindowEx(WS_EX_CLIENTEDGE, classname, strCaption.c_str(),WS_OVERLAPPEDWINDOW | WS_TABSTOP,
CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, parent, NULL, mod, this);
if (hwnd == NULL)
MessageBox(NULL, "Can't create the control", "error", MB_OK);
else
SetParent(hwnd,parent);
ShowWindow(hwnd, SW_NORMAL);
InvalidateRect(hwnd,NULL,true);//i add these line for fix that
UpdateWindow(hwnd);
clrBackColor =GetDCBrushColor(GetDC(hwnd));
clrTextColor = GetTextColor(GetDC(hwnd));
//window procedure:
static LRESULT CALLBACK WndProcForm(HWND HandleWindow, UINT msg, WPARAM wParam, LPARAM lParam)
static POINT PreviousLocation, Location;
static bool Tracking = false;
static MouseButtons MBButtons;
static bool blControl = false;
static bool blShift = false;
static bool blResize = false;
static int KeyDownCount=0;
static int keyboard[256];
static int xPos = 0;
static int yPos = 0;
static UINT_PTR timerid=0;
static UINT_PTR KeyBoardTimer=2;
static UINT_PTR JoystickTimer=1;
static bool blnDrag = false;
static bool KeyPressed=false;
static HMENU menuhandle=NULL;
HDC hdcimage = CreateCompatibleDC(NULL);
HBITMAP hbitmap=NULL;
//UINT JoystickCount =0;
form *inst = (form *)GetWindowLongPtr(HandleWindow, GWLP_USERDATA);
if(inst!=NULL && inst->Create!=NULL )
static bool i=true;
if(i==true)
i=false;
RECT a;
GetWindowRect(inst ->hwnd,&a);
inst -> Create(a.left, a.top);
//Working with messages
switch(msg)
case WM_NCCREATE:
CREATESTRUCT *p = (CREATESTRUCT *)lParam;
inst = (form *)p->lpCreateParams;
SetWindowLongPtr(HandleWindow, GWLP_USERDATA, (LONG_PTR)inst);
inst->hwnd = HandleWindow;
break;
case WM_ACTIVATE:
if (wParam==WA_INACTIVE) // becoming inactive
FormActivated = NULL;
else // becoming active
FormActivated = inst->hwnd;
return 0;
break;
case WM_DRAWITEM:
DRAWITEMSTRUCT *test=(DRAWITEMSTRUCT*) lParam;
SendMessage(test->hwndItem, WM_DRAWITEM, wParam, lParam);
break;
case WM_USER + 1:
if(lParam==WM_RBUTTONUP)
POINT pCursor;
GetCursorPos(&pCursor);
HMENU test=GetSubMenu(GetMenu(HandleWindow),0);
SetForegroundWindow(HandleWindow);
TrackPopupMenu(test, TPM_LEFTBUTTON | TPM_RIGHTALIGN, pCursor.x, pCursor.y, 0, HandleWindow, NULL);
PostMessage(HandleWindow, WM_NULL, 0, 0);
break;
case WM_ERASEBKGND:
return DefWindowProc(HandleWindow, msg, wParam, lParam);
break;
case WM_CTLCOLORSTATIC:
return DefWindowProc(HandleWindow, msg, wParam, lParam);
break;
case WM_CREATE:
if(WindowMain == NULL || WindowMain ==GetDesktopWindow())
WindowMain = HandleWindow;
SetTimer(inst->hwnd,JoystickTimer,150,NULL);
SetTimer(inst->hwnd,KeyBoardTimer,150,NULL);
SendMessage((HWND)lParam , WM_CREATE, wParam, lParam);
break;
case WM_SIZE:
RECT a;
GetWindowRect(inst->hwnd,&a);
InvalidateRect(inst->hwnd, &a,true);
inst->Resize();
break;
//for get the menu click event
//i'm using menu notifications
case WM_MENUCOMMAND:
MENUITEMINFO menuInfo;
menuInfo.cbSize = sizeof(MENUITEMINFO);
menuInfo.fMask=MIIM_DATA;
if(GetMenuItemInfo((HMENU)lParam,(UINT) wParam, TRUE, &menuInfo )!=0)
Menu *mMenu = (Menu *) menuInfo.dwItemData;
if(mMenu!=NULL)
mMenu->Click();
menuhandle=NULL;
break;
case WM_TIMER:
if (wParam == timerid)//for mouse stoped and it's working normaly
PreviousLocation = Location;
GetCursorPos(&Location);
if ((Location.x == PreviousLocation.x) && (Location.y == PreviousLocation.y))
KillTimer(inst->hwnd, timerid);
inst->MouseStoped();
else if(wParam==KeyBoardTimer)
static bool KeyDown=false;
static int RepeatKeyDown;
int key[256];
GetKeyBoardKeyState(key);
static int key2[256];
if(key[AnyKey]==1 && KeyDown==false)
KeyDown=true;
RepeatKeyDown++;
GetKeyBoardKeyState(key2);
inst->SysKeyDown(key,RepeatKeyDown);
else if(key[AnyKey]==0 && KeyDown==true)
KeyDown=false;
inst->SysKeyUp(key2,RepeatKeyDown);
RepeatKeyDown=0;
else if(wParam==JoystickTimer)
JOYINFOEX b;
b.dwSize=sizeof(JOYINFOEX );
b.dwFlags=JOY_RETURNALL;
//cicle all possible joysticks
for (int i=0; i<16; i++)
int direction=0;
if(joyGetPosEx(i,&b)!= JOYERR_NOERROR) //if theres any error then continue to next joystick
if(i==0)
inst->Joystick(-1, -1,-1);
else
inst->Joystick(0, -1,-1);
break;
long h =b.dwButtons;
//testing the directions
//will be 8 directions(inclued diagonals)
if (b.dwXpos == 0 && b.dwYpos ==65535)
direction=5;
else if (b.dwXpos == 65535 && b.dwYpos ==0)
direction=6;
else if (b.dwXpos == 65535 && b.dwYpos ==65535)
direction=7;
else if(b.dwXpos == 0 && b.dwYpos ==65535)
direction=8;
else if (b.dwXpos == 0)
direction=1;
else if (b.dwXpos == 65535)
direction=2;
else if (b.dwYpos == 0)
direction=3;
else if (b.dwYpos == 65535)
direction=4;
inst->Joystick(i, direction,h);
break;
these don't make sence to me :(