Action putValue problem.

Question

I'm sure I'm missing something fundamental here but the below code alters the name as it should but the tooltip text isn't changing.
if(showXML){   
     toggleListDisplay.putValue(NAME, "Hide XML");     
     toggleListDisplay.putValue(SHORT_DESCRIPTION, "Hide XML in dialogs and tooltips");
}else{
     toggleListDisplay.putValue(NAME, "Show XML");     
     toggleListDisplay.putValue(SHORT_DESCRIPTION, "Show XML in dialogs and tooltips");
}Can anyone see what I can't?

Answer 1

Did some more investigating.
In the AbstractButton class the createActionPropertyChangeListener() method creates a class containing the following code:
    if (e.getPropertyName().equals(Action.NAME)) {
     Boolean hide = (Boolean)button.getClientProperty("hideActionText");
     if (hide == null || hide == Boolean.FALSE) {
         String text = (String) e.getNewValue();
         button.setText(text);
         button.repaint();
    } else if (e.getPropertyName().equals(Action.SHORT_DESCRIPTION)) {
     String text = (String) e.getNewValue();
     button.setToolTipText(text);
    } else if (propertyName.equals("enabled")) {
     Boolean enabledState = (Boolean) e.getNewValue();
     button.setEnabled(enabledState.booleanValue());
     button.repaint();
    } else if (e.getPropertyName().equals(Action.SMALL_ICON)) {
     Icon icon = (Icon) e.getNewValue();
     button.setIcon(icon);
     button.invalidate();
     button.repaint();
    } else if (e.getPropertyName().equals(Action.MNEMONIC_KEY)) {
     Integer mn = (Integer) e.getNewValue();
     button.setMnemonic(mn.intValue());
     button.invalidate();
     button.repaint();
    } else if (e.getPropertyName().equals(Action.ACTION_COMMAND_KEY)) {
                      button.setActionCommand((String)e.getNewValue());
                  }For some reason JMenuItem overrides this method and the code looks like this:
    if (e.getPropertyName().equals(Action.NAME)) {
     String text = (String) e.getNewValue();
     mi.setText(text);
     mi.repaint();
    } else if (propertyName.equals("enabled")) {
     Boolean enabledState = (Boolean) e.getNewValue();
     mi.setEnabled(enabledState.booleanValue());
     mi.repaint();
    } else if (e.getPropertyName().equals(Action.SMALL_ICON)) {
     Icon icon = (Icon) e.getNewValue();
     mi.setIcon(icon);
     mi.invalidate();
     mi.repaint();
    } else if (e.getPropertyName().equals(Action.MNEMONIC_KEY)) {
     Integer mn = (Integer) e.getNewValue();
     mi.setMnemonic(mn.intValue());
     mi.invalidate();
     mi.repaint();
    }Note, the SHORT_DESCRIPTION property isn't handled, which would explain why the tool tip doesn't change for menu items.