Confused.

Question

I'm having a problem with my vector of train cars...
RailCar = Base Class > Boxcar > PassengerCar (Derived classes)
I Initialize the train here:
public void readInput()
          Scanner keyboard = new Scanner(System.in);
          System.out.println("Enter train number: ");
          number = keyboard.nextInt();
          System.out.println("Enter the train's starting location: ");
          location = keyboard.nextInt();
          System.out.println("Enter the train's speed(mph): ");
          speed = keyboard.nextInt();
          int newCars;
          System.out.println("Enter how many cars to add to the train: ");
          newCars = keyboard.nextInt();
          carList = new Vector<RailCar>(newCars+2);
          engine = new RailCar(1, "Engine");
          carList.add(engine);
          caboose = new RailCar(10, "Caboose");
          for(int i = 0; i < newCars; i++)
               int choice;
               System.out.println("Enter the type of car to be added to the train:");
               System.out.println("1 - Boxcar");
               System.out.println("2 - Passenger Car");
               System.out.println("Selection: ");
               choice = keyboard.nextInt();
               switch(choice)
               case 1:
                    BoxCar b = new BoxCar();
                    b.readInput();
                    carList.add(b);
                    break;
               case 2:
                    PassengerCar p = new PassengerCar();
                    p.readInput();
                    carList.add(new PassengerCar());
                    break;
          carList.addElement(caboose);
     }So, once my train is created I want to eventually remove "BoxCars" from the vector.
Here is my method for that:
public void removeBoxCars(String atStation)
          for(RailCar a : carList)
               if(a instanceof BoxCar)
               if(atStation == ((BoxCar)a).getDropOffStation())
                    System.out.println("Removing Boxcar.");
//code for removing element//
     }Though...when I call it, it seems that the program runs right through the method and does not acknowledge the "Drop off Station" in each of the BoxCar classes in the vector. If I were to set it manually in the constructor there's no problem....
Code for "readinput":
public void readInput()
          super.readInput();
          Scanner keyboard = new Scanner(System.in);
          System.out.println("Enter the contents of the boxcar: ");
          contents = keyboard.next();
          System.out.println("Enter the drop off station of the boxcar: ");
          dropOffStation = keyboard.next();
     }Any ideas ?

Answer 1

You are comparing String references, because you used "==". You need to compare the values of the Strings using ".equals":
if(atStation.equals(((BoxCar)a).getDropOffStation()))