DIAPI posting Delivery Document with Serial Numbers SP1

Question

Release 2005A, SP1 PL4 seems to have broken code that worked with SP00.  When trying to create a Delivery Document that contains Serial Numbers, an error is generated: Error -1, General Error.  When adding a delievery document which does not contain serial numbers, the document adds successfully.
The following code loops through a recordset to create documents, add expenses and add serial numbers when appropriate.  Is this a new 'feature' or can we make a coding change to eliminate this error?
Sample code:
    Try
      oSalesOrder = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.oOrders)
      RecSet = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.BoRecordset)
      RecSet2 = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.BoRecordset)
      RecSet3 = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.BoRecordset)
      RecSet4 = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.BoRecordset)
      RecSet5 = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.BoRecordset)
      RecSet6 = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.BoRecordset)
      '-- Select Documents to process and loop through recordset
      lsSQL = "SELECT DocEntry FROM DeliveryTable WHERE ProcessResult IS NULL Group by DocEntry"
      RecSet.DoQuery(lsSQL)
      While Not RecSet.EoF
        oSalesOrder.GetByKey(RecSet.Fields.Item(0).Value)
        If bDocuments(piCompany).DelDraft = False Then
          oDelivery = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.oDeliveryNotes)
        Else
          oDelivery = oCompany(piCompany).GetBusinessObject(SAPbobsCOM.BoObjectTypes.oDrafts)
        End If
        oDelivery.CardCode = oSalesOrder.CardCode
        oDelivery.Comments = "Based On Sales Order " & oSalesOrder.DocNum & "."
        oDelivery.DocDate = Today
        oDelivery.ContactPersonCode = oSalesOrder.ContactPersonCode
        oDelivery.DocCurrency = oSalesOrder.DocCurrency
        oDelivery.DocDueDate = Today
        If bDocuments(piCompany).DelDraft = True Then
          oDelivery.DocObjectCode = SAPbobsCOM.BoObjectTypes.oDeliveryNotes
        End If
        '-- Handle Expenses for Document
        Dim ExpenseLoop As Integer
        Dim ExpenseCount As Integer = 0
        For ExpenseLoop = oSalesOrder.Expenses.Count - 1 To 0 Step -1
        ExpenseCount += 1
          '-- Create new Expense if needed
          If ExpenseCount > oDelivery.Expenses.Count Then
            oDelivery.Expenses.Add()
          End If
          oSalesOrder.Expenses.SetCurrentLine(ExpenseLoop)
          '-- Copy all non-readonly properties
          If oSalesOrder.Expenses.LineTotal > 0 Then
            oDelivery.Expenses.BaseDocEntry = oSalesOrder.Expenses.BaseDocEntry
            oDelivery.Expenses.BaseDocLine = oSalesOrder.Expenses.BaseDocLine
            oDelivery.Expenses.BaseDocType = oSalesOrder.Expenses.BaseDocType
            oDelivery.Expenses.DeductibleTaxSum = oSalesOrder.Expenses.DeductibleTaxSum
            oDelivery.Expenses.DistributionMethod = oSalesOrder.Expenses.DistributionMethod
            oDelivery.Expenses.ExpenseCode = oSalesOrder.Expenses.ExpenseCode
            oDelivery.Expenses.LineTotal = oSalesOrder.Expenses.LineTotal
            oDelivery.Expenses.Remarks = oSalesOrder.Expenses.Remarks
            oDelivery.Expenses.TaxCode = oSalesOrder.Expenses.TaxCode
            oDelivery.Expenses.VatGroup = oSalesOrder.Expenses.VatGroup
          End If
        Next ExpenseLoop
        Dim i As Integer = 0
        Dim liMinRef As Integer = -1
        For x = 0 To oSalesOrder.Lines.Count - 1
          lsSQL = "SELECT ISNULL(MIN(CAST(LineRef as int)),999999) as MinLineRef FROM DeliveryTable WHERE DocEntry = " & RecSet.Fields.Item(0).Value & " AND CAST(LineRef as int) > " & liMinRef
          RecSet5.DoQuery(lsSQL)
          If Not RecSet5.EoF Then
            '-- It's possible that the DeliveryTable has less records then the RDR1 table - if that's the case
            '-- we may be at the end, so set the liMinRef field to something out of range
            liMinRef = RecSet5.Fields.Item(0).Value
          End If
          '-- get line items for each document
          lsSQL = "Select * from DeliveryTable WHERE DocEntry = " & RecSet.Fields.Item(0).Value & " AND LineRef = " & x & " AND ProcessResult IS Null"
          RecSet2.DoQuery(lsSQL)
          RecSet2.MoveFirst()
          While Not RecSet2.EoF
            '-- We need to walk through the SO to find the item that we are receiving based on the LineNum
            Dim liCurrentLine As Integer = x
            Dim lbFound As Boolean = False
            While liCurrentLine <= (oSalesOrder.Lines.Count - 1)
              '-- We need to get the PO Line number (x is NOT the LineRef)
              oSalesOrder.Lines.SetCurrentLine(liCurrentLine)
              If oSalesOrder.Lines.LineNum = liMinRef Then
                lbFound = True
                Exit While
              End If
              liCurrentLine += 1
            End While
            If lbFound Then
              i += 1
              If i > oDelivery.Lines.Count Then
                oDelivery.Lines.Add()
              End If
              oDelivery.Lines.BaseEntry = oSalesOrder.DocEntry
              oDelivery.Lines.Quantity = RecSet2.Fields.Item(6).Value
              oDelivery.Lines.BaseType = SAPbobsCOM.BoObjectTypes.oOrders
              oDelivery.Lines.LineTotal = oSalesOrder.Lines.LineTotal * (oDelivery.Lines.Quantity / oSalesOrder.Lines.Quantity)
              oDelivery.Lines.UserFields.Fields.Item("U_WhseLoc").Value = RecSet2.Fields.Item(8).Value
              oDelivery.Lines.AccountCode = oSalesOrder.Lines.AccountCode
              oDelivery.Lines.Address = oSalesOrder.Lines.Address
              oDelivery.Lines.Currency = oSalesOrder.Lines.Currency
              oDelivery.Lines.ItemCode = oSalesOrder.Lines.ItemCode
              oDelivery.Lines.BaseLine = liMinRef
              oDelivery.Lines.ItemDescription = oSalesOrder.Lines.ItemDescription
              oDelivery.Lines.WarehouseCode = oSalesOrder.Lines.WarehouseCode
              lsUserID = RecSet2.Fields.Item("UserID").Value
              '-- manage serial numbers
              j = -1
              lsSQL = "Select * from DeliverySerial WHERE DocEntry = " & oDelivery.Lines.BaseEntry & " AND LineRef = " & liMinRef
              lsSQL += " AND WIPLineRef = " & RecSet2.Fields.Item("WIPLineRef").Value
              RecSet3.DoQuery(lsSQL)
              While Not RecSet3.EoF
                '-- get the next SystemSerialNumber for the Inventory Item
                lsSQL = "EXEC " & gsDB(piCompany) & "xspGetSysSerial " & sparm(oDelivery.Lines.ItemCode) & ", " & sparm(RecSet3.Fields.Item("LotNo").Value)
                lsSQL += ", " & sparm(RecSet3.Fields.Item("ManSerNo").Value) & ", " & sparm(RecSet3.Fields.Item("IntSerNo").Value)
                lsSQL += ", " & RecSet3.Fields.Item("QTY").Value & ", " & sparm(oDelivery.Lines.WarehouseCode) & ", " & sparm(RecSet2.Fields.Item(8).Value)
                RecSet4.DoQuery(lsSQL)
                  j += 1
                  If j + 1 > oDelivery.Lines.SerialNumbers.Count Then
                    oDelivery.Lines.SerialNumbers.Add()
                  End If
                  oDelivery.Lines.SerialNumbers.SetCurrentLine(j)
                  oDelivery.Lines.SerialNumbers.BatchID = RecSet3.Fields.Item("LotNo").Value
                  oDelivery.Lines.SerialNumbers.ManufacturerSerialNumber = RecSet3.Fields.Item("ManSerNo").Value
                  oDelivery.Lines.SerialNumbers.InternalSerialNumber = RecSet3.Fields.Item("IntSerNo").Value
                  oDelivery.Lines.SerialNumbers.SystemSerialNumber = RecSet4.Fields.Item(0).Value
                  oDelivery.Lines.SerialNumbers.BaseLineNumber = oDelivery.Lines.BaseLine
                RecSet3.MoveNext()
              End While
              '-- 'end manage serial numbers
            End If
            RecSet2.MoveNext()
          End While
        Next x
        '-- now add object to SAP
        If 0 <> oDelivery.Add() Then
          Dim liError As Long
          Dim lsError As String
          Call oCompany(piCompany).GetLastError(liError, lsError)
          '-- write error code to table - Delivery document creation was unsuccessful
          lsSQL = "Update DeliveryTable SET ProcessResult = " & liError & ", ProcessDate = GetDate() WHERE DocEntry = " & oSalesOrder.DocEntry & " AND ProcessResult Is Null"
          RecSet2.DoQuery(lsSQL)
          lsuWriteEvent("AR Delivery", bDocuments(piCompany).DelDraft, oSalesOrder.DocEntry, liError, lsError, piCompany)
        Else
          lsuWriteEvent("AR Delivery", bDocuments(piCompany).DelDraft, oSalesOrder.DocEntry, 0, "Success", piCompany)
        End If
        RecSet.MoveNext()
      End While
    Catch
      LogErrorMessage(Err.Description)
    Finally
      If Not RecSet Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(RecSet)
      End If
      If Not RecSet2 Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(RecSet2)
      End If
      If Not RecSet3 Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(RecSet3)
      End If
      If Not RecSet4 Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(RecSet4)
      End If
      If Not RecSet5 Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(RecSet5)
      End If
      If Not RecSet6 Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(RecSet6)
      End If
      If Not oSalesOrder Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(oSalesOrder)
      End If
      If Not oDelivery Is Nothing Then
        System.Runtime.InteropServices.Marshal.ReleaseComObject(oDelivery)
      End If
      GC.WaitForPendingFinalizers()
    End Try

Answer 1

We have narrowed down the issue to this:
If you are just adding a delivery document with serial numbers, the DIAPI works OK.  If you are adding a delivery document which is based upon a sales order and add the 3 lines that reference it:
oDelivery.Lines.BaseEntry = oSalesOrder.DocEntry
oDelivery.Lines.BaseType = SAPbobsCOM.BoObjectTypes.oOrders
oDelivery.Lines.BaseLine = liMinRef
then you receive a error of -1, General error.  This is functionality that did work in 2004 and 2005 SP00.  I believe this is a bug.