Help with PL/SQL returning SQL query for Report

Question

Hi
I have got a report which I have formatted as PL/SQL function body returning SQL query.
I have the following code
declare
q VARCHAR2(32000); -- query
w VARCHAR2(4000) ; -- where clause
begin
q := 'select min(identified_date) first_identified,' ||
' max(actual_resolution_date) last_closed,' ||
' count("HELPDESK_CALL_ID) total_issues,' ||
' from tbl_helpdesk_calls';
if :P9_call_type != '-1' then
w := 'HELPDESK_CALL_TYPE_ID = :P9_call_type';
end if;
q := q || ' WHERE '|| w;
return q;
end;
When I apply changes I get this error message
Query cannot be parsed within the Builder. If you believe your query is syntactically correct, check the ''generic columns'' checkbox below the region source to proceed without parsing. ORA-00972: identifier is too long
Any Idea where I maybe going wrong?

Answer 1

thanks its compiling now but when I run the page I get this error message in the reports region
failed to parse SQL query:
ORA-00933: SQL command not properly ended
This is my code that I have at the momment.
declare
q VARCHAR2(32000); -- query
w VARCHAR2(4000) ; -- where clause
we VARCHAR2(1) := 'N'; -- identifies if where clause exists
begin
q := 'select min(identified_date) first_identified,' ||
' max(actual_resolution_date) last_closed,' ||
' count(HELPDESK_CALL_ID) total_issues,' ||
' sum(decode(status,''Open'',1,0)) open_issues, ' ||
' sum(decode(status,''On-Hold'',1,0)) onhold_issues,' ||
' sum(decode(status,''Closed'',1,0)) closed_issues,' ||
' sum(decode(status,''Open'',decode
(priority,''High'',1,0),0)) open_high_prior,' ||
' sum(decode(status,''Open'',decode
(priority,''Medium'',1,0),0)) open_medium_prior, '||
' sum(decode(status,''Open'',decode
(priority,''Low'',1,0),0)) open_low_prior '||
' from tbl_helpdesk_calls';
if :P9_call_type != '-1' then
w := 'where HELPDESK_CALL_TYPE_ID = :P9_call_type';
we := 'Y';
end if;
if we = 'Y' then
q := q ||w;
end if;
return q;
end;
I have a select list with a list of reports. what I am trying to do build an sql depending on what the :p9_call_type value is. -1 represents the display value of -All Reports- so if the user selects all reports it should display all results thus removing the where clause. However as my code stands when I user clicks on all reports he get the correct results for all reports. If the user selects anything else they get the error message above.