How to make my Execute Immediate statement to work??

Question

Hi, Sir:
I use SQL Oracle 9i,
I have following procedure called by a trigger:
CREATE OR REPLACE PROCEDURE emps_check IS
s_sql VARCHAR2(500);
BEGIN
DBMS_OUTPUT.PUT_LINE('1. Start to Delete all rows in the emps' );
delete from emps;
DBMS_OUTPUT.PUT_LINE('2. Start to insert into emps from emp' );
s_sql:='INSERT INTO Emps(EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO) select EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO from emp;';
DBMS_OUTPUT.PUT_LINE('3. s_sql= ' || s_sql );
EXECUTE IMMEDIATE s_sql;
DBMS_OUTPUT.PUT_LINE('3. Procedure call OK, Employ Name ' );
EXCEPTION
-- Use this to trap the ORA-00942: table or view does not exist
WHEN OTHERS THEN
DBMS_OUTPUT.PUT_LINE('Procedure call Exception: Employ Name ' );
end emps_check;
My trigger is:
CREATE OR REPLACE TRIGGER emps_biu_after
after INSERT OR UPDATE or delete on emp
for each row
begin
if TO_CHAR(SYSDate,'DY')= 'SUN'
then
DBMS_OUTPUT.PUT_LINE('Today is holiday, ename =' );
else
DBMS_OUTPUT.PUT_LINE('Today is working Day, ename =');
emps_check();
end if;
end;
When I use following to update emp table:
SQL> UPDATE emp T1
2 SET T1.sal = 200.0
3 WHERE T1.ename like '%SCOTT%';
I got:
Today is working Day, Trigger Call Procedure emps_check()
1. Start to Delete all rows in the emps
2. Start to insert into emps from emp
3. s_sql= INSERT INTO Emps(EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO) select EMPNO,ENAME,JOB,MGR
Procedure call Exception: Employ Name
Trigger Call Procedure emps_check() Success
Looks like EXECUTE IMMEDIATE s_sql; did not work.
What is wrong??
How to make my Execute Immediate statement to work??
Thanks

Answer 1

You may omit the ';' character...
s_sql:='INSERT INTO
Emps(EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO)
select EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO
from emp';
... and something else
IN PL/SQL when a procedure , function doews not take
any parameter(s) then its call can be made as simply
its name without a pair of parenthesis....(It seems
that you are influenced by Java...:) )
SimThanks Sir:
I remove this ; but still error:
1 UPDATE emp T1
2 SET T1.sal = 768.1
3* wHERE T1.ename like '%SCOTT%'
SQL> /
Today is working Day, Trigger Call Procedure emps_check()
1. Start to Delete all rows in the emps
2. Start to insert into emps from emp
3. s_sql= INSERT INTO Emps(EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO) select EMPNO,ENAME,JOB,MGR,
Procedure call Exception: Employ Name
Trigger Call Procedure emps_check() Success
My code as follows:
CREATE OR REPLACE PROCEDURE emps_check IS
s_sql VARCHAR2(500);
BEGIN
DBMS_OUTPUT.PUT_LINE('1. Start to Delete all rows in the emps' );
delete from emps;
DBMS_OUTPUT.PUT_LINE('2. Start to insert into emps from emp' );
s_sql:='INSERT INTO Emps(EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO) select EMPNO,ENAME,JOB,MGR,HIREDATE,SAL,COMM,DEPTNO from emp';
DBMS_OUTPUT.PUT_LINE('3. s_sql= ' || s_sql );
EXECUTE IMMEDIATE s_sql;
DBMS_OUTPUT.PUT_LINE('3. Procedure call OK, Employ Name ' );
EXCEPTION
-- Use this to trap the ORA-00942: table or view does not exist
WHEN OTHERS THEN
DBMS_OUTPUT.PUT_LINE('Procedure call Exception: Employ Name ' );
end emps_check;
what is other wrong??
Yes, I am java guys,
Thanks