Producedure givng two rows instead of one row

Question

Hi
Please find below my procedure..when I execute this proc...displays two rows instead of one row. Please help me incase if I did mistake.
CREATE PROCEDURE SP_CWCTravel_Cruise_Amenities_S(
        @Cruise_Line_Code varchar(2500) = NULL,
        @Ship_Code varchar(2500) = NULL,
        @Sail_Id varchar(100) = NULL,
        @Base_Price decimal(8, 2),
        @Category_Groups varchar(2500) = NULL,
        @Categories varchar(2500) = NULL,
        @Rate_Codes varchar(2500) = NULL,
        @Booking_Date VARCHAR( 10 ),
        @Sail_Start_Date VARCHAR( 10 )
AS
BEGIN
    SELECT  TOP 1 *
    FROM CWCTravel_Cruise_Amenities_Definition as cad
                                JOIN CWCTravel_Cruise_Amenities_Definition_Date_Range AS caddr
                                ON cad.id = caddr.Amenities_Definition_Id
    WHERE Cruise_Line_Code in (SELECT item FROM SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Cruise_Line_Code))
        AND (Min_Base_Price = 0 OR Min_Base_Price <= @Base_Price)
        AND (Max_Base_Price = 0 OR Max_Base_Price >= @Base_Price)
        AND (Ship_Code IS NULL OR Ship_Code = '' OR Ship_Code IN (SELECT item FROM SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Ship_Code)))
        AND (Sail_Id IS NULL OR Sail_Id = '' OR Sail_Id IN (SELECT item FROM SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Sail_Id))) 
        AND (Rate_Codes IS NULL OR Rate_Codes = '' OR ((SELECT COUNT(*) FROM
                                                                                   (SELECT Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Rate_Codes)) A,
                                                                                   (SELECT REPLACE(REPLACE(Item,'?', '_'), '*', '%') Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(Rate_Codes)) B
                                                                                    WHERE A.Item LIKE B.Item) > 0))
                                AND (Category_Groups IS NULL OR Category_Groups = '' OR ((SELECT COUNT(*) FROM
                                                                                   (SELECT Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Category_Groups)) A,
                                                                                   (SELECT  Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(Category_Groups)) B
                                                                                    WHERE A.Item LIKE B.Item) > 0))
                AND (Categories IS NULL OR Categories = '' OR ((SELECT COUNT(*) FROM
                                                                                   (SELECT Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Categories)) A,
                                                                                   (SELECT  Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(Categories)) B
                                                                                    WHERE A.Item LIKE B.Item) > 0))
                                AND  (@Booking_Date is null or @Booking_Date=''
                                                                                                OR (( caddr.from_date IS NULL OR caddr.from_date <= @Booking_Date ) AND ( caddr.to_date IS NULL OR caddr.to_date >= @Booking_Date )                                                                                   
                                                                                AND  (( caddr.date_range_type IS NULL ) OR ( caddr.date_range_type = 'BOOK_DATE' ))) )
    union
    SELECT  TOP 1 *
    FROM CWCTravel_Cruise_Amenities_Definition as cad
                                JOIN CWCTravel_Cruise_Amenities_Definition_Date_Range AS caddr
                                ON cad.id = caddr.Amenities_Definition_Id
    WHERE Cruise_Line_Code in (SELECT item FROM SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Cruise_Line_Code))
        AND (Min_Base_Price = 0 OR Min_Base_Price <= @Base_Price)
        AND (Max_Base_Price = 0 OR Max_Base_Price >= @Base_Price)
        AND (Ship_Code IS NULL OR Ship_Code = '' OR Ship_Code IN (SELECT item FROM SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Ship_Code)))
        AND (Sail_Id IS NULL OR Sail_Id = '' OR Sail_Id IN (SELECT item FROM SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Sail_Id))) 
        AND (Rate_Codes IS NULL OR Rate_Codes = '' OR ((SELECT COUNT(*) FROM
                                                                                   (SELECT Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Rate_Codes)) A,
                                                                                   (SELECT REPLACE(REPLACE(Item,'?', '_'), '*', '%') Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(Rate_Codes)) B
                                                                                    WHERE A.Item LIKE B.Item) > 0))
                                AND (Category_Groups IS NULL OR Category_Groups = '' OR ((SELECT COUNT(*) FROM
                                                                                   (SELECT Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Category_Groups)) A,
                                                                                   (SELECT  Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(Category_Groups)) B
                                                                                    WHERE A.Item LIKE B.Item) > 0))
                AND (Categories IS NULL OR Categories = '' OR ((SELECT COUNT(*) FROM
                                                                                   (SELECT Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(@Categories)) A,
                                                                                   (SELECT  Item FROM dbo.SF_CWCTravel_GetStrTableFromCommaSeparatedStr(Categories)) B
                                                                                    WHERE A.Item LIKE B.Item) > 0))
        AND  (@Sail_Start_Date is null or @Sail_Start_Date=''
                                                                                                OR (( caddr.from_date IS NULL OR caddr.from_date <= @Sail_Start_Date ) AND ( caddr.to_date IS NULL OR caddr.to_date >= @Sail_Start_Date )                                                                                   
                                                                                AND  (( caddr.date_range_type IS NULL ) OR ( caddr.date_range_type = 'TRAVEL_DATE' ))) )                                                                        
    ORDER BY Cruise_Line_Code DESC, Ship_Code DESC, Sail_Id DESC, Rate_Codes DESC, Category_Groups DESC, Categories DESC
ENDWhile executing this SP
I am getting the following results.
2043 23-07-2010 AM 11:22:10 23-08-2011 PM 04:57:19 8 princess caribbeanPrincess 2043 20-08-2011 AM 12:00:00 30-11-2011 AM 12:00:00 BOOK_DATE
2043 23-07-2010 AM 11:22:10 23-08-2011 PM 04:57:19 8 princess caribbeanPrincess 2043 01-10-2011 AM 12:00:00 30-11-2011 AM 12:00:00 TRAVEL_DATE
I need only the first record.
Thanks in adv
Rekha

Answer 1

871270 wrote:
Hi
Please find below my procedure..when I execute this proc...displays two rows instead of one row. Please help me incase if I did mistake.Seriously?
You wrote a query against tables we've never seen, containing data we can't possibly have any idea about and you expect us to be able to help you?
Please go discuss this with someone in your organization who understands the data model and have them explain to you how it is supposed to work.
Put yourself in our situation (forum volunteers) ... if we threw some arbitrary code with no explanation as to what it does, what the data model looks like and what's supposed to be happening, do you think you'd be very successful ?