Requesting peer review of coding technique.

Hello, I'm curious if anyone here can review my flash to see
if my coding techniques are proper.
To start, here's the site:
Example Site
If you click on the top row of buttons corresponding to each
section, you'll notice a slight transition before the section is
loaded. Each section is a separate .swf file, which is loaded via
actionscript to a MovieClipLoader. (See livedocs for the
MovieClipLoader API reference)
The transition animation is responsible for passing calls to
the MovieClipLoader for loading/unloading movies, and does so
during keyframes in the animation's timeline. For example, when a
button is clicked, and "the curtain is down" the MovieClipLoader is
unloaded, and then loaded with a different .swf.
I don't have access to a screen reader to test how accessible
the flash is. However, I have been told that accessibility
standards suggest animations be hidden from a screen reader via the
"wmode" property. Assuming the animation is disabled in the screen
reader, will the transition animation still fire events it incurs
on the timeline?
Should I not control loading/unloading of movie clips on the
timeline? I believe my technique is robust enough to work in a
non-accessible environment. It locks input while the animation is
playing, and ensures a small memory footprint by unloading unused
.swf files. However, is it the right approach with accessibility in
mind?
Thanks for any input,
-Jonathan

it would look better if instead of a white dropdown covering
the previous content and then a black dropup revealing the next
content, you used a dropdown that changed the previous content to
an alpha of 10% until the bottom is reached when the next content
is loaded with an alpha of 10% and the dropup revealed the next
content with 100%.

Similar Messages

Peer reviews,coding standards and audit norms

hi,
what is meant by peer reviews, coding standards and audit norms in development project of ABAP.
regds:
balakrishna.

Hi Bala,
Peer review: The code which is written by the developer will be cross checked by one of the team member if the code fulfills the technical spec or not.
Coding Standards: In a project the client and the software service provider will have an understanding regarding naming convention of all variables, constants, internal table, select-options, etc.
Example: if it is a select-options the field should be named with the first letter S_ then you will write S_Matnr, and for variables you have to follow V_ then V_maktx.
Audit norms: Audit norms will depend on the organization so it does not have any standard answer.
Regards,
Lakshmikanth

Technical Specification Peer Review Document

Hi Team
right now i am working in a implementation project where PI system is a middleware system. here i am developing several abap related and PI related objects for that i have developed some Techincal specifications and now my requirement is to do the technical specification peer review. so I want to know more details about technical specification peer review document. Please tell me what is technical specification peer review document and why is used in detail. if possible please provide me the sample technical specification peer review document for my reference. i request you to please explain me more details about the technical specification peer review document because i am having much knowledge and now there is a requirement for me to do technical specification peer review and update in the template, so please do provide me the sample techincal specification peer review template for my better understanding. Thanks in advance.
Regards
Raj

Hi Raj,
I never com across Technical Specification peer review document, We develop TS for every interface which covers
1)Bussiness reuirement
2)Trchnical Description in deatil
3)Bussiness Flow
4)Source and Tget data fromats description
5)Mapping Logic
6)Which adapters are you going to use,ad you need to specify all obejcts required for this interface/developed for this interface
whick convers SLD,ESR,ID ...
fter completion of evry interface we updates the all deatils in TS,then we need to review the same TS.if anything misses of we need to document the same.May be you need to develop one template for to note down all review comments...
Regards,
Raj

About documents in the peer review

1. What are the documents involved in the peer review of the object?
2. is there anything called quality check list using when we are doing peer review?
3. what is the meaning of quality check list, what do u do with the quality check list?

Do check the following things...
1) There are coding standards in every project. Try to check all the coding standards in the code.
2) see that no hard coding is done in the code.
3)Pls refer to an existing transaction code if you are making a module pool program.
4) Always test the changes.
5) If there are If & Else in program, make sure that you simulate conditions so that each line of code is executed at least once for testing.
6) While writing selects try to see if indexes can be used
7)Quality checklist generally means following the standards as laid out by the client.
do an extended code review and try to remove as much extra things as possible.
Reward if useful,
Cheers,
Sharadendu

Need of peer review software (in research)

Hej (Swedish for Hi),
I have submitted this question to the Leopard forum, but if any administrator thinks it is more suitable in another Mac Forum, please feel free to move my post.
NEED OF SOFTWARE
Most of the times when I submit a manuscript to a scientific journal, that journal will ask me to supply the names, addresses and email addresses of 3-4 potential peer reviewers (they will scrutinize my paper and judge its quality). I do this over and over again. Sometimes a manuscript is rejected and I am quite convinced I know who rejected the paper (although peer review is anonymous), and I might not want to recommend that person again for the very same manuscript. Sometimes I have recommended a person as a peer reviewer several times within the last months, and want to recommend someone else.
It could also be nice to have some statistics of how many times a certain person has been recommended, and for what journal. Of course this could probably be done in Excel, but perhaps there is some nice Mac-program for this (otherwise, is anyone interrested in writing one...?)
I am looking for a software that could handle the following:
name of the reviewer
current email
current address
current institution
reasons for choosing him/her as a peer reviewer
Last time he was recommended
Number of times he/she has been recommended.
A list of all journals, dates and for what papers he has been recommended
The outcome of each submission when he/she was recommended
How would you have solved this?
Best regards, Jonas Ludvigsson
(doing research on celiac disease, and epidemiology in general)

Howdy Jonas (Texas for hej),
It sounds like you are looking for a simple database application. [Bento|http://store.apple.com/us/product/TW345LL/A] would probably be able to do everything you need. It is made by FileMaker.
Best of luck.

Infopath Time Off Request For on Sharepoint Coding in C#

So I have created a Time Off Request form to put up on our internal company intranet sharepoint site.
I am trying to get this form to do several things.
First of all, after the user fills out the form they can click the submit button and it will email it to their manager. That part is working fine.
The other button is the one that I am having trouble with.
Once the Manager receives the request I want them to be able to click a 2nd "approve" button and make the following happen:
A calendar entry is automatically created in the managers calendar for the day/days requested off. It needs to be created as an All Day Event and Marked Private.
An appointment invitation needs to be sent to the requester so they can accept and the day/days will be added to their calendar as well.
An email needs to be sent to the Requester telling them their request has been approved.
Here is the code I have so far. It is in C#
using Microsoft.Office.InfoPath;
using System;
using System.Windows.Forms;
using System.Xml;
using System.Xml.XPath;
using mshtml;
using Outlook = Microsoft.Office.Interop.Outlook;
using System.Reflection;
using System.Net;
using System.Net.Mail;
namespace ITTimeOffRequest
public partial class FormCode
public void InternalStartup()
((ButtonEvent)EventManager.ControlEvents["CTRL10_2"]).Clicked += new ClickedEventHandler(CTRL10_2_Clicked);
public void CTRL10_2_Clicked(object sender, ClickedEventArgs e)
// Get a reference to the Main datasource
XPathNavigator root = MainDataSource.CreateNavigator();
// Create an Outlook application
Outlook.Application outlookApp = new Outlook.Application();
// Get NameSpace and Logon
Outlook.NameSpace outlookNS = outlookApp.GetNamespace("mapi");
outlookNS.Logon("arochelle", Missing.Value, false, true);
// Create a new AppointmentItem
Outlook.AppointmentItem appointmentItem =
(Outlook.AppointmentItem)outlookApp.CreateItem(Microsoft.Office.Interop.Outlook.OlItemType.olAppointmentItem);
appointmentItem.Sensitivity = Microsoft.Office.Interop.Outlook.OlSensitivity.olPrivate;
appointmentItem.AllDayEvent = true;
appointmentItem.ReminderSet = true;
appointmentItem.ReminderMinutesBeforeStart = 5;
appointmentItem.BusyStatus = Outlook.OlBusyStatus.olBusy;
appointmentItem.IsOnlineMeeting = false;
appointmentItem.OptionalAttendees = root.SelectSingleNode("//my:field2", NamespaceManager).Value;
appointmentItem.Subject = ("Time Off Request");
appointmentItem.Body = ("Date of request") + root.SelectSingleNode("//my:field4", NamespaceManager).Value;
appointmentItem.Location = root.SelectSingleNode("//my:field13", NamespaceManager).Value;
//appointmentItem.Start.Day.ToString = root.SelectSingleNode("//my:field10", NamespaceManager).Value;
//appointmentItem.End.Day.ToString = root.SelectSingleNode("//my:field10", NamespaceManager).Value;
//appointmentItem.Start = DateTimePicker.("//my:field10");
//appointmentItem.End = DateTimePicker("//my:field10");
appointmentItem.Start = DateTime.Parse("//my:field10");
// Save to Calendar
appointmentItem.Save();
// Logoff
outlookNS.Logoff();
// Clean up
appointmentItem = null;
outlookNS = null;
outlookApp = null;
// Send Email Confirmation.
SmtpClient client = new SmtpClient();
client.Port = 25;
client.Host = "sw-exchange";
client.EnableSsl = false;
client.Timeout = 10000;
client.DeliveryMethod = SmtpDeliveryMethod.Network;
client.UseDefaultCredentials = false;
MailMessage mm = new MailMessage("<manager email address here", "//my:field2", "Your Time Off Has Been
Approved", "Your Time Off Has Been Approved");
mm.DeliveryNotificationOptions = DeliveryNotificationOptions.OnFailure;
client.Send(mm);
Obviously i'm trying to get the code to pull in a lot of the information from the fields people have filled on on the form. For example in the send email confirmation section Field 2 is the choose emplayee email drop down box on the form. CTRL10_2
is the approve button. Field 10 is the day requested off. The form has five lines to request days off on it and each line has a date picker to choose the day. A text field for number of hours requested off, a Time field for Start Time, a
Time field for End Time and a Drop down box to pick Sick Leave or Annual Leave.
I'm having a problem with creating the appointment on the appropriate day in the managers calendar and then sending the appointment request to the requester. That is where the code errors out. This is only the coding for the first line of time
off requests as well, i'm not sure how to change the code so that it will include all 5 request lines unless I have to use some kind of Matrix or something.
I'm trying to get the appointmentitem.start and .end to pull from the date(s) that have been requested off but what happens so far is that when the approve button is clicked it just crates a private all day calendar entry for the current day on the managers
calendar and doesn't generate the appointment request for the requester or send the confirmation email.
Any help would be greatly greatly appreciated.

for the electronic form:
since you're on Standard edition, I wouldn't recommend InfoPath... I'd start with standard SharePoint list (using attachments for scanned images)... if it needs to be customized, I'd use web dev approaches (HTML+JavaScript), since we've found this approach
to be VERY upgradable.
For the process:
Assuming the process is LINEAR, I'd use SharePoint Designer with an approval process activity and a task activity (for AP). If the process is NOT linear, I'd look into a third party component like Nintex or K2 (you may find some people who say "just build
it with Visual Studio"... don't. You'll regret it later, and the business will too).
Scott Brickey
MCTS, MCPD, MCITP
www.sbrickey.com
Strategic Data Systems - for all your SharePoint needs

PPP LCP Send Termination Request [Peer not respond...

Just an easy one.
What does the 'Peer not responding' bit mean, from the subject.
Cheers

DavidCo wrote:
After all, even if there is a non-reponsive peer, that is not a reason to disconnect.
It is actually. Which is why it is disconnected.
PPP LCP termination
It is recommended that the Access Concentrator occasionally send LCP Echo-Request packets to the host to determine the state of the PPP session, so that the Access Concentrator can determine whether the host has terminated without sending an LCP terminate request packet
When LCP terminated, the host and Access Concentrator MUST stop using that PPPoE session. If the host wishes to start another PPP session, it MUST return to the PPPoE Discovery phase.
If you found this post helpful, please click on the star on the left
If not, I'll try again

Request to check my coding..... Urgent

MY program is with ALV_Grid
1. Selection Screen
Customer Number: KUNNR
Billing Date: FKDAT
Now Using the above Selection screen inputs, I want to generate the following fields in the output.
2. Output Screen
Invoice No: VBELN
Invoice Date: FKDAT
Customer Number: KUNNR
Customer Name: NAME1
Material Description: MAKTX
Payment Terms: ZTERM
Net Value: NETWR
Ship-to City: ORT01
Sold-to party: KUNAG
Ship-to party: KUNNR
Tables Used:
Delivery: LIKP, LIPS
Invoice:VBRK, VBRP
Customer: KNA1
Material: MARA
Material Description: MAKT
Now the Problem what I got is....How to link between these tables...ie., what common fields can be used between these tables so that I can use FOR ALL ENTRIES and retrieve the above output fields.
3. Create Dictionary Structure for Output Data
4. Create Dynpro (Screen 9000)
5. Create ALV Grid Object and Call Method "set_table_for_first_display" of alv obj in PBO Module of Screen
this is my coding so can
*& Report ZTESTALVOOPS
REPORT ZTESTALVOOPS.
tables: KNA1, KNVV,VBAK,VBFA, VBRK, mara.
data gr_alv_grid type ref to cl_gui_alv_grid.
data gc_custom_control_name type scrfname value 'CC_ALV'.
data gr_custom_container type ref to cl_gui_custom_container.
data gt_fieldcat type lvc_t_fcat.
data gs_layout type lvc_s_layo.
types: lvc.
selection screen *******************
select-options: so_kunnr for kna1-kunnr,
 so_fkdat for vbrk-fkdat.
data begin of gt_list occurs 0.
 include structure ZDIC_STRUC. " Dictionary Structure for Output Data
data end of gt_list.
start of selection **********************
end of selection *************************
call screen 9000.
*& Module STATUS_0100 OUTPUT
 text
MODULE STATUS_0100 OUTPUT.
SET PF-STATUS 'SET_STATUS'.
SET TITLEBAR 'FIRST' of program prg with cnt.
perform disp_alv. " DISPLAY ALV GRID
ENDMODULE. " STATUS_0100 OUTPUT
*& Form disp_alv
 text
--> p1 text
<-- p2 text
FORM disp_alv .
if gr_alv_grid is INITIAL.
CREATE OBJECT GR_CUSTOM_CONTAINER
EXPORTING
 PARENT =
 CONTAINER_NAME = gc_custom_control_name
 STYLE =
 LIFETIME = lifetime_default
 REPID =
 DYNNR =
 NO_AUTODEF_PROGID_DYNNR =
EXCEPTIONS
 CNTL_ERROR = 1
 CNTL_SYSTEM_ERROR = 2
 CREATE_ERROR = 3
 LIFETIME_ERROR = 4
 LIFETIME_DYNPRO_DYNPRO_LINK = 5
 others = 6
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
 WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
CREATE OBJECT GR_ALV_GRID
EXPORTING
 I_SHELLSTYLE = 0
 I_LIFETIME =
 I_PARENT = gr_custom_container
 I_APPL_EVENTS = space
 I_PARENTDBG =
 I_APPLOGPARENT =
 I_GRAPHICSPARENT =
 I_NAME =
EXCEPTIONS
 ERROR_CNTL_CREATE = 1
 ERROR_CNTL_INIT = 2
 ERROR_CNTL_LINK = 3
 ERROR_DP_CREATE = 4
 others = 5
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
 WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
perform prepare_fieldcat changing gt_fieldcat.
perform prepare_layout changing gs_layout.
CALL METHOD GR_ALV_GRID->SET_TABLE_FOR_FIRST_DISPLAY
EXPORTING
 I_BUFFER_ACTIVE =
 I_BYPASSING_BUFFER =
 I_CONSISTENCY_CHECK =
 I_STRUCTURE_NAME =
 IS_VARIANT =
 I_SAVE =
 I_DEFAULT = 'X'
 IS_LAYOUT = gs_layout
 IS_PRINT =
 IT_SPECIAL_GROUPS =
 IT_TOOLBAR_EXCLUDING = gt_exclude
 IT_HYPERLINK =
 IT_ALV_GRAPHICS =
 IT_EXCEPT_QINFO =
CHANGING
 IT_OUTTAB = gt_list[]
 IT_FIELDCATALOG = gt_fieldcat
 IT_SORT = gt_sort
 IT_FILTER =
EXCEPTIONS
 INVALID_PARAMETER_COMBINATION = 1
 PROGRAM_ERROR = 2
 TOO_MANY_LINES = 3
 others = 4
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
 WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
else.
CALL METHOD GR_ALV_GRID->REFRESH_TABLE_DISPLAY
EXPORTING
 IS_STABLE = gt_list[]
 I_SOFT_REFRESH = gt_list[]
EXCEPTIONS
 FINISHED = 1
 others = 2
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
 WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
endif.
ENDFORM. " disp_alv
*& Form prepare_fieldcat
 text
 <--P_GT_FIELDCAT text
FORM prepare_fieldcat CHANGING P_GT_FIELDCAT type lvc_t_fcat.
data ls_fcat type lvc_s_fcat.
CALL FUNCTION 'LVC_FIELDCATALOG_MERGE'
EXPORTING
I_BUFFER_ACTIVE =
 I_STRUCTURE_NAME = 'dic_struc'
I_CLIENT_NEVER_DISPLAY = 'X'
I_BYPASSING_BUFFER =
I_INTERNAL_TABNAME =
CHANGING
 CT_FIELDCAT = p_gt_fieldcat[]
EXCEPTIONS
INCONSISTENT_INTERFACE = 1
PROGRAM_ERROR = 2
OTHERS = 3
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
 WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
*loop at p_gt_fieldcat into ls_fcat.
*case ls_fcat-fieldname.
*when 'CARRID'.
*ls_fcat-hotspot = 'X'.
*ls_fcat-outputlen = '10'.
*ls_fcat-coltext = 'Carrier ID'.
*modify p_gt_fieldcat from ls_fcat.
*when 'PAYMENTSUM'.
*ls_fcat-no_out = 'X'.
*ls_fcat-outputlen = '10'.
*modify p_gt_fieldcat from ls_fcat.
*endcase.
*endloop.
ENDFORM. " prepare_fieldcat
*& Form prepare_layout
 text
 <--P_GS_LAYOUT text
FORM prepare_layout CHANGING P_GS_LAYOUT type lvc_s_layo.
p_gs_layout-zebra = 'X'.
p_gs_layout-grid_title = 'FLIGHTS'.
p_gs_layout-smalltitle = 'X'.
ENDFORM. " prepare_layout
*& Module USER_COMMAND_0100 INPUT
 text
MODULE USER_COMMAND_0100 INPUT.
case sy-ucomm.
when 'BACK'.
SET SCREEN 0.
LEAVE SCREEN.
when 'CANCEL'.
LEAVE PROGRAM.
WHEN 'OTHERS'.
LEAVE PROGRAM.
endcase.
ENDMODULE. " USER_COMMAND_0100 INPUT
Can anyone tell the code for selction statement for this program .....

Now check the coding for the MY program is with ALV_Grid
1. Selection Screen
Customer Number: KUNNR
Billing Date: FKDAT
Now Using the above Selection screen inputs, I want to generate the following fields in the output.
2. Output Screen
Invoice No: VBELN
Invoice Date: FKDAT
Customer Number: KUNNR
Customer Name: NAME1
Material Description: MAKTX
Payment Terms: ZTERM
PR00_NETVALUE: KBETR
VPRS_COST: KWERT
VPRS_PROFITMARG: KBETR
Ship-to City: ORT01
Sold-to party: KUNAG
Ship-to party: KUNNR
Tables Used:
Delivery: LIKP, LIPS
Invoice:VBRK, VBRP
Customer: KNA1
Material: MARA
Material Description: MAKT
salesDocument VBAK - Head, VBAP Positions
3. Create Dictionary Structure for Output Data
4. Create Dynpro (Screen 9000)
5. Create ALV Grid Object and Call Method "set_table_for_first_display" of alv obj in PBO Module of Screen
Coding
REPORT ZTESTALVOOPS.
tables: KNA1, KNVV,VBAK,VBFA, VBRK, mara.
data gr_alv_grid type ref to cl_gui_alv_grid.
data gc_custom_control_name type scrfname value 'CC_ALV'.
data gr_custom_container type ref to cl_gui_custom_container.
data gt_fieldcat type lvc_t_fcat.
data gs_layout type lvc_s_layo.
types: lvc.
selection screen *******************
select-options: itab_kunnr for kna1-kunnr,
itab_fkdat for vbrk-fkdat.
data begin of gt_list occurs 0.
include structure Zrata_STRUC. " Dictionary Structure for Output Data
data end of gt_list.
start of selection **********************
select avbeln afkdat akunag a vbeln_va avndat_veda a vbeln_va anetwr bposnr bkbetr bkwert bkbetr bmaktx b~vgbel
from vbrk as a join vbrp as b on avbeln = bvbeln
into table itab where a~kunag in s_kunnr and
a~fkdat in s_fkdat.
loop at itab.
select single maktx from makt into itab-maktx
where matnr = itab-matnr and spras = sy-langu.
select single kunag into itab-kunag from likp
where vbeln = itab-vgbel.
select single name1 from kna1 into itab-name1
where kunnr = itab-kunnr.
select single ort01 from kna1 into itab-ort01
where kunnr = itab-kunag.
modify itab index sy-tabix transporting maktx name1 kunag ort01.
endloop.
end of selection *************************
call screen 9000.
*& Module STATUS_0100 OUTPUT
text
MODULE STATUS_0100 OUTPUT.
SET PF-STATUS 'SET_STATUS'.
SET TITLEBAR 'FIRST' of program prg with cnt.
perform disp_alv. " DISPLAY ALV GRID
ENDMODULE. " STATUS_0100 OUTPUT
*& Form disp_alv
text
--> p1 text
<-- p2 text
FORM disp_alv .
if gr_alv_grid is INITIAL.
CREATE OBJECT GR_CUSTOM_CONTAINER
EXPORTING
PARENT =
CONTAINER_NAME = gc_custom_control_name
STYLE =
LIFETIME = lifetime_default
REPID =
DYNNR =
NO_AUTODEF_PROGID_DYNNR =
EXCEPTIONS
CNTL_ERROR = 1
CNTL_SYSTEM_ERROR = 2
CREATE_ERROR = 3
LIFETIME_ERROR = 4
LIFETIME_DYNPRO_DYNPRO_LINK = 5
others = 6
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
CREATE OBJECT GR_ALV_GRID
EXPORTING
I_SHELLSTYLE = 0
I_LIFETIME =
I_PARENT = gr_custom_container
I_APPL_EVENTS = space
I_PARENTDBG =
I_APPLOGPARENT =
I_GRAPHICSPARENT =
I_NAME =
EXCEPTIONS
ERROR_CNTL_CREATE = 1
ERROR_CNTL_INIT = 2
ERROR_CNTL_LINK = 3
ERROR_DP_CREATE = 4
others = 5
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
perform prepare_fieldcat changing gt_fieldcat.
perform prepare_layout changing gs_layout.
CALL METHOD GR_ALV_GRID->SET_TABLE_FOR_FIRST_DISPLAY
EXPORTING
I_BUFFER_ACTIVE =
I_BYPASSING_BUFFER =
I_CONSISTENCY_CHECK =
I_STRUCTURE_NAME =
IS_VARIANT =
I_SAVE =
I_DEFAULT = 'X'
IS_LAYOUT = gs_layout
IS_PRINT =
IT_SPECIAL_GROUPS =
IT_TOOLBAR_EXCLUDING = gt_exclude
IT_HYPERLINK =
IT_ALV_GRAPHICS =
IT_EXCEPT_QINFO =
CHANGING
IT_OUTTAB = gt_list[]
IT_FIELDCATALOG = gt_fieldcat
IT_SORT = gt_sort
IT_FILTER =
EXCEPTIONS
INVALID_PARAMETER_COMBINATION = 1
PROGRAM_ERROR = 2
TOO_MANY_LINES = 3
others = 4
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
else.
CALL METHOD GR_ALV_GRID->REFRESH_TABLE_DISPLAY
EXPORTING
IS_STABLE = gt_list[]
I_SOFT_REFRESH = gt_list[]
EXCEPTIONS
FINISHED = 1
others = 2
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
endif.
ENDFORM. " disp_alv
*& Form prepare_fieldcat
text
<--P_GT_FIELDCAT text
FORM prepare_fieldcat CHANGING P_GT_FIELDCAT type lvc_t_fcat.
data ls_fcat type lvc_s_fcat.
CALL FUNCTION 'LVC_FIELDCATALOG_MERGE'
EXPORTING
I_BUFFER_ACTIVE =
I_STRUCTURE_NAME = 'dic_struc'
I_CLIENT_NEVER_DISPLAY = 'X'
I_BYPASSING_BUFFER =
I_INTERNAL_TABNAME =
CHANGING
CT_FIELDCAT = p_gt_fieldcat[]
EXCEPTIONS
INCONSISTENT_INTERFACE = 1
PROGRAM_ERROR = 2
OTHERS = 3
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
*loop at p_gt_fieldcat into ls_fcat.
*case ls_fcat-fieldname.
*when 'CARRID'.
*ls_fcat-hotspot = 'X'.
*ls_fcat-outputlen = '10'.
*ls_fcat-coltext = 'Carrier ID'.
*modify p_gt_fieldcat from ls_fcat.
*when 'PAYMENTSUM'.
*ls_fcat-no_out = 'X'.
*ls_fcat-outputlen = '10'.
*modify p_gt_fieldcat from ls_fcat.
*endcase.
*endloop.
ENDFORM. " prepare_fieldcat
*& Form prepare_layout
text
<--P_GS_LAYOUT text
FORM prepare_layout CHANGING P_GS_LAYOUT type lvc_s_layo.
p_gs_layout-zebra = 'X'.
p_gs_layout-grid_title = 'FLIGHTS'.
p_gs_layout-smalltitle = 'X'.
ENDFORM. " prepare layout
*& Module USER_COMMAND_0100 INPUT
text
MODULE USER_COMMAND_0100 INPUT.
Case sy-ucomm.
When 'BACK'.
SET SCREEN 0.
LEAVE SCREEN.
When 'CANCEL'.
LEAVE PROGRAM.
WHEN 'OTHERS'.
LEAVE PROGRAM.
Endcase.
ENDMODULE. USER_COMMAND_0100 INPUT

Proper init coding technique

Basic object oriented coding question using init.
The following code works, but is really not proper (or is it).
Can someone point out the best way to code initWithType:buttonType properly?
The instantiation of a button using a custom subclass buttnView:
          UIView* buttonView;
          buttonView = [[ButtonView alloc] initWithType:buttonReset];
          [self.view addSubview:buttonView];
ButtonView.h - really basic:
@interface ButtonView : UIView {
          int myType;
@property (nonatomic) int myType;
- (id)initWithType:(int)buttonType;
@end
ButtonView.m
- (id)initWithFrame: (CGRect)frame {
    if (self = [super initWithFrame:frame]) {
        // Initialization code
    return self;
- (id)initWithType: (int)buttonType {
       if ( buttonType == buttonReset ) {
            [self initWithFrame:CGRectMake(buttonResetX,buttonResetY, buttonSize,buttonSize)];
            myType = buttonReset;
       else {
            ... a bunch of different button-types ...
       else
            return nil;
       self.userInteractionEnabled = NO;
       self.opaque = NO;
       return self;
As I said, this "works", but Analyze complains:
Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
And while I recognize, yep, I'm not doing this quite right, I don't seem to be able to think of the right pattern.
The code puts custom buttons at pre-defined locations type'X, type'Y each at size buttonSize.
Thanks.

No, it's happy with initWithFrame. It just complains about every line which calls it in initWithType, e.g.
[self initWithFrame:
         CGRectMake(buttonResetX,buttonResetY,buttonSize,buttonSize)];

Request to review the custom workflow logic in E recruting

Requirement:
The purpose of this workflow is to change the status of the candidate to Rejected if they are not selected in the selection process and also to change the status of the requisition to Closed when a candidate is selected. The workflow is triggered when the system is updated to reflect that the candidate has accepted the offer.
processing details:
When a candidate has accepted an offer, an activity Offer Accepted is created in the Status Change infotype (IT5139). This will trigger the workflow.
The workflow will check the Candidacy infotype (5133) for all other candidates who have applied for the same position and reject the candidate by creating a Rejected activity.
Simultaneously the workflow should change the status of the Requisition Info type to closed, so that the requisition status is closed

Logic
Step 1: Candidate accepts the offer (Trigger)
When the Candidate accepts the offer, i.e. if in the table HRP 5139 (Status change infotype which stores the activities which result in status change of candidate) for the keyed in value of object type NE (Candidacy) plan version Current, with the keyed in start date and the end date the value of the field ACT_CAT (activity category) is 5100-Offer Accepted, the workflow should trigger
Step 2: Change Status of Non-Selected Candidates to rejected
A) Check infotype, table HRP 5139(Status change infotype which stores the activities which result in status change of candidate) for keyed in value of object type NE (Candidacy) plan version Current (field name PLVAR), with the keyed in start date (field name - BEGDA) and end date (field name-ENDDA) the value of the field ACT_CAT (activity category) is 5100-Offer Accepted or not
If it exists then no action,
If not then,
B) Trigger (create) the activity 5010-Rejection (field name ACT_TYPE,) in the table HRP 5139 (Status change infotype which stores the activities which result in status change of candidate) for the object type NE(Candidacy) plan version Current with the keyed in start date (field name- BEGDA) and end date (field name-ENDDA) and save ,
Step 3: Close Job Requisition
A) Derive the value of object id for object type NB {Requisition (related object type)} in table HRP 1001, subtype A654 (Relationship between Candidacy and Requisition) for the keyed in value of the object type NE (Candidacy) plan version Current with the keyed in start date (field name- BEGDA) and end date (field name-ENDDA) .
B) For the above derived value of Object type NB (Requisition), change the status of the table HRP 5125 (Requisition information infotype that stores the status of the Requisition), to closed field name STATUS value 2-closed plan version Current with the keyed in start date (field name- BEGDA) and end date (field name-ENDDA).
Request to Check the workflow logicand provide your valuable comments.
Thanks and best regards
Rajeev

Hallo Rajeev,
better forget the idea of the standard sap workflows - they are just examples and my opinion is: they are bad ones.
I understand the topic, although so far I did not encounter any customer / hr department which was giving the system so much power through automatization. You also will never be able to hire more than 1 person on 1 requisition. But this is all requirement analysis not solution (although the sencond one is not possible w/o the first one - "pigs will fly before I implement a workflow just the way the hr department described and requested it" ;o).
Your description is quite rough from my point of view. The workflow landscape is missing to tell you if this steps are enough to get your things done correctly and of course without your processes no serious workflow programmer will give his ok to a workflow soluition.
What I see as a problem you defined everything based on tables. E-recruiting is an object oriented solution. You never go down to table level for workflows you not even use the hr function modules. You always have to use the service funtions contained in classes like the cl_hrrcf_*_bl ones.
If you change to service functions you are at least not completely wrong based on what you described as your approach. But for a real complete analysis everyone would have to dig into the processes what is usually impossible as they are company secrets.
Best Regards
Roman Weise

Request for review

hello,
i have started working on labview recently and have tried out to solve the prime factors challenge
please go throught the attached design for the prime factors challenge.
awaiting your comments
vijay
Attachments:
primefactorschallenge_version2.vi ‏180 KB
PRIME.vi ‏32 KB

Vijay
Congratulations for making a working program.
We have seen your other post, but a code review is difficult because there are many things that are overly complicated and convoluted and should be done quite differently. For example you do entire loops to duplicate fuctions that are already part of labVIEW. I probably won't have time during the next few day to look at it in detail.
In the meantime, learn about shift registers. Also you use way to many unneeded local variables. You don't need a single one! Try to get rid of the sequence structure and wire everything together instead of teleporting data between nodes using locals.
Then of course are the purely mathematical aspects of your approach. You do way (way!) too many trial divisions, many more than actually needed. First in each prime check, the again in the main code. Over and over again. All trial divisions with numbers larger that half the input are also not necessary.
To make the code really fast, try to e.g. implement the Sieve_of_Eratosthenes. It will be orders of magnitude faster than what you are doing.
LabVIEW Champion . Do more with less code and in less time .

Forms standard coding technique

Hi:
Thinking in terms of efficiency I need to check for the existence of a value in a database table E.g. in a W-V-I trig
CURSOR c1
IS
SELECT 'X'
FROM TAB_A
WHERE COL_A = :blockA.itema;
IF ( c1%NOTFOUND THEN )
show_alert('Does not exist...blah blah blah....');
CLOSE c1;
RAISE Form_Trig.....;
END IF;
Now in a Post_query trigger I would usually place a function in a Package to return a description for say Cust_Id.
But is it worth creating a BOOLEAN (packaged) function just to check for the existence of a row like in the example above ?
I am of the opinion that no client side explicit cursors should exist in forms modules no matter how simple they are. Does anyone agree ?
Let us know your comments.
Pradeep.

By the way are you a forms developer for Oracle Corp?Nope. Just a government (university) employee.
I like to use a Form Level W-V-I .. depending on trig
block then fire a seperate unit for validating items
in that block e.g.Yes, I sometimes put all of a block's WVI triggers into one at the block level. Don't know, though... it gets ugly sometimes. I usually create separate procedures within the enclosing Declare-Begin, and name them Edit_Name, Edit_Street, Edit_Phone, etc, and then call them from a main processing block in the trigger.
Declare
v_it VARCHAR2(50) := :SYSTEM.TRIGGER_ITEM;Sometimes, I add this:
Val varchar2(100) := Name_in(:System.Trigger_Item);
Then I can check
If VAl is null then...
---- Second message:
Just to go deeper.
What about when an implicit cursor checks for
TOO_MANY_ROWS ?
So firstly the implicit cursor checks for row
existence and then checks again for
uniqueness(TOO_MANY_ROWS). Where as an Explicit
cursor will only check for existence once. Is an
Explicit cursor still inferior considering this ?I saw a discussion a year or two back that Oracle had tightened that up a bit, so that they can do it all in one round trip -- or something to that effect. Anyway, if you create yourself a benchmark test both ways, I believe you would find that the implicit cursor will process faster than Open-fetch-close.

Zero-fingerprint deployment scenario - peer review invite

School/College implementation with student BYO laptop concept.
Packaging the vApps and securing the desired sandboxing is of course a part of the project as well as having expirydates.
Delivery is another question: By website for download, using streaming features, delivery by common iFolder or whatever you might have found a solid solution ??
And on top of the applications what about filesharing ? (iFolder) and printing ? (iPrint) or any other solutions.
KR /Bjrn

bkelsen,
It appears that in the past few days you have not received a response to your
posting. That concerns us, and has triggered this automated reply.
Has your problem been resolved? If not, you might try one of the following options:
- Visit http://support.novell.com and search the knowledgebase and/or check all
the other self support options and support programs available.
- You could also try posting your message again. Make sure it is posted in the
correct newsgroup. (http://forums.novell.com)
Be sure to read the forum FAQ about what to expect in the way of responses:
http://forums.novell.com/faq.php
If this is a reply to a duplicate posting, please ignore and accept our apologies
and rest assured we will issue a stern reprimand to our posting bot.
Good luck!
Your Novell Product Support Forums Team
http://forums.novell.com/

Creating new PKGBUILD - peer review - newbie alert

I've read most of the documentation about creating a new PKGBUILD and have created my own for foobillard.
The docs suggest posting the PKGBUILD here for feedback/criticism. How have I done for a first go? Anything I can do to improve? TIA
#Maintainer: Kabads <[email protected]>
pkgname=foobillard
pkgver=2.9
pkgrel=1
epoch=
pkgdesc="FooBillard is a billiards (pool) simulation under Linux/OpenGL. "
arch=('i686' 'x86_64')
url="http://foobillard.sourceforge.net"
license=('GPL')
groups=()
depends=()
makedepends=()
checkdepends=()
optdepends=()
provides=()
conflicts=()
replaces=()
backup=()
options=()
install=
changelog=
source=(http://downloads.sourceforge.net/foobillard/$pkgname-$pkgver.tar.gz)
noextract=()
md5sums=(b8b10d7d3ade07a9e0c497165beadbca) #generate with 'makepkg -g'
prepare() {
cd "$srcdir/$pkgname-$pkgver"
build() {
cd "$srcdir/$pkgname-$pkgver"
./configure --prefix=/usr
make

Maybe now you can fill the template with some data? What dependencies are needed to build the package? What other packages does it depend on? Do you need to use 'epoch'? If not, remove the entry. Are other options (groups, optdepends, provides, etc) needed at all? If not -- remove them. Are you going to create a package or only build the source code (the package group is missing).

Peer review please

I have a working project (attached), but I'd like any suggestions on how I might do it better.
I have tried to keep to good object-oriented design principles such as 'Single Responsibility' and 'Encapsulation', but I'm always keen to do better.
Thanks
Mark
N.B. Doesn't allow Zip files, so you'll need to rename the attached '.doc' file to '.zip' before unzipping

Hi Mark,
I think I have 3 improvements for you:
1. The time you print,is a calculated time, not the actual time when the printing occurs. I mean: You create a Calendar instance when you start your program, and then add 300000 ms (= 5 minutes in ms precision) every time the loop is executed. If for some reason, there is some delay somewhere, you will not easily notice, because your program prints what it calculated as the current time, which is not necessarily the current time.
What I did in my solution, was creating a new Calendar instance every time I need to print the current time, and then get the time from this instance.
When I made my 1st solution to this homework, using Threads, I used a sleep for 5 minutes, expecting that I would receive a printout every 5 minutes. Running this program for an entire night, I noticed that my printouts showed a few seconds past the 5 minutes. I guess this was caused by the time the statements were using every during every loop. Imagine the error when the program would be running for weeks, or even months. If I would have printed a calculated time, I would probably not have noticed this error.
Bottom line of this improvement: I think it is better to print the contents of the system clock, rather than calculating what you think is the time.
2. When calculating the start time for your 5 minute Timer, yous use only second precision. After that, you use millisecond precision to calculate the next 5 minute time. What you don't take into account is that your startCalendar also has a millisecond field. Ideally, this has the value 0, but in the worst case, it has the value 999, causing your start time to be 1 second too late.
My solution for this homework uses the epoch value of the current time (the milliseconds since midnight of jan 1, 1970) to calculate the start time. You can read this value from a Calendar instance using the method getTimeInMillis().
The algorithm I use:
- Divide the current epoch value by 300000 (= 5 minutes).
- Increase the result by 1, and multiply again with 300000. This gives me the epoch value for the next 5 minute period, with millisecond precision.
- The difference between this calculated epoch, and the current epoch, is the number of milliseconds delay I need to be (almost) exactly at the next multiple of 5 minutes.
- Finally, I use the method scheduleAtFixedRate(task, initialDelay, 300000), whereas you use scheduleAtFixedRate(task, startDate, 300000)
I used the same procedure to calculate the start time of the 30 second intervals during the uneven 5minute periods. I ran this program for more then a day, and it always printed exactly at multiples of 5 minutes or 30 seconds (printing the system clock, not a calculated value :-) )
As a test, I also printed the delay that I calculated at the start of the 30 second task. It appeared that the delay that was calculated, was always around 29960 milliseconds (+/- 10). Therefore, I believe that my printouts are made with a millisecond value close to 0, every time.
Bottom line of this remark: Using epoch to calculate the start time is more accurate than making calculations with minute and second values.
3. In the method startReading in class Homework1, you trust that you receive the method call at an exact multiple of 5 minutes. If for some reason, the method was received with a delay, all your 30 second printouts will suffer from this delay. If on the other hand you calculate the delay until the next multiple of 30 seconds (same calculation as in point 2, but divide / multiply by 30000 instead of 300000°) then the first 30 second printout will suffer from the delay, but all other printouts will come (almost) at multiples of 30 seconds with millisecond precision. I believe this makes the solution a bit more robust.
Bottom line of this remark: Never trust that you get what you expect, always verify what you get.

Requesting peer review of coding technique.

Similar Messages

Maybe you are looking for