SP creation

Question

Hi all,
I need your help in creating a stored procedure. Since I've not used PL SQL in years, it seems to be complicated to me now.. I would appreciate any kind of help.
I created a table called auditing. This table needs to be inserted/updated via the SP by comparing/evaluating with another table acfg. Data in acfg will be entered by the users. Sample Data of acfg table:
ID     Mand     Bcode     Skey     I_O     Tname     Cname                     Func      Group_col1        WhereSQL           Message
1     M1     P1     1     O     Table1     COUNTRY                     COUNT        COUNTRY                      %1 entries found for  %2
2     M1     P1     2     O     Table1     FIRSTNAME               COUNT                                  %1 total lines
3     M1     P2     1     I     Table1     FIRSTNAME             COUNT                                   %1 lines found
SQL>desc auditing;
Name                       Null?                              Type
ID                     NOT NULL                         NUMBER(5)
CDATE                                               DATE
CCODE                                           VARCHAR2(10)             
CTERM                                            VARCHAR2(255)
PID                                            NUMBER(20)                 
MAND                                           VARCHAR2(10)             
SKEY                                            NUMBER(10)
MESSAGE                                      VARCHAR2(2000)         
SOURCE                                               VARCHAR2(255)
SOURCE_YN                                        VARCHAR2(1)The stored procedure auditingsp will be called with these input parameters (pid, mand, bcode, opp, I_O, source).
*1*. SP should insert record into auditing table.
*2.* If acfg.v_yn is ‘Y’ (compare with mand=acfg.mand, bcode=acfg.bcode) following logic should be used:
SP should generate a dynamic sql from the a.cfg table
select func(column_name) from tname where mand=’…’ (If I_O=’I’)
select func(column_name) from tname where mand=’…’ and pid=’…’ (If I_O = ‘O’)
So, query for the 1st record in acfg table should be select count(country) from table1 where mand=’M1’ and pid=’..’ group by country;
Note: group_col1, group_col2, group_col3 are optional. But should be considered in the select query when NOT NULL.
*3.* The output of the above query should be written to auditing.message field by filling in the result of the above query in the acfg.message field.
In this example, acfg.message has this value: %1 entries found for %2. So %1 and %2 should be filled in from the output of the above query. The auditing.message should have this
value 20 entries found for Germany.
For the acfg table above, the auditing table should be inserted/updated like this:
ID     Cdate                            Ccode           Pid     Mand     Skey     Message
1     01.04.2009 08:30:00              P1          12345     M1     1     20 entries found for Germany
2     01.04.2009 08:30:01              P1          12345     M1     2     10 entries found for USA
3     01.04.2009 08:30:02              P1          12345     M1     3     2  entries found for Denmark
4     01.04.2009 08:30:03              P1          12345     M1     4     32 total lines
5     01.04.2009 08:31:00              P2          12346     M1     1     32 lines found*4.*     Also, skey in auditing table should be assigned for every I or O call based on mand and bcode in the SP.
Please give me your suggestions on this for steps 2,3 and 4.. I'm not sure if I need to use cursors for step 2 & 3.
CREATE OR REPLACE procedure PUBS.auditingsp (pid IN number, mand IN varchar2, bcode IN varchar2, opp IN number, source IN varchar2)
IS
BEGIN
declare
seqno number(38);
begin
select audseq.nextval into seqno from dual ;
   insert into auditing (ID,cdate,pid,mand,source)
    values(seqno,sysdate,pid,mand,source);
/* steps 2,3,4 */
end;
end auditingsp;
/Thanks a lot for all your help
Edited by: newbiegal on Jul 6, 2009 2:07 PM
Edited by: newbiegal on Jul 6, 2009 2:10 PM
Edited by: newbiegal on Jul 7, 2009 11:53 AM

Answer 1

I've created the procedure like Frank suggested.. The procedure runs fine without the if else conditions..
Stored procedure is created for auditing records in the batch tables. Batch process calls the Stord procedure at the beginning of the batch with 'i' parameter(Only the acfg.i_o='i' records should be audited) and the batch calls the stored procedure with 'o' parameter at the end of the batch(Only the acfg.i_o='o' records should be written to the auditing table. So, the stored procedure writes the message(by evaluating with acfg table) into the auditing table pre batch and post batch. There will be 2 conditions in the procedure:
1. Only if acfg.v_yn ='Y', record should be inserted into auditing table. if acfg.v_yn ='N', data should be ignored.
2. Read the records in acfg table(cursor aud_cur in the Stored procedure) order by mand,bcode,i_o,skey.
3. If pi_i_o = 'i' then
a. Build sql evaluating the records in acfg table like
select func(cname) from tname where mand = pi_mand and
wheresql ='..' group by group_col1,group_col2,
group_col3 /* wheresql should be considered when there
is a where clause in tname for example if there is an
expression customer=3 in the wheresql. group_col1,
group_col2, group_col3 should also be considered when
there is an expression. */
b. Execute the sql, fetch the output in acfg.message and
insert the message into auditing.message field
4. If pi_i_o= 'o' then
a. Build sql evaluating the records in acfg table like
select func(cname) from tname where mand = pi_mand and
pid = pi_pid wheresql ='..' group by group_col1,
group_col2,group_col3 /* wheresql should be considered
when there is a where clause in tname for example if
there is an expression customer=3 in the wheresql.
group_col1,group_col2, group_col3 should also be
considered when there is an expression. */
b. Execute the sql, fetch the output in acfg.message and
insert the message into auditing.message field.
I created this procedure below, it works but when I try with the condition for 'i' and 'o' parameters it doesnt work..
create table auditing (
     id number(5) not null,
     cdate date,
     ccode varchar2(10),
     cterm varchar2(255),
     pid number(20),
     mand varchar2(10),
     skey number(10),
     message varchar2(2000),
     source varchar2(255),
     source_YN varchar2(1)
create table acfg (
     id number(10) not null,
     v_YN varchar2(1),
     mand varchar2(10),
     bcode varchar2(10),
     skey number(10),
     i_o varchar2(3),
     tname varchar2(255),
     cname varchar2(255),
     func varchar2(64),
     group_col1 varchar2(255),
     group_col2 varchar2(255),
     group_col3 varchar2(255),
     message_id number(10),
     wheresql varchar2(2000),
     message varchar2(2000)
insert into acfg (id,mand,bcode,skey,i_o,tname,cname,func,group_col1,message)
values (1,'M1','P1',1,'o','table1','country','count','country','%1 entries found for %2');
insert into acfg (id,mand,bcode,skey,i_o,tname,cname,func,message)
values (2,'M1','P1',2,'o','table1','firstname','count','%1 total lines');
insert into acfg (id,mand,bcode,skey,i_o,tname,cname,func,message)
values (3,'M1','P2',1,'i','table1','firstname','count','%1 lines found');
create table table1
         (country   varchar2(30),
          firstname varchar2(30),
          mand      varchar2(10),
          pid       number(20)
CREATE SEQUENCE audseq
     MINVALUE 1
        MAXVALUE 999999999999999999999999999
       START WITH 1
        INCREMENT BY 1
        CACHE 2;
CREATE OR REPLACE PROCEDURE auditingsp
      ( pi_pid    IN auditing.pid%TYPE
      , pi_mand   IN acfg.mand%TYPE
      , pi_bcode  IN acfg.bcode%TYPE
      , pi_opp    IN NUMBER
      , pi_i_o    IN acfg.i_o%TYPE
      , pi_source IN auditing.source%TYPE )
     AS
      CURSOR aud_cur IS
        SELECT *
        FROM     acfg
        WHERE    mand = pi_mand
                 AND bcode = pi_bcode
                 AND ((UPPER (pi_I_O) = 'I')
                 OR (UPPER (pi_I_O) = 'O'))
                 ORDER  BY skey;
     TYPE acfg_tab IS TABLE OF aud_cur%ROWTYPE;
     acfg_array     acfg_tab;
     i_sql          VARCHAR2 (32767);
     c1          SYS_REFCURSOR;
     v_num          NUMBER;
     v_col          VARCHAR2 (30);
     BEGIN
     OPEN aud_cur;
     LOOP
         FETCH aud_cur BULK COLLECT INTO acfg_array LIMIT 1000;
         EXIT WHEN acfg_array.COUNT = 0;
         FOR i IN 1 .. acfg_array.COUNT LOOP
           i_sql :=
                'SELECT ' || acfg_array(i).func || '(*) num, '
                      || acfg_array(i).cname || ' col'
             ||   ' FROM ' || acfg_array(i).tname
             ||   ' WHERE mand = :pi_mand'
            ||   ' AND ' || NVL (acfg_array(i).wheresql, '1=1')
             ||   ' GROUP BY ' || acfg_array(i).cname
             ||   ' ORDER BY num DESC';
           OPEN c1 FOR i_sql USING pi_mand;
          LOOP
             FETCH c1 INTO v_num, v_col;
             EXIT WHEN c1%NOTFOUND;
             INSERT INTO auditing
               (id, cdate, ccode, pid, mand, skey, source, message)
             SELECT audseq.NEXTVAL, SYSDATE, acfg_array(i).bcode, pi_pid,
                 acfg_array(i).mand, acfg_array(i).skey, pi_source,
                REPLACE (REPLACE (acfg_array(i).message, '%1', v_num), '%2', v_col)
            FROM   DUAL;
           END LOOP;
           CLOSE c1;
         END LOOP;
    END LOOP;
     CLOSE aud_cur;
END auditingsp;
SQL>EXEC auditingsp (12345, 'M1', 'P1', 0, 'i', 'source1')
PL/SQL procedure successfully completed.
SQL>SELECT id, cdate, ccode, pid, mand, skey, message  FROM   auditing;
        ID CDATE     CCODE             PID MAND       SKEY MESSAGE
         1 09-JUL-09 P1              12345 M1            1 20 entries found for Germany
         2 09-JUL-09 P1              12345 M1            1 10 entries found for USA
         3 09-JUL-09 P1              12345 M1            1 2 entries found for Denmark
         4 09-JUL-09 P2              12345 M1            1 32 lines found
         5 09-JUL-09 P1              12345 M1            2 32 total linesBut the sort key needs to be assigned in a sequence for every ccode,pid and mand. Like:
  ID CDATE     CCODE             PID MAND       SKEY MESSAGE
         1 09-JUL-09 P1              12345 M1            1 20 entries found for Germany
         2 09-JUL-09 P1              12345 M1            2 10 entries found for USA
         3 09-JUL-09 P1              12345 M1            3 2 entries found for Denmark
         4 09-JUL-09 P2              12345 M1            4 32 lines found
         5 09-JUL-09 P1              12345 M1            2 32 total linesI tried the below procedure with if else clauses with the conditions 'i' and 'o' parameters,
SQL>   CREATE OR REPLACE PROCEDURE auditingsp
  2    ( pi_pid    IN auditing.pid%TYPE
  3    , pi_mand   IN acfg.mand%TYPE
  4    , pi_bcode  IN acfg.bcode%TYPE
  5    , pi_opp    IN NUMBER
  6    , pi_i_o    IN acfg.i_o%TYPE
  7    , pi_source IN auditing.source%TYPE )
  8  AS
  9    CURSOR aud_cur IS
10        SELECT *
11        FROM     acfg
12        WHERE     mand = pi_mand
13        AND bcode = pi_bcode                                              /* added */
14         AND     ((UPPER (pi_I_O) = 'I')
15        OR     (UPPER (pi_I_O) = 'O'))
16        ORDER     BY skey;
17    TYPE acfg_tab IS TABLE OF aud_cur%ROWTYPE;
18    acfg_array     acfg_tab;
19    i_sql          VARCHAR2 (32767);
20    o_sql          VARCHAR2 (32767);                                    /* added */
21    c1          SYS_REFCURSOR;
22    v_num          NUMBER;
23    v_col          VARCHAR2 (30);
24  BEGIN
25   OPEN aud_cur;
26   LOOP
27      FETCH aud_cur BULK COLLECT INTO acfg_array LIMIT 1000;
28      EXIT WHEN acfg_array.COUNT = 0;        
29   If upper(acfg_array(i).v_yn) = 'Y'  THEN                                         /* added */
30     If UPPER (pi_i_o) = 'I' THEN                                                  /* added */
31       FOR i IN 1 .. acfg_array.COUNT LOOP
32         i_sql :=
33               'SELECT ' || acfg_array(i).func || '(*) num, '
34                     || acfg_array(i).cname || ' col'
35           ||   ' FROM ' || acfg_array(i).tname
36            ||   ' WHERE mand = :pi_mand'
37           ||   ' AND ' || NVL (acfg_array(i).wheresql, '1=1')
38            ||   ' GROUP BY ' || acfg_array(i).cname
39            ||   ' ORDER BY num DESC';
40          OPEN c1 FOR i_sql USING pi_mand;
41         LOOP
42          FETCH c1 INTO v_num, v_col;
43            EXIT WHEN c1%NOTFOUND;
44           INSERT INTO auditing
45              (id, cdate, ccode, pid, mand, skey, source, message)
46            SELECT audseq.NEXTVAL, SYSDATE, acfg_array(i).bcode, pi_pid,
47                acfg_array(i).mand, acfg_array(i).skey, pi_source,
48               REPLACE (REPLACE (acfg_array(i).message, '%1', v_num), '%2', v_col)
49            FROM   DUAL;
50           END LOOP;
51           CLOSE c1;
52       END LOOP;
53     ELSIF UPPER (pi_i_o) = 'O'  THEN                                                 /* added */
54      FOR i IN 1 .. acfg_array.COUNT LOOP                                          /* added */
55           o_sql :=
56               'SELECT ' || acfg_array(i).func || '(*) num, '
57                     || acfg_array(i).cname || ' col'
58           ||   ' FROM ' || acfg_array(i).tname
59            ||   ' WHERE mand = :pi_mand'
60          ||   ' AND ' || 'pid = :pi_pid'                                            /* added */
62           ||   ' AND ' || NVL (acfg_array(i).wheresql, '1=1')
63            ||   ' GROUP BY ' || acfg_array(i).cname
64            ||   ' ORDER BY num DESC';
65          OPEN c1 FOR o_sql USING pi_mand, pi_pid;
66         LOOP
67          FETCH c1 INTO v_num, v_col;
68            EXIT WHEN c1%NOTFOUND;
69            INSERT INTO auditing
70              (id, cdate, ccode, pid, mand, skey, source, message)
71            SELECT audseq.NEXTVAL, SYSDATE, acfg_array(i).bcode, pi_pid,
72                acfg_array(i).mand, acfg_array(i).skey, pi_source,
73               REPLACE (REPLACE (acfg_array(i).message, '%1', v_num), '%2', v_col)
74           FROM   DUAL;
75           END LOOP;
76           CLOSE c1;
77       END LOOP;
78     ELSIF  upper(acfg_array(i).v_yn) = 'N'  THEN   
79     dbms_output.put_line('Data is ignored');
80     END if;
81 END if;
82 END LOOP;
83 CLOSE aud_cur;
84 END auditingsp;
I'm getting this error: PROCEDURE AUDITINGSP
On line:  30
PLS-00201: identifier 'I' must be declared
Line 30 if pi_i_o = 'I' is from the argument passed to the procedure, do I still have to declare it?
Please help me, thanks very much for your support.
Edited by: newbiegal on Jul 9, 2009 11:10 AM