System is not picking up approvers from BADI in Item level workflow

Question

Hi All,
My problem is that
1. when I creat the shopping cart the system is picking up the correct approver from BADI and showing it in approval preview.
2. My first level approver is a general task so Workitem going to the correct persons.
3. after first level approver I am fillng approver in BADI for 2 nd level.
4. But after first approval the SC is directly getting approved finally as system is not picking up approvers from the BADI.
I dont understand the problem. even We applied SP9 as well, but the problem is not resolved.
Please suggest something.
Thanks
Smita

Answer 1

Hi ,
I am pasting the code of my BADI.  Let me know if i need to do some changes.
Regards,
smita
if lv_wf = '4'.
1st approval step executed for indices 1 and 0
      IF actual_approval_index LE 1.
First approval step (General task)
endif.
2. approval step executed for indices 2,1 and 0
      IF actual_approval_index LE 2.
*break-point.
**get the approver for the commodity
         LOOP AT lt_item INTO ls_item WHERE del_ind IS INITIAL.
We consider only items, which are not deleted (del_ind = 'X')
Set the product category
            MOVE ls_item-category_id TO lv_call_value1.
Find the approver of this item based on the customizing table ZCOMMODITY
CALL FUNCTION 'ZWF_COMODITY_ITEM_APPROVAL_GET'
   EXPORTING
     SC_GUID                          = ls_header-guid
     ITEM_GUID                        = ls_item-guid
   APPROVAL_DESCRIPTION             =
    HIDE_ITEMS_NOT_RESPONSIBLE       = 'X'
     CRITERION1                       = 'COMMODITY'
     CATEGORY_ID                      = ls_item-category_id
     ITEM_VALUE                       = ls_item-VALUE
     APPROVAL_INDEX                   = '2'
   CHANGING
     APPROVAL_TABLE                   = approval_table
     ITEM_APPROVAL_TABLE              = item_approval_table
    ITEM_APPROVAL_OBJ                = item_approval_obj
endloop.
*ELSEIF actual_approval_index EQ 2.
don't process 2nd step
         no_further_approval_needed = 'X'.
endif.
endif. " if lv_wf = '4'.
FUNCTION ZWF_COMODITY_ITEM_APPROVAL_GET.
""Local Interface:
*"  IMPORTING
*"     VALUE(SC_GUID) TYPE  BBP_GUID
*"     VALUE(ITEM_GUID) TYPE  BBP_GUID
*"     VALUE(APPROVAL_DESCRIPTION) TYPE  BBP_STEP_DESCRIPTION OPTIONAL
*"     VALUE(HIDE_ITEMS_NOT_RESPONSIBLE) TYPE  BOOLEAN OPTIONAL
*"     REFERENCE(CRITERION1) TYPE  BBP_WFL_APP_CRITERION
*"     VALUE(CATEGORY_ID) TYPE  ZBBP_CATEGORY_ID
*"     VALUE(ITEM_VALUE) TYPE  BBP_VALUE
*"     VALUE(APPROVAL_INDEX) TYPE  SWH_NUMC10
*"  CHANGING
*"     REFERENCE(APPROVAL_TABLE) TYPE  BBPT_WFL_APPROVAL_TABLE_BADI
*"     REFERENCE(ITEM_APPROVAL_TABLE) TYPE  BBPT_WFL_ITEM_APPROVAL_BADI
*"     REFERENCE(ITEM_APPROVAL_OBJ) TYPE  BBPT_WFL_ITEM_APPROVAL_OBJ
*"       OPTIONAL
this Function Module is for getting the commodity approvers
for the commodity items, in the Shopping cart
  DATA:
    ls_approval_table      TYPE bbp_wfl_approval_table_badi,
    ls_item_approval_table TYPE bbps_wfl_item_approval,
    ls_approval_def        TYPE bbpt_wfl_lia_def,
    ls_item_approval_obj   TYPE BBPS_WFL_ITEM_APPROVAL_OBJ.
  DATA:
    lv_app_obj_guid   TYPE bbp_guid_32,
    lv_is_new_approval_object TYPE boolean.
**structure for commodity data
data : ls_commodity type zcommodity.
data : lv_value1 type BBP_WFL_APP_PROPERTY.
  CONSTANTS:
      c_agent_is_user TYPE otype VALUE 'US'.
First find the right approval object the item belongs to.
All items of an approval object are approved togheter in
this approval step, and therefore only one workitem is
created for this items. IF possible use this standard function
BBP_WFL_DIN_APP_OBJ_GET for creating the approval object.
lv_value1 = category_id.
CALL FUNCTION 'BBP_WFL_DIN_APP_OBJ_GET'
  EXPORTING
    SC_GUID                      = sc_guid
    CRITERION1                   = criterion1
  CRITERION2                   = ''
  CRITERION3                   = ''
   VALUE1                       = lv_value1
  VALUE2                       = ''
  VALUE3                       = ''
IMPORTING
   APPROVAL_OBJ_GUID            = lv_app_obj_guid
  IS_NEW_APPROVAL_OBJECT       =
  TABLES
    ITEM_APP_OBJ                 = item_approval_obj
              CALL FUNCTION 'BBP_WFL_DIN_APP_OBJ_GET'
                EXPORTING
                  SC_GUID                      = sc_guid
                  CRITERION1                   = criterion1
                 CRITERION2                   = ''
                 CRITERION3                   = ''
                 VALUE1                       = lv_value1
                 VALUE2                       = ''
                 VALUE3                       = ''
                 IV_ITEM_VALUE                = ITEM_VALUE
               IMPORTING
                 APPROVAL_OBJ_GUID            = lv_app_obj_guid
                 IS_NEW_APPROVAL_OBJECT       =
                TABLES
                  ITEM_APP_OBJ                 = item_approval_obj.
CALL FUNCTION 'BBP_WFL_DIN_APP_OBJ_GET'
   EXPORTING
     sc_guid                 = sc_guid
     criterion1              = criterion1
  CRITERION2              = ''
  CRITERION3              = ''
     value1                  = category_id
  VALUE2                  = ''
  VALUE3                  = ''
  IMPORTING
If 2 items of the same shopping cart have the same
values for the criterias, this function returns the
same (!!!) approval object guid
    approval_obj_guid       = lv_app_obj_guid
   TABLES
This table saves the criterias  for which the approval object
was created. For example:
|approval object1| "cost center" | 1000   |
|approval object2| "cost center" | 1200   |
|approval object3| "prod categ " | office |
    item_app_obj            = item_approval_obj
Check if this approval object already exists in the approval
table
  READ TABLE approval_table INTO ls_approval_table
          WITH KEY approval_object_guid = lv_app_obj_guid
                   approval_index       = approval_index.
  IF sy-subrc EQ 4.
    lv_is_new_approval_object = 'X'.
  ENDIF.
  IF lv_is_new_approval_object = 'X'.
Now read your own approval table based on your criteria's
**now check whether the category id is a commodity material and
*find the responsible person for that and
*check if the amount of item is falling in the approval limit of the comodity manager
select single * from zcommodity into ls_commodity
where CATEGORY_ID = category_id
and ( ZFROMAMT <= item_value and ZTOAMT >= item_value ).
   SELECT * FROM bbpt_wfl_lia_def
            INTO CORRESPONDING FIELDS OF ls_approval_def
            WHERE
                  app_crit_name1  = criterion1 AND
                  app_crit_value1 = value1
   ENDSELECT.
    IF sy-subrc NE 4.
Fill approval table (who is responsible for which approval
object in which approval step)
      ls_approval_table-approval_index       = approval_index.
     CONCATENATE c_agent_is_user ls_approval_def-approval_agent1
                             INTO ls_approval_table-approval_agent.
CONCATENATE c_agent_is_user ls_commodity-person
                              INTO ls_approval_table-approval_agent.
      ls_approval_table-name = ls_commodity-name.
      ls_approval_table-approval_description = approval_description.
      ls_approval_table-approval_object_guid = lv_app_obj_guid.
      ls_approval_table-hide_items_not_responsible =
                              hide_items_not_responsible.
      APPEND ls_approval_table TO approval_table.
     IF ls_approval_def-approval_agent2 IS NOT INITIAL.
Second approver for the same workitem exists
       CONCATENATE c_agent_is_user ls_approval_def-approval_agent2
                           INTO ls_approval_table-approval_agent.
       ls_approval_table-name = ls_approval_def-agent_string2.
       APPEND ls_approval_table TO approval_table.
     ENDIF.
    ENDIF.
  ENDIF.
Fill item table (Which items belongs to which approval object)
  ls_item_approval_table-approval_object_guid = lv_app_obj_guid.
  ls_item_approval_table-approval_item_guid   = item_guid.
  APPEND ls_item_approval_table TO item_approval_table.
**Fill Item approval object
ls_item_approval_obj-sc_guid = sc_guid.
ls_item_approval_obj-APP_CRIT_NAME1 = CRITERION1.
ls_item_approval_obj-APP_CRIT_VALUE1 = CATEGORY_ID.
ls_item_approval_obj-APPROVAL_OBJECT_GUID = lv_app_obj_guid.
append ls_item_approval_obj to ITEM_APPROVAL_OBJ.